)]}'
{"id":"lttng-tools~7478","triplet_id":"lttng-tools~master~Ibeca9b675b86fc46be3f57826f7158de4da43df8","project":"lttng-tools","branch":"master","topic":"metadata-channel-setup-uaf","attention_set":{},"removed_from_attention_set":{"1000006":{"account":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"last_update":"2022-03-04 19:39:19.000000000","reason":"\u003cGERRIT_ACCOUNT_1000006\u003e replied on the change","reason_account":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]}}},"hashtags":[],"change_id":"Ibeca9b675b86fc46be3f57826f7158de4da43df8","subject":"Fix: consumerd: use-after-free of metadata bucket","status":"MERGED","created":"2022-03-03 00:53:35.000000000","updated":"2022-03-08 20:19:28.000000000","submitted":"2022-03-08 20:19:28.000000000","submitter":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"7492-metadata-channel-setup-uaf","meta_rev_id":"efc2686aff7c48efedecbf5d9d62bc7b91f35565","_number":7478,"virtual_id_number":7478,"owner":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"optional":true},"Verified":{"all":[{"value":0,"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{"-2":"Failure","-1":"Not built"," 0":"No score","+1":"Unstable","+2":"Success"},"description":"CI Build results","default_value":0,"optional":true},"CI-Build":{"all":[{"value":0,"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"values":{" 0":"No score","+1":"Trigger a CI Build only","+2":"Trigger a CI Build with Fast Tests","+3":"Trigger a CI Build with Complete Tests"},"description":"Trigger CI builds","default_value":0,"optional":true},"Smoke-Build-Lvl1":{"all":[{"value":0,"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"default_value":0},"Smoke-Build-Lvl2":{"all":[{"value":0,"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]}],"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-03-03 22:30:52.000000000","updated_by":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-03-03 23:03:55.000000000","updated_by":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"95797fb5e13b7385cfafd8f83ea39353474bea02","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-03 00:53:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"54870d755b338f30036472ebbcd5aeb812af439d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-03 22:30:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c9142400c60dc8c51e0ef88ba5e6fdcbf4f17fd2","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-03 22:30:46.000000000","message":"Patch Set 2: CI-Build+1","accounts_in_message":[],"_revision_number":2},{"id":"d600af0603db6880584340d021fd418a1537f9d0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-03 22:30:52.000000000","message":"Patch Set 2:\n\nBuild Started https://ci.lttng.org/job/dev_gerrit_lttng-tools_rootbuild/2020/ (1/2)","accounts_in_message":[],"_revision_number":2},{"id":"b3f3a26f06a58e2347d993d16ef553786cbb293a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-03 22:30:53.000000000","message":"Patch Set 2:\n\nBuild Started https://ci.lttng.org/job/dev_gerrit_lttng-tools_build/3082/ (2/2)","accounts_in_message":[],"_revision_number":2},{"id":"c039e1ed9254eaa76d7897e292ab1dfea57c3288","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-03 23:03:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b1216afdb32c51c6396af3d1df2ee6a9931210eb","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-03 23:03:54.000000000","message":"Patch Set 3: CI-Build+1","accounts_in_message":[],"_revision_number":3},{"id":"26fb7344a7fe420e04b4437a7a78359e608dcfa9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-03 23:03:55.000000000","message":"Patch Set 2: Verified-2\n\nBuild Failed \n\nhttps://ci.lttng.org/job/dev_gerrit_lttng-tools_build/3082/ : ABORTED\n\nhttps://ci.lttng.org/job/dev_gerrit_lttng-tools_rootbuild/2020/ : ABORTED","accounts_in_message":[],"_revision_number":2},{"id":"c05baf09a1d60312957c1c0ac71771f4d27595ee","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-03 23:04:03.000000000","message":"Patch Set 3:\n\nBuild Started https://ci.lttng.org/job/dev_gerrit_lttng-tools_build/3084/ (1/2)","accounts_in_message":[],"_revision_number":3},{"id":"89f9cfad67e029746e46fabbb2b865e5514a2e5b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-03 23:04:03.000000000","message":"Patch Set 3:\n\nBuild Started https://ci.lttng.org/job/dev_gerrit_lttng-tools_rootbuild/2022/ (2/2)","accounts_in_message":[],"_revision_number":3},{"id":"644d1e0051107b971a6387ec973d715e43e0c90f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-04 00:02:06.000000000","message":"Patch Set 3: Verified-2\n\nBuild Failed \n\nhttps://ci.lttng.org/job/dev_gerrit_lttng-tools_rootbuild/2022/ : FAILURE\n\nhttps://ci.lttng.org/job/dev_gerrit_lttng-tools_build/3084/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"2e483b862efaa9a5d7c13a5efb8281e79eefc2e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-04 19:38:53.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"45b87cbdf8982dba18e0b0419913ab8bb41413bd","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-04 19:39:19.000000000","message":"Patch Set 4: CI-Build+1","accounts_in_message":[],"_revision_number":4},{"id":"7b9644bc71e4b5a8aba8c5213ea1d51c9b46b0be","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-04 19:39:27.000000000","message":"Patch Set 4:\n\nBuild Started https://ci.lttng.org/job/dev_gerrit_lttng-tools_build/3086/ (1/2)","accounts_in_message":[],"_revision_number":4},{"id":"c3d8be2e0bd793f3366e79475b996241f934d58a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-04 19:39:28.000000000","message":"Patch Set 4:\n\nBuild Started https://ci.lttng.org/job/dev_gerrit_lttng-tools_rootbuild/2024/ (2/2)","accounts_in_message":[],"_revision_number":4},{"id":"c4f26eba3ee892e3240241149d19514f38ff226e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000002,"name":"jenkins","email":"jenkins@lttng.org","username":"jenkins","avatars":[{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e3f1da3d4191917309975c0380f40764.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"tags":["SERVICE_USER"]},"date":"2022-03-04 20:47:10.000000000","message":"Patch Set 4: Verified+2\n\nBuild Successful \n\nhttps://ci.lttng.org/job/dev_gerrit_lttng-tools_build/3086/ : SUCCESS\n\nhttps://ci.lttng.org/job/dev_gerrit_lttng-tools_rootbuild/2024/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"86d40318f5012d503737702f4ca6f33f3cf94e99","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-07 17:36:08.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"efc2686aff7c48efedecbf5d9d62bc7b91f35565","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2022-03-08 20:19:28.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"5c5e3d718d8248d5e075f64c34667c4c4617ae63","revisions":{"f8422787e8aeb0b46e83fc3cab3e25a120dfe4f1":{"kind":"REWORK","_number":1,"created":"2022-03-03 00:53:35.000000000","uploader":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"ref":"refs/changes/78/7478/1","fetch":{"anonymous http":{"url":"https://review.lttng.org/lttng-tools","ref":"refs/changes/78/7478/1","commands":{"Branch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/1 \u0026\u0026 git checkout -b change-7478 FETCH_HEAD","Checkout":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.lttng.org/lttng-tools refs/changes/78/7478/1","Reset To":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9402f1669d8035e4c5618652b92a3d29defbcd70","subject":"Fix: sessiond: `break` used instead of `goto`","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d9402f1669d8035e4c5618652b92a3d29defbcd70"}]}],"author":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 00:27:31.000000000","tz":-300},"committer":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 00:52:37.000000000","tz":-300},"subject":"WIP: Fix: consumerd: use-after-free of metadata bucket","message":"WIP: Fix: consumerd: use-after-free of metadata bucket\n\nCauses a crash when destroying the session after a metadata setup\nerror.\n\nmy hunch is that cds_list_del(\u0026stream-\u003esend_node) should probably\nnot be performed when the stream is not in the channel\u0027s list.\n\n\u003d\u003d2511301\u003d\u003dERROR: AddressSanitizer: SEGV on unknown address 0x00062e0000f9 (pc 0x7f2c9ac0b463 bp 0x604000002c10 sp 0x7f2c92bf8050 T6)\n\u003d\u003d2511301\u003d\u003dThe signal is caused by a READ memory access.\n    #0 0x7f2c9ac0b463 in _shmp_offset ringbuffer/shm.h:49\n    #1 0x7f2c9ac0b463 in lib_ring_buffer_release_read ringbuffer/ring_buffer_frontend.c:1278\n    #2 0x7f2c9ac01b16 in lttng_ust_ctl_destroy_stream /home/jgalar/EfficiOS/src/lttng-ust/src/lib/lttng-ust-ctl/ustctl.c:1676\n    #3 0x55c834a9eda4 in lttng_ustconsumer_del_stream(lttng_consumer_stream*) ust-consumer/ust-consumer.cpp:2541\n    #4 0x55c834a4ece0 in consumer_stream_destroy_buffers(lttng_consumer_stream*) consumer/consumer-stream.cpp:1006\n    #5 0x55c834a4ef8b in destroy_close_stream consumer/consumer-stream.cpp:1024\n    #6 0x55c834a4f4f9 in consumer_stream_destroy(lttng_consumer_stream*, lttng_ht*) consumer/consumer-stream.cpp:1104\n    #7 0x55c834a23a68 in clean_channel_stream_list consumer/consumer.cpp:184\n    #8 0x55c834a24618 in consumer_del_channel(lttng_consumer_channel*) consumer/consumer.cpp:376\n    #9 0x55c834a4f4eb in consumer_stream_destroy(lttng_consumer_stream*, lttng_ht*) consumer/consumer-stream.cpp:1101\n    #10 0x55c834a25a4c in consumer_del_stream(lttng_consumer_stream*, lttng_ht*) consumer/consumer.cpp:546\n    #11 0x55c834a36ba4 in consumer_thread_data_poll(void*) consumer/consumer.cpp:2780\n    #12 0x7f2c9a7315c1 in start_thread (/usr/lib/libc.so.6+0x8d5c1)\n    #13 0x7f2c9a7b6583 in __clone (/usr/lib/libc.so.6+0x112583)\n\nSigned-off-by: Jérémie Galarneau \u003cjeremie.galarneau@efficios.com\u003e\nChange-Id: Ibeca9b675b86fc46be3f57826f7158de4da43df8\n","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003df8422787e8aeb0b46e83fc3cab3e25a120dfe4f1"}],"resolve_conflicts_web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003df8422787e8aeb0b46e83fc3cab3e25a120dfe4f1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9402f1669d8035e4c5618652b92a3d29defbcd70","is_merged_in_target_branch":true,"change_id":"Ife3b5486b8463242dfecb61a3a9718e8eb7149b4","change_number":7432,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"5d5762f0d3d86d45f905266b98562f10454f4c06":{"kind":"REWORK","_number":2,"created":"2022-03-03 22:30:30.000000000","uploader":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"ref":"refs/changes/78/7478/2","fetch":{"anonymous http":{"url":"https://review.lttng.org/lttng-tools","ref":"refs/changes/78/7478/2","commands":{"Branch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/2 \u0026\u0026 git checkout -b change-7478 FETCH_HEAD","Checkout":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.lttng.org/lttng-tools refs/changes/78/7478/2","Reset To":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"14e34907ffbc9645f8ed799b74e04d9c850df4f0","subject":"Fix: relayd: connection abruptly closed on viewer stream creation failure","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d14e34907ffbc9645f8ed799b74e04d9c850df4f0"}]}],"author":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 00:27:31.000000000","tz":-300},"committer":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 22:29:45.000000000","tz":-300},"subject":"WIP: Fix: consumerd: use-after-free of metadata bucket","message":"WIP: Fix: consumerd: use-after-free of metadata bucket\n\nCauses a crash when destroying the session after a metadata setup\nerror.\n\nmy hunch is that cds_list_del(\u0026stream-\u003esend_node) should probably\nnot be performed when the stream is not in the channel\u0027s list.\n\n\u003d\u003d2511301\u003d\u003dERROR: AddressSanitizer: SEGV on unknown address 0x00062e0000f9 (pc 0x7f2c9ac0b463 bp 0x604000002c10 sp 0x7f2c92bf8050 T6)\n\u003d\u003d2511301\u003d\u003dThe signal is caused by a READ memory access.\n    #0 0x7f2c9ac0b463 in _shmp_offset ringbuffer/shm.h:49\n    #1 0x7f2c9ac0b463 in lib_ring_buffer_release_read ringbuffer/ring_buffer_frontend.c:1278\n    #2 0x7f2c9ac01b16 in lttng_ust_ctl_destroy_stream /home/jgalar/EfficiOS/src/lttng-ust/src/lib/lttng-ust-ctl/ustctl.c:1676\n    #3 0x55c834a9eda4 in lttng_ustconsumer_del_stream(lttng_consumer_stream*) ust-consumer/ust-consumer.cpp:2541\n    #4 0x55c834a4ece0 in consumer_stream_destroy_buffers(lttng_consumer_stream*) consumer/consumer-stream.cpp:1006\n    #5 0x55c834a4ef8b in destroy_close_stream consumer/consumer-stream.cpp:1024\n    #6 0x55c834a4f4f9 in consumer_stream_destroy(lttng_consumer_stream*, lttng_ht*) consumer/consumer-stream.cpp:1104\n    #7 0x55c834a23a68 in clean_channel_stream_list consumer/consumer.cpp:184\n    #8 0x55c834a24618 in consumer_del_channel(lttng_consumer_channel*) consumer/consumer.cpp:376\n    #9 0x55c834a4f4eb in consumer_stream_destroy(lttng_consumer_stream*, lttng_ht*) consumer/consumer-stream.cpp:1101\n    #10 0x55c834a25a4c in consumer_del_stream(lttng_consumer_stream*, lttng_ht*) consumer/consumer.cpp:546\n    #11 0x55c834a36ba4 in consumer_thread_data_poll(void*) consumer/consumer.cpp:2780\n    #12 0x7f2c9a7315c1 in start_thread (/usr/lib/libc.so.6+0x8d5c1)\n    #13 0x7f2c9a7b6583 in __clone (/usr/lib/libc.so.6+0x112583)\n\nSigned-off-by: Jérémie Galarneau \u003cjeremie.galarneau@efficios.com\u003e\nChange-Id: Ibeca9b675b86fc46be3f57826f7158de4da43df8\n","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d5d5762f0d3d86d45f905266b98562f10454f4c06"}],"resolve_conflicts_web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d5d5762f0d3d86d45f905266b98562f10454f4c06"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"14e34907ffbc9645f8ed799b74e04d9c850df4f0","is_merged_in_target_branch":true,"change_id":"I557a8b66c1bd1c0bf361cfbabe962d8a6808f4f4","change_number":7477,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"19c22ca3565cac82df77767e7d5eb69a03210e02":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2022-03-03 23:03:27.000000000","uploader":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"ref":"refs/changes/78/7478/3","fetch":{"anonymous http":{"url":"https://review.lttng.org/lttng-tools","ref":"refs/changes/78/7478/3","commands":{"Branch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/3 \u0026\u0026 git checkout -b change-7478 FETCH_HEAD","Checkout":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.lttng.org/lttng-tools refs/changes/78/7478/3","Reset To":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c308759204dac6c133802160b538b07b6ad2ebe","subject":"Fix: ust-consumerd: leak of stream control structure","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d4c308759204dac6c133802160b538b07b6ad2ebe"}]}],"author":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 00:27:31.000000000","tz":-300},"committer":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 23:03:19.000000000","tz":-300},"subject":"WIP: Fix: consumerd: use-after-free of metadata bucket","message":"WIP: Fix: consumerd: use-after-free of metadata bucket\n\nSigned-off-by: Jérémie Galarneau \u003cjeremie.galarneau@efficios.com\u003e\nChange-Id: Ibeca9b675b86fc46be3f57826f7158de4da43df8\n","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d19c22ca3565cac82df77767e7d5eb69a03210e02"}],"resolve_conflicts_web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d19c22ca3565cac82df77767e7d5eb69a03210e02"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4c308759204dac6c133802160b538b07b6ad2ebe","is_merged_in_target_branch":false,"change_id":"Ia4be7969e85bd8812ae13b042e1e100812a63c1d","change_number":7492,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"8cc3ab91df75ea3dcef75a08cfbe6f23307f3a32":{"kind":"REWORK","_number":4,"created":"2022-03-04 19:38:53.000000000","uploader":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"ref":"refs/changes/78/7478/4","fetch":{"anonymous http":{"url":"https://review.lttng.org/lttng-tools","ref":"refs/changes/78/7478/4","commands":{"Branch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/4 \u0026\u0026 git checkout -b change-7478 FETCH_HEAD","Checkout":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.lttng.org/lttng-tools refs/changes/78/7478/4","Reset To":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c308759204dac6c133802160b538b07b6ad2ebe","subject":"Fix: ust-consumerd: leak of stream control structure","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d4c308759204dac6c133802160b538b07b6ad2ebe"}]}],"author":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 00:27:31.000000000","tz":-300},"committer":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-04 19:38:39.000000000","tz":-300},"subject":"WIP: Fix: consumerd: use-after-free of metadata bucket","message":"WIP: Fix: consumerd: use-after-free of metadata bucket\n\nSigned-off-by: Jérémie Galarneau \u003cjeremie.galarneau@efficios.com\u003e\nChange-Id: Ibeca9b675b86fc46be3f57826f7158de4da43df8\n","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d8cc3ab91df75ea3dcef75a08cfbe6f23307f3a32"}],"resolve_conflicts_web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d8cc3ab91df75ea3dcef75a08cfbe6f23307f3a32"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4c308759204dac6c133802160b538b07b6ad2ebe","is_merged_in_target_branch":false,"change_id":"Ia4be7969e85bd8812ae13b042e1e100812a63c1d","change_number":7492,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"17b2b95062215cf1ab1b6c362888c44c7d701fe5":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2022-03-07 17:36:08.000000000","uploader":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"ref":"refs/changes/78/7478/5","fetch":{"anonymous http":{"url":"https://review.lttng.org/lttng-tools","ref":"refs/changes/78/7478/5","commands":{"Branch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/5 \u0026\u0026 git checkout -b change-7478 FETCH_HEAD","Checkout":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.lttng.org/lttng-tools refs/changes/78/7478/5","Reset To":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89198370b8c55c7b40fa5a15becd3c4e757e0f21","subject":"Fix: ust-consumerd: leak of stream control structure","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d89198370b8c55c7b40fa5a15becd3c4e757e0f21"}]}],"author":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 00:27:31.000000000","tz":-300},"committer":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-07 17:36:01.000000000","tz":-300},"subject":"Fix: consumerd: use-after-free of metadata bucket","message":"Fix: consumerd: use-after-free of metadata bucket\n\nObserved issue\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nWhen consumer_stream_destroy() is called from, for example, the error\npath in setup_metadata(), consumer_stream_free() can end up being called\ntwice on the same stream.  Since the stream-\u003emetadata_bucket is not set\nto NULL after being destroyed, it leads to a use-after-free:\n\n ERROR: AddressSanitizer: heap-use-after-free on address 0x604000000318\n READ of size 8 at 0x604000000318 thread T7\n     #0 in metadata_bucket_destroy\n     #1 in consumer_stream_free\n     #2 in consumer_stream_destroy\n     #3 in setup_metadata\n     #4 in lttng_ustconsumer_recv_cmd\n     #5 in lttng_consumer_recv_cmd\n     #6 in consumer_thread_sessiond_poll\n     #7 in start_thread nptl/pthread_create.c:481\n     #8 in clone (/lib/x86_64-linux-gnu/libc.so.6+0xfcbde)\n\n 0x604000000318 is located 8 bytes inside of 48-byte region [0x604000000310,0x604000000340)\n freed by thread T7 here:\n     #0 in __interceptor_free\n     #1 in metadata_bucket_destroy\n     #2 in consumer_stream_free\n     #3 in consumer_stream_destroy\n     #4 in clean_channel_stream_list\n     #5 in consumer_del_channel\n     #6 in consumer_stream_destroy\n     #7 in setup_metadata\n     #8 in lttng_ustconsumer_recv_cmd\n     #9 in lttng_consumer_recv_cmd\n     #10 in consumer_thread_sessiond_poll\n     #11 in start_thread nptl/pthread_create.c:481\n\n previously allocated by thread T7 here:\n     #0 in __interceptor_calloc\n     #1 in zmalloc\n     #2 in metadata_bucket_create\n     #3 in consumer_stream_enable_metadata_bucketization\n     #4 in lttng_ustconsumer_set_stream_ops\n     #5 in lttng_ustconsumer_on_recv_stream\n     #6 in lttng_consumer_on_recv_stream\n     #7 in create_ust_streams\n     #8 in ask_channel\n     #9 in lttng_ustconsumer_recv_cmd\n     #10 in lttng_consumer_recv_cmd\n     #11 in consumer_thread_sessiond_poll\n     #12 in start_thread nptl/pthread_create.c:481\n\n Thread T7 created by T0 here:\n     #0 in __interceptor_pthread_create\n     #1 in main\n     #2 in __libc_start_main ../csu/libc-start.c:332\n\n SUMMARY: AddressSanitizer: heap-use-after-free in metadata_bucket_destroy\n\nThis can be easily reproduced by forcing a failure during the setup\nof the metadata\n\ndiff --git a/src/common/ust-consumer/ust-consumer.c b/src/common/ust-consumer/ust-consumer.c\nindex fa1c71299..97ed59632 100644\n\nChange-Id: I5e5ebe3394bdd770aad96ed3c11c3c866ba659ad\n--- a/src/common/ust-consumer/ust-consumer.c\n+++ b/src/common/ust-consumer/ust-consumer.c\n@@ -908,8 +908,7 @@ static int setup_metadata(struct lttng_consumer_local_data *ctx, uint64_t key)\n\n         /* Send metadata stream to relayd if needed. */\n         if (metadata-\u003emetadata_stream-\u003enet_seq_idx !\u003d (uint64_t) -1ULL) {\n-                ret \u003d consumer_send_relayd_stream(metadata-\u003emetadata_stream,\n-                                metadata-\u003epathname);\n+                ret \u003d -1;\n                 if (ret \u003c 0) {\n                         ret \u003d LTTCOMM_CONSUMERD_ERROR_METADATA;\n                         goto error;\n\nCause\n\u003d\u003d\u003d\u003d\u003d\n\nChannels have a list of streams that are being \"setup\" and are not\nyet monitored for consumption. During this setup phase, the streams are\nowned by the channel. On destruction of the channel, any stream in that\nlist will thus be cleaned-up.\n\nWhen destroying a consumer stream, a reference to its channel is \u0027put\u0027.\nThis can result in the destruction of the channel.\n\nIn the situation described above, the release of the channel\u0027s reference\nis done before the stream is removed from the channel\u0027s stream list.\nThis causes the channel\u0027s clean-up to invoke (again) the current\nstream\u0027s clean-up, resulting in the double-free of the metadata bucket.\n\nThis problem is present in a number of error paths.\n\nSolution\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nSome error paths already manually removed the consumer stream from it\u0027s\nchannel\u0027s stream list before invoking consumer_stream_destroy(). The\nvarious error paths that have to deal with this possible situation are\nchanged to simply invoke consumer_stream_destroy().\n\nconsumer_stream_destroy() is modified to always remove the stream from\nits channel\u0027s list before performing the rest of the clean-up. This\nensures that those double clean-ups can\u0027t occur.\n\nDrawbacks\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nNone.\n\nReported-by: Vincent Whitchurch \u003cvincent.whitchurch@axis.com\u003e\nSigned-off-by: Jérémie Galarneau \u003cjeremie.galarneau@efficios.com\u003e\nChange-Id: Ibeca9b675b86fc46be3f57826f7158de4da43df8\n","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d17b2b95062215cf1ab1b6c362888c44c7d701fe5"}],"resolve_conflicts_web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d17b2b95062215cf1ab1b6c362888c44c7d701fe5"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"89198370b8c55c7b40fa5a15becd3c4e757e0f21","is_merged_in_target_branch":false,"change_id":"Ia4be7969e85bd8812ae13b042e1e100812a63c1d","change_number":7492,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"5c5e3d718d8248d5e075f64c34667c4c4617ae63":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2022-03-08 20:19:28.000000000","uploader":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"ref":"refs/changes/78/7478/6","fetch":{"anonymous http":{"url":"https://review.lttng.org/lttng-tools","ref":"refs/changes/78/7478/6","commands":{"Branch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/6 \u0026\u0026 git checkout -b change-7478 FETCH_HEAD","Checkout":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.lttng.org/lttng-tools refs/changes/78/7478/6","Reset To":"git fetch https://review.lttng.org/lttng-tools refs/changes/78/7478/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"38aea171b4c78a7a905ba7b725e51c5836f3574c","subject":"Fix: ust-consumerd: leak of stream control structure","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d38aea171b4c78a7a905ba7b725e51c5836f3574c"}]}],"author":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-03 00:27:31.000000000","tz":-300},"committer":{"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","date":"2022-03-08 20:08:40.000000000","tz":-300},"subject":"Fix: consumerd: use-after-free of metadata bucket","message":"Fix: consumerd: use-after-free of metadata bucket\n\nObserved issue\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nWhen consumer_stream_destroy() is called from, for example, the error\npath in setup_metadata(), consumer_stream_free() can end up being called\ntwice on the same stream.  Since the stream-\u003emetadata_bucket is not set\nto NULL after being destroyed, it leads to a use-after-free:\n\n ERROR: AddressSanitizer: heap-use-after-free on address 0x604000000318\n READ of size 8 at 0x604000000318 thread T7\n     #0 in metadata_bucket_destroy\n     #1 in consumer_stream_free\n     #2 in consumer_stream_destroy\n     #3 in setup_metadata\n     #4 in lttng_ustconsumer_recv_cmd\n     #5 in lttng_consumer_recv_cmd\n     #6 in consumer_thread_sessiond_poll\n     #7 in start_thread nptl/pthread_create.c:481\n     #8 in clone (/lib/x86_64-linux-gnu/libc.so.6+0xfcbde)\n\n 0x604000000318 is located 8 bytes inside of 48-byte region [0x604000000310,0x604000000340)\n freed by thread T7 here:\n     #0 in __interceptor_free\n     #1 in metadata_bucket_destroy\n     #2 in consumer_stream_free\n     #3 in consumer_stream_destroy\n     #4 in clean_channel_stream_list\n     #5 in consumer_del_channel\n     #6 in consumer_stream_destroy\n     #7 in setup_metadata\n     #8 in lttng_ustconsumer_recv_cmd\n     #9 in lttng_consumer_recv_cmd\n     #10 in consumer_thread_sessiond_poll\n     #11 in start_thread nptl/pthread_create.c:481\n\n previously allocated by thread T7 here:\n     #0 in __interceptor_calloc\n     #1 in zmalloc\n     #2 in metadata_bucket_create\n     #3 in consumer_stream_enable_metadata_bucketization\n     #4 in lttng_ustconsumer_set_stream_ops\n     #5 in lttng_ustconsumer_on_recv_stream\n     #6 in lttng_consumer_on_recv_stream\n     #7 in create_ust_streams\n     #8 in ask_channel\n     #9 in lttng_ustconsumer_recv_cmd\n     #10 in lttng_consumer_recv_cmd\n     #11 in consumer_thread_sessiond_poll\n     #12 in start_thread nptl/pthread_create.c:481\n\n Thread T7 created by T0 here:\n     #0 in __interceptor_pthread_create\n     #1 in main\n     #2 in __libc_start_main ../csu/libc-start.c:332\n\n SUMMARY: AddressSanitizer: heap-use-after-free in metadata_bucket_destroy\n\nThis can be easily reproduced by forcing a failure during the setup\nof the metadata reproducible using the following change:\n\n  diff --git a/src/common/ust-consumer/ust-consumer.c b/src/common/ust-consumer/ust-consumer.c\n  index fa1c71299..97ed59632 100644\n\n  --- a/src/common/ust-consumer/ust-consumer.c\n  +++ b/src/common/ust-consumer/ust-consumer.c\n  @@ -908,8 +908,7 @@ static int setup_metadata(struct lttng_consumer_local_data *ctx, uint64_t key)\n\n           /* Send metadata stream to relayd if needed. */\n           if (metadata-\u003emetadata_stream-\u003enet_seq_idx !\u003d (uint64_t) -1ULL) {\n  -                ret \u003d consumer_send_relayd_stream(metadata-\u003emetadata_stream,\n  -                                metadata-\u003epathname);\n  +                ret \u003d -1;\n                   if (ret \u003c 0) {\n                           ret \u003d LTTCOMM_CONSUMERD_ERROR_METADATA;\n                           goto error;\n\nCause\n\u003d\u003d\u003d\u003d\u003d\n\nChannels have a list of streams that are being \"setup\" and are not\nyet monitored for consumption. During this setup phase, the streams are\nowned by the channel. On destruction of the channel, any stream in that\nlist will thus be cleaned-up.\n\nWhen destroying a consumer stream, a reference to its channel is \u0027put\u0027.\nThis can result in the destruction of the channel.\n\nIn the situation described above, the release of the channel\u0027s reference\nis done before the stream is removed from the channel\u0027s stream list.\nThis causes the channel\u0027s clean-up to invoke (again) the current\nstream\u0027s clean-up, resulting in the double-free of the metadata bucket.\n\nThis problem is present in a number of error paths.\n\nSolution\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nSome error paths already manually removed the consumer stream from it\u0027s\nchannel\u0027s stream list before invoking consumer_stream_destroy(). The\nvarious error paths that have to deal with this possible situation are\nchanged to simply invoke consumer_stream_destroy().\n\nconsumer_stream_destroy() is modified to always remove the stream from\nits channel\u0027s list before performing the rest of the clean-up. This\nensures that those double clean-ups can\u0027t occur.\n\nDrawbacks\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nNone.\n\nReported-by: Vincent Whitchurch \u003cvincent.whitchurch@axis.com\u003e\nTested-by: Vincent Whitchurch \u003cvincent.whitchurch@axis.com\u003e\nSigned-off-by: Jérémie Galarneau \u003cjeremie.galarneau@efficios.com\u003e\nChange-Id: Ibeca9b675b86fc46be3f57826f7158de4da43df8\n","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d5c5e3d718d8248d5e075f64c34667c4c4617ae63"}],"resolve_conflicts_web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dlttng-tools.git;a\u003dcommit;h\u003d5c5e3d718d8248d5e075f64c34667c4c4617ae63"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"38aea171b4c78a7a905ba7b725e51c5836f3574c","is_merged_in_target_branch":true,"change_id":"Ia4be7969e85bd8812ae13b042e1e100812a63c1d","change_number":7492,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}