)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"1ce5806d581f670ea99944fdb8351ca5977b1932","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"For sessions *not* in tracefile rotation mode, this function erroneously"},{"line_number":23,"context_line":"resets the index_sent_seqcount to 0, thus causing already sent trace"},{"line_number":24,"context_line":"packets to be re-emitted."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Solve this by using the maximum between the current index_sent_seqcount"},{"line_number":27,"context_line":"and the tracefile array tail position."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4c98b1c3_f1e5e30e","line":24,"updated":"2021-11-17 20:12:46.000000000","message":"I\u0027m trying to re-construct the sequence of events that lead here.\n\nviewer_stream_rotate_to_trace_chunk() causes the stream to rotate to another trace chunk (or null), calls viewer_stream_sync_tracefile_array_tail(), and closes the stream\u0027s files.\n\nFrom there, how are the files of the previous trace chunk re-used?\n\nI assume that viewer_get_next_index() gets invoked for this vstream later on and that the vstream\u0027s files are closed, hitting the condition on line 1710, and opening the next chunk\u0027s files based on a copy of the viewer session\u0027s current trace chunk. So what leads to the old files being used?","commit_id":"084730b3910996b2d94450978d88be9b9e09ed4f"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a9158081b1cc014df5c50033c32c0da71cc716ee","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"For sessions *not* in tracefile rotation mode, this function erroneously"},{"line_number":23,"context_line":"resets the index_sent_seqcount to 0, thus causing already sent trace"},{"line_number":24,"context_line":"packets to be re-emitted."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Solve this by using the maximum between the current index_sent_seqcount"},{"line_number":27,"context_line":"and the tracefile array tail position."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ee108826_d55c41ad","line":24,"in_reply_to":"4c98b1c3_f1e5e30e","updated":"2021-11-17 21:27:23.000000000","message":"On session destroy:\n\n1) Relay stream A is rotated to NULL.\n\n2) viewer_get_next_index for viewer stream A:\n2.1) observes a NULL rstream-\u003etrace_chunk, updates the viewer session current trace chunk to NULL (viewer_session_set_trace_chunk_copy).\n2.2) \"Transition the viewer stream into the latest trace chunk available.\" does not issue viewer_stream_rotate_to_trace_chunk, because the condition \n(rstream-\u003ecompleted_rotation_count \u003d\u003d vstream-\u003elast_seen_rotation_count + 1 \u0026\u0026 !rstream-\u003etrace_chunk) evaluates to \"true\", and thus the entire if () evaluates to false.\n\n3) check_index_status detects rstream-\u003eclosed and index_received_seqcount \u003d\u003d index_sent_seqcount, thus replying HUP to viewer, effectively releasing ownership of the viewer stream.\n\n4) viewer_get_next_index for viewer stream B (not rotated to NULL yet):\n4.1) observes a non-NULL rstream-\u003etrace_chunk, updates the viewer session current trace chunk to *a new copy* of the non-NULL rstream-\u003etrace_chunk (viewer_session_set_trace_chunk_copy).\n4.2) the comparison (conn-\u003eviewer_session-\u003ecurrent_trace_chunk !\u003d vstream-\u003estream_file.trace_chunk) done by pointer don\u0027t match, because the viewer session current trace chunk is a new copy.\n4.3) viewer_stream_rotate_to_trace_chunk() is invoked, thus resetting the index_sent_seqcount to 0.\n4.4) check_index_status() incorrectly assumes it still has data to send. This will cause the data to be re-emitted.","commit_id":"084730b3910996b2d94450978d88be9b9e09ed4f"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"cd351a63f5bc00ef0211ed82ef91a707cc0e869a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"For sessions *not* in tracefile rotation mode, this function erroneously"},{"line_number":23,"context_line":"resets the index_sent_seqcount to 0, thus causing already sent trace"},{"line_number":24,"context_line":"packets to be re-emitted."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Solve this by using the maximum between the current index_sent_seqcount"},{"line_number":27,"context_line":"and the tracefile array tail position."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f1710640_4633ed46","line":24,"in_reply_to":"ee108826_d55c41ad","updated":"2021-12-08 19:34:21.000000000","message":"Done","commit_id":"084730b3910996b2d94450978d88be9b9e09ed4f"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"01974a27dab241fa1927bee987df06e9d1fac7ac","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  put-port-count\u003d0"},{"line_number":46,"context_line":"  10-28 22:07:37.938 764967 764967 E CLI cmd_run@babeltrace2.c:2547 Graph failed to complete successfully"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  ERROR:    [Babeltrace CLI] (babeltrace2.c:2547)"},{"line_number":49,"context_line":"    Graph failed to complete successfully"},{"line_number":50,"context_line":"  CAUSED BY [libbabeltrace2] (graph.c:469)"},{"line_number":51,"context_line":"    Component\u0027s \"consume\" method failed: status\u003dERROR, comp-addr\u003d0x55fe45d49550,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"938c79fe_124f67f7","line":48,"updated":"2021-11-19 21:49:07.000000000","message":"Please remove this error cause stack. I don\u0027t think it brings anything useful in this case.","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ab79b284f6ab2f4b2aca2fb8cd7a8f68e6feed40","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  put-port-count\u003d0"},{"line_number":46,"context_line":"  10-28 22:07:37.938 764967 764967 E CLI cmd_run@babeltrace2.c:2547 Graph failed to complete successfully"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  ERROR:    [Babeltrace CLI] (babeltrace2.c:2547)"},{"line_number":49,"context_line":"    Graph failed to complete successfully"},{"line_number":50,"context_line":"  CAUSED BY [libbabeltrace2] (graph.c:469)"},{"line_number":51,"context_line":"    Component\u0027s \"consume\" method failed: status\u003dERROR, comp-addr\u003d0x55fe45d49550,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c291433e_5972d4a1","line":48,"in_reply_to":"938c79fe_124f67f7","updated":"2021-12-01 16:50:23.000000000","message":"Done","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"01974a27dab241fa1927bee987df06e9d1fac7ac","unresolved":true,"context_lines":[{"line_number":105,"context_line":"passed that oldest available seqcount position, thus eventually"},{"line_number":106,"context_line":"re-emitting trace data."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"For sessions *not* in tracefile rotation mode, this function erroneously"},{"line_number":109,"context_line":"resets the index_sent_seqcount to 0, thus also causing trace data to be"},{"line_number":110,"context_line":"re-emitted."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"cc046cfd_a0987b53","line":108,"range":{"start_line":108,"start_character":4,"end_line":108,"end_character":46},"updated":"2021-11-19 21:49:07.000000000","message":"Please mention that we know that it\u0027s not in tracefile rotation mode because `tracefile_array_get_seq_tail()` returned -1ULL.","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ab79b284f6ab2f4b2aca2fb8cd7a8f68e6feed40","unresolved":false,"context_lines":[{"line_number":105,"context_line":"passed that oldest available seqcount position, thus eventually"},{"line_number":106,"context_line":"re-emitting trace data."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"For sessions *not* in tracefile rotation mode, this function erroneously"},{"line_number":109,"context_line":"resets the index_sent_seqcount to 0, thus also causing trace data to be"},{"line_number":110,"context_line":"re-emitted."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f6f6d37_6db843e9","line":108,"range":{"start_line":108,"start_character":4,"end_line":108,"end_character":46},"in_reply_to":"cc046cfd_a0987b53","updated":"2021-12-01 16:50:23.000000000","message":"Done","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"01974a27dab241fa1927bee987df06e9d1fac7ac","unresolved":true,"context_lines":[{"line_number":109,"context_line":"resets the index_sent_seqcount to 0, thus also causing trace data to be"},{"line_number":110,"context_line":"re-emitted."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This issue is also observed without using the clear command, simply on"},{"line_number":113,"context_line":"destroy with a live viewer attached. This is caused by another issue"},{"line_number":114,"context_line":"(not addressed by this patch) which causes"},{"line_number":115,"context_line":"viewer_stream_rotate_to_trace_chunk to be sometimes invoked when streams"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"89b2dd11_cd7cf463","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":10},"updated":"2021-11-19 21:49:07.000000000","message":"s/issue/symptom/","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ab79b284f6ab2f4b2aca2fb8cd7a8f68e6feed40","unresolved":false,"context_lines":[{"line_number":109,"context_line":"resets the index_sent_seqcount to 0, thus also causing trace data to be"},{"line_number":110,"context_line":"re-emitted."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This issue is also observed without using the clear command, simply on"},{"line_number":113,"context_line":"destroy with a live viewer attached. This is caused by another issue"},{"line_number":114,"context_line":"(not addressed by this patch) which causes"},{"line_number":115,"context_line":"viewer_stream_rotate_to_trace_chunk to be sometimes invoked when streams"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c9cca163_941b1d28","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":10},"in_reply_to":"89b2dd11_cd7cf463","updated":"2021-12-01 16:50:23.000000000","message":"Done","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"01974a27dab241fa1927bee987df06e9d1fac7ac","unresolved":true,"context_lines":[{"line_number":108,"context_line":"For sessions *not* in tracefile rotation mode, this function erroneously"},{"line_number":109,"context_line":"resets the index_sent_seqcount to 0, thus also causing trace data to be"},{"line_number":110,"context_line":"re-emitted."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This issue is also observed without using the clear command, simply on"},{"line_number":113,"context_line":"destroy with a live viewer attached. This is caused by another issue"},{"line_number":114,"context_line":"(not addressed by this patch) which causes"},{"line_number":115,"context_line":"viewer_stream_rotate_to_trace_chunk to be sometimes invoked when streams"},{"line_number":116,"context_line":"are closed on destroy:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  1) Relay stream A is rotated to NULL."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b968033f_b018aca9","line":116,"range":{"start_line":111,"start_character":0,"end_line":116,"end_character":22},"updated":"2021-11-19 21:49:07.000000000","message":"This part can be moved to a \"Notes\" section below.","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ab79b284f6ab2f4b2aca2fb8cd7a8f68e6feed40","unresolved":false,"context_lines":[{"line_number":108,"context_line":"For sessions *not* in tracefile rotation mode, this function erroneously"},{"line_number":109,"context_line":"resets the index_sent_seqcount to 0, thus also causing trace data to be"},{"line_number":110,"context_line":"re-emitted."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This issue is also observed without using the clear command, simply on"},{"line_number":113,"context_line":"destroy with a live viewer attached. This is caused by another issue"},{"line_number":114,"context_line":"(not addressed by this patch) which causes"},{"line_number":115,"context_line":"viewer_stream_rotate_to_trace_chunk to be sometimes invoked when streams"},{"line_number":116,"context_line":"are closed on destroy:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  1) Relay stream A is rotated to NULL."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c3db2995_fc195e9e","line":116,"range":{"start_line":111,"start_character":0,"end_line":116,"end_character":22},"in_reply_to":"b968033f_b018aca9","updated":"2021-12-01 16:50:23.000000000","message":"Done","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"01974a27dab241fa1927bee987df06e9d1fac7ac","unresolved":true,"context_lines":[{"line_number":115,"context_line":"viewer_stream_rotate_to_trace_chunk to be sometimes invoked when streams"},{"line_number":116,"context_line":"are closed on destroy:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  1) Relay stream A is rotated to NULL."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  2) viewer_get_next_index for viewer stream A:"},{"line_number":121,"context_line":"  2.1) observes a NULL rstream-\u003etrace_chunk, updates the viewer session"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bec42ecc_a8333955","line":118,"updated":"2021-11-19 21:49:07.000000000","message":"This scenario is explained in the next commit in the change. No need to have it here too.","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3fe150f5cfe7f282ec864ff7cd7dd68db705f0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"viewer_stream_rotate_to_trace_chunk to be sometimes invoked when streams"},{"line_number":116,"context_line":"are closed on destroy:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  1) Relay stream A is rotated to NULL."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  2) viewer_get_next_index for viewer stream A:"},{"line_number":121,"context_line":"  2.1) observes a NULL rstream-\u003etrace_chunk, updates the viewer session"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"284851a6_285bc0c4","line":118,"in_reply_to":"bec42ecc_a8333955","updated":"2021-12-01 16:50:32.000000000","message":"Done","commit_id":"9a65b8c386e02c95b0146e2c1ab2e88958bc1099"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"47998e411037f514680c47725f02ffe500bfe8fc","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  put-port-count\u003d0"},{"line_number":46,"context_line":"  10-28 22:07:37.938 764967 764967 E CLI cmd_run@babeltrace2.c:2547 Graph failed to complete successfully"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  not ok 434 - Babeltrace succeeds"},{"line_number":49,"context_line":"  #   Failed test \u0027Babeltrace succeeds\u0027"},{"line_number":50,"context_line":"  #   in /root/virtenv/src/lttng-tools/tests/regression/tools/clear/test_ust:test_ust_basic_streaming_live_viewer() at line 283."},{"line_number":51,"context_line":"  ok 435 - Wait for viewer to exit"},{"line_number":52,"context_line":"  # Test ust streaming live clear with viewer"},{"line_number":53,"context_line":"  # Parameters: tracing_active\u003d0, clear_twice\u003d0, buffer_type\u003duid"},{"line_number":54,"context_line":"  ok 436 - Create session e5l6WOcyn5gMxrJf with uri:net://localhost and opts: --live"},{"line_number":55,"context_line":"  ok 437 - Enable channel chan for session e5l6WOcyn5gMxrJf"},{"line_number":56,"context_line":"  ok 438 - Enable ust event tp:tptest for session e5l6WOcyn5gMxrJf"},{"line_number":57,"context_line":"  ok 439 - Start tracing for session e5l6WOcyn5gMxrJf"},{"line_number":58,"context_line":"  # Waiting for live trace at url: net://localhost"},{"line_number":59,"context_line":"  ok 440 - Waiting for live trace at url: net://localhost"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"cf6fcd7a_0f250279","line":57,"range":{"start_line":48,"start_character":0,"end_line":57,"end_character":53},"updated":"2021-12-02 20:22:58.000000000","message":"This could be removed as well.","commit_id":"46ef0bd1a0d107763ca7be0dc4bb76440b7c612d"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"009efd885c0ad0b5d47e8829b475684f42707e9e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  put-port-count\u003d0"},{"line_number":46,"context_line":"  10-28 22:07:37.938 764967 764967 E CLI cmd_run@babeltrace2.c:2547 Graph failed to complete successfully"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  not ok 434 - Babeltrace succeeds"},{"line_number":49,"context_line":"  #   Failed test \u0027Babeltrace succeeds\u0027"},{"line_number":50,"context_line":"  #   in /root/virtenv/src/lttng-tools/tests/regression/tools/clear/test_ust:test_ust_basic_streaming_live_viewer() at line 283."},{"line_number":51,"context_line":"  ok 435 - Wait for viewer to exit"},{"line_number":52,"context_line":"  # Test ust streaming live clear with viewer"},{"line_number":53,"context_line":"  # Parameters: tracing_active\u003d0, clear_twice\u003d0, buffer_type\u003duid"},{"line_number":54,"context_line":"  ok 436 - Create session e5l6WOcyn5gMxrJf with uri:net://localhost and opts: --live"},{"line_number":55,"context_line":"  ok 437 - Enable channel chan for session e5l6WOcyn5gMxrJf"},{"line_number":56,"context_line":"  ok 438 - Enable ust event tp:tptest for session e5l6WOcyn5gMxrJf"},{"line_number":57,"context_line":"  ok 439 - Start tracing for session e5l6WOcyn5gMxrJf"},{"line_number":58,"context_line":"  # Waiting for live trace at url: net://localhost"},{"line_number":59,"context_line":"  ok 440 - Waiting for live trace at url: net://localhost"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"21e85f27_72c9b7fe","line":57,"range":{"start_line":48,"start_character":0,"end_line":57,"end_character":53},"in_reply_to":"cf6fcd7a_0f250279","updated":"2021-12-07 18:30:36.000000000","message":"Done","commit_id":"46ef0bd1a0d107763ca7be0dc4bb76440b7c612d"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"1076b93760d2bab2d6cdd3e1bc090db2911cb5f4","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  ok 437 - Enable channel chan for session e5l6WOcyn5gMxrJf"},{"line_number":56,"context_line":"  ok 438 - Enable ust event tp:tptest for session e5l6WOcyn5gMxrJf"},{"line_number":57,"context_line":"  ok 439 - Start tracing for session e5l6WOcyn5gMxrJf"},{"line_number":58,"context_line":"  # Waiting for live trace at url: net://localhost"},{"line_number":59,"context_line":"  ok 440 - Waiting for live trace at url: net://localhost"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Cause"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"87d638b4_c7164262","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":57},"updated":"2021-12-07 14:30:27.000000000","message":"This could be removed as well.","commit_id":"46ef0bd1a0d107763ca7be0dc4bb76440b7c612d"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"009efd885c0ad0b5d47e8829b475684f42707e9e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  ok 437 - Enable channel chan for session e5l6WOcyn5gMxrJf"},{"line_number":56,"context_line":"  ok 438 - Enable ust event tp:tptest for session e5l6WOcyn5gMxrJf"},{"line_number":57,"context_line":"  ok 439 - Start tracing for session e5l6WOcyn5gMxrJf"},{"line_number":58,"context_line":"  # Waiting for live trace at url: net://localhost"},{"line_number":59,"context_line":"  ok 440 - Waiting for live trace at url: net://localhost"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Cause"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"14eed818_0edf2ca8","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":57},"in_reply_to":"87d638b4_c7164262","updated":"2021-12-07 18:30:36.000000000","message":"Done","commit_id":"46ef0bd1a0d107763ca7be0dc4bb76440b7c612d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"Jonathan Rajotte Julien","email":"jonathan.rajotte-julien@efficios.com","username":"PSRCode","avatars":[{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"45632388e84c1910153dc8f41f2edabdb1faf62b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eed061ca_3c2f88d5","updated":"2021-11-17 14:34:16.000000000","message":"We are gonna need a lot more context here to understand the rational of this change please use the template in contributing.md. ","commit_id":"3b24c8d6aa24e357eafc61102157fd28264ac2e6"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a9158081b1cc014df5c50033c32c0da71cc716ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"552aa1d0_bfa23ccf","in_reply_to":"a8d95e60_1b1e4a46","updated":"2021-11-17 21:27:23.000000000","message":"Done","commit_id":"3b24c8d6aa24e357eafc61102157fd28264ac2e6"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c8125dcd6d68f9eaab841846a6e2e428d1fb5519","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8d95e60_1b1e4a46","in_reply_to":"eed061ca_3c2f88d5","updated":"2021-11-17 19:16:20.000000000","message":"Not resolved.","commit_id":"3b24c8d6aa24e357eafc61102157fd28264ac2e6"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c0e85bf0b4b32cc544e03e2f56f5a634dcaad864","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e4d29a2_884a9c33","updated":"2021-11-17 20:14:05.000000000","message":"As mentionned by Jonathan, please use the \u0027Fix\u0027 commit message template as this issue is not obvious.","commit_id":"084730b3910996b2d94450978d88be9b9e09ed4f"}],"src/bin/lttng-relayd/viewer-stream.c":[{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"1ce5806d581f670ea99944fdb8351ca5977b1932","unresolved":true,"context_lines":[{"line_number":302,"context_line":"\tif (seq_tail \u003d\u003d -1ULL) {"},{"line_number":303,"context_line":"\t\tseq_tail \u003d 0;"},{"line_number":304,"context_line":"\t}"},{"line_number":305,"context_line":"\tvstream-\u003eindex_sent_seqcount \u003d max_t(uint64_t, seq_tail, vstream-\u003eindex_sent_seqcount);"},{"line_number":306,"context_line":"}"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"/*"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a0254e22_32856018","line":305,"updated":"2021-11-17 20:12:46.000000000","message":"Add a comment describing why this \u0027max\u0027 is performed.","commit_id":"084730b3910996b2d94450978d88be9b9e09ed4f"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"01974a27dab241fa1927bee987df06e9d1fac7ac","unresolved":false,"context_lines":[{"line_number":302,"context_line":"\tif (seq_tail \u003d\u003d -1ULL) {"},{"line_number":303,"context_line":"\t\tseq_tail \u003d 0;"},{"line_number":304,"context_line":"\t}"},{"line_number":305,"context_line":"\tvstream-\u003eindex_sent_seqcount \u003d max_t(uint64_t, seq_tail, vstream-\u003eindex_sent_seqcount);"},{"line_number":306,"context_line":"}"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"/*"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"3c33d94f_56aadf7c","line":305,"in_reply_to":"a0254e22_32856018","updated":"2021-11-19 21:49:07.000000000","message":"Done","commit_id":"084730b3910996b2d94450978d88be9b9e09ed4f"}]}