)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"79711d5da02a7df06b4434d8bc9fe6bcde245cdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5447e6c0_a1b28a62","updated":"2025-08-20 18:17:24.000000000","message":"Looks okay to me.","commit_id":"adafa15a0ea145e1e98f68e2a56512e83f1f6798"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"206ffcf6c2681fdb916fbb3642e43a76f0489b90","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"841b483e_7362212e","in_reply_to":"5447e6c0_a1b28a62","updated":"2025-08-21 14:50:47.000000000","message":"I\u0027m assuming distros will flag this as an ABI break. Should we provide stubs in liblttng-ctl?","commit_id":"adafa15a0ea145e1e98f68e2a56512e83f1f6798"},{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7ee940205bf508fbdaf16bb0d1bd4af6f57d09f4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0c4cfed_6a03b879","in_reply_to":"841b483e_7362212e","updated":"2025-09-03 19:26:06.000000000","message":"I don\u0027t think that it will be flagged as an ABI break.\n\nThe state as it is now is that the .sym file includes those names, but they are not extern symbols in the actual shared object (as @raj.khem@gmail.com pointed out, liblttng-ctl isn\u0027t linked with libcommon-gpl).\n\nOn master:\n\n```\n$ nm src/lib/lttng-ctl/.libs/liblttng-ctl.so | grep alloc\n0000000000055015 T lttng_channel_get_allocation_policy\n000000000005505e T lttng_channel_set_allocation_policy\n00000000000d7c0a T lttng_yyalloc\n00000000000d7d31 T lttng_yyrealloc\n```\n\nI _think_ this is `ld.lld` being more strict than GNU `ld`, but a brief check of the respective man pages don\u0027t document this behavioural difference.","commit_id":"adafa15a0ea145e1e98f68e2a56512e83f1f6798"}]}
