)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"305f45c48ee08066cad5e71427643f034fc38edf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d7389477_113a4f9b","updated":"2025-06-17 20:09:27.000000000","message":"I don\u0027t mind if we print additionnal info telling the user they can disable the tests if they don\u0027t have/want to install babeltrace2 but I wan\u0027t the default behavior to be a configure failure.","commit_id":"a7f3580d0627799672fba8a136938fccb7628b3a"},{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"1083200a98a94893ed2cce869d51715edbcf7ba8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44c4e1bc_f3ef43ec","in_reply_to":"d7389477_113a4f9b","updated":"2025-06-18 13:47:41.000000000","message":"That seems reasonable. I\u0027ve re-worked the patch so that a user may specify `--without-tests` to disable the tests.","commit_id":"a7f3580d0627799672fba8a136938fccb7628b3a"}],"configure.ac":[{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ae842b4b63ccc83a90e4ca22cd77b96b386de275","unresolved":true,"context_lines":[{"line_number":1159,"context_line":"])"},{"line_number":1160,"context_line":"AM_CONDITIONAL([HAVE_MODULES_USERSPACE_CALLSTACK_CONTEXT], [test x$have_modules_userspace_callstack_context \u003d xyes])"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"AC_ARG_WITH([tests],"},{"line_number":1163,"context_line":"  [AS_HELP_STRING([--with-tests], [Build tests. [default\u003dyes]])],"},{"line_number":1164,"context_line":"  [],"},{"line_number":1165,"context_line":"  [with_tests\u003dyes]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"a5aade36_3ae7d56f","line":1162,"updated":"2025-06-18 14:14:36.000000000","message":"Is there a specific reason to use AC_ARG_WITH instead of AC_ARG_ENABLE?","commit_id":"255fd9d428296ba73cb2a7f8998d33e952928432"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"2fec3e06d05aa55f6f777b23c27c29da0478996c","unresolved":true,"context_lines":[{"line_number":1159,"context_line":"])"},{"line_number":1160,"context_line":"AM_CONDITIONAL([HAVE_MODULES_USERSPACE_CALLSTACK_CONTEXT], [test x$have_modules_userspace_callstack_context \u003d xyes])"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"AC_ARG_WITH([tests],"},{"line_number":1163,"context_line":"  [AS_HELP_STRING([--with-tests], [Build tests. [default\u003dyes]])],"},{"line_number":1164,"context_line":"  [],"},{"line_number":1165,"context_line":"  [with_tests\u003dyes]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"e43447a2_101be2b4","line":1162,"in_reply_to":"1c7985a2_71a17e93","updated":"2025-06-18 14:47:19.000000000","message":"For reference:\n\nhttps://www.gnu.org/software/autoconf/manual/autoconf-2.72/html_node/Package-Options.html\n\nhttps://www.gnu.org/software/autoconf/manual/autoconf-2.72/html_node/External-Software.html","commit_id":"255fd9d428296ba73cb2a7f8998d33e952928432"},{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"d12f81ef37c06bda2079ac63363bb549e723624d","unresolved":true,"context_lines":[{"line_number":1159,"context_line":"])"},{"line_number":1160,"context_line":"AM_CONDITIONAL([HAVE_MODULES_USERSPACE_CALLSTACK_CONTEXT], [test x$have_modules_userspace_callstack_context \u003d xyes])"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"AC_ARG_WITH([tests],"},{"line_number":1163,"context_line":"  [AS_HELP_STRING([--with-tests], [Build tests. [default\u003dyes]])],"},{"line_number":1164,"context_line":"  [],"},{"line_number":1165,"context_line":"  [with_tests\u003dyes]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"eabe359e_35fd8922","line":1162,"in_reply_to":"a5aade36_3ae7d56f","updated":"2025-06-18 14:42:19.000000000","message":"Nope. Is AC_ARG_ENABLE more appropriate?","commit_id":"255fd9d428296ba73cb2a7f8998d33e952928432"},{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"2f77301f8d45d7776800272bd7d1f5172fdeb006","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"])"},{"line_number":1160,"context_line":"AM_CONDITIONAL([HAVE_MODULES_USERSPACE_CALLSTACK_CONTEXT], [test x$have_modules_userspace_callstack_context \u003d xyes])"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"AC_ARG_WITH([tests],"},{"line_number":1163,"context_line":"  [AS_HELP_STRING([--with-tests], [Build tests. [default\u003dyes]])],"},{"line_number":1164,"context_line":"  [],"},{"line_number":1165,"context_line":"  [with_tests\u003dyes]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5f8720c7_4a49b39c","line":1162,"in_reply_to":"e43447a2_101be2b4","updated":"2025-06-18 18:08:12.000000000","message":"ok, thanks!","commit_id":"255fd9d428296ba73cb2a7f8998d33e952928432"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8db778a2b53bfdc68d0baf371ba4242b40115691","unresolved":true,"context_lines":[{"line_number":1159,"context_line":"])"},{"line_number":1160,"context_line":"AM_CONDITIONAL([HAVE_MODULES_USERSPACE_CALLSTACK_CONTEXT], [test x$have_modules_userspace_callstack_context \u003d xyes])"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"AC_ARG_WITH([tests],"},{"line_number":1163,"context_line":"  [AS_HELP_STRING([--with-tests], [Build tests. [default\u003dyes]])],"},{"line_number":1164,"context_line":"  [],"},{"line_number":1165,"context_line":"  [with_tests\u003dyes]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1c7985a2_71a17e93","line":1162,"in_reply_to":"eabe359e_35fd8922","updated":"2025-06-18 14:45:44.000000000","message":"They are functionnaly the same except for \u0027--with-\u0027 / \u0027--enable-\u0027. By autotools convention AC_ARG_WITH is supposed to be used for optionnal dependencies and AC_ARG_ENABLE to toggle features of the build or software.","commit_id":"255fd9d428296ba73cb2a7f8998d33e952928432"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ae842b4b63ccc83a90e4ca22cd77b96b386de275","unresolved":true,"context_lines":[{"line_number":1188,"context_line":"AS_IF([test \"x$build_tests\" \u003d \"xyes\"],"},{"line_number":1189,"context_line":"  ["},{"line_number":1190,"context_line":"    PKG_CHECK_MODULES([babeltrace2],[babeltrace2],,["},{"line_number":1191,"context_line":"    AC_MSG_ERROR([libbabeltrace2 is required to build tests])"},{"line_number":1192,"context_line":"    ])"},{"line_number":1193,"context_line":"  ]"},{"line_number":1194,"context_line":")"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1e99ee09_f0d3406e","line":1191,"range":{"start_line":1191,"start_character":54,"end_line":1191,"end_character":59},"updated":"2025-06-18 14:14:36.000000000","message":"\"the tests\" ?","commit_id":"255fd9d428296ba73cb2a7f8998d33e952928432"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"b214e2ab5bbcb16e19372ac29b197f1478fdb97a","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"AS_IF([test \"x$build_tests\" \u003d \"xyes\"],"},{"line_number":1189,"context_line":"  ["},{"line_number":1190,"context_line":"    PKG_CHECK_MODULES([babeltrace2],[babeltrace2],,["},{"line_number":1191,"context_line":"    AC_MSG_ERROR([libbabeltrace2 is required to build tests])"},{"line_number":1192,"context_line":"    ])"},{"line_number":1193,"context_line":"  ]"},{"line_number":1194,"context_line":")"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bdd722fb_ae893374","line":1191,"range":{"start_line":1191,"start_character":54,"end_line":1191,"end_character":59},"in_reply_to":"1e99ee09_f0d3406e","updated":"2025-06-20 14:59:38.000000000","message":"Done","commit_id":"255fd9d428296ba73cb2a7f8998d33e952928432"}]}