)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8571e05d0724bb00ca2c586105bec155fc9e7a89","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  not ok 2 - Create session rotation_destroy_flush in -o /tmp/tmp.test_rot ..."},{"line_number":16,"context_line":"  ..."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This because when the kernel module fails to load, test script would export"},{"line_number":19,"context_line":"the LTTNG_ABORT_ON_ERROR\u003d1 that cause session daemon trap into abort."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Using \"check_skip_kernel_test\" to detect whether the kernel module fails to load"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"157746dc_5ab7bdf9","line":18,"updated":"2024-03-27 13:08:31.000000000","message":"Could you improve the wording here? The current reading says that the sessiond\u0027s kernel module loading impacts the behaviour of the test script with regards to if it exports `LTTNG_ABORT_ON_ERROR` or not.\n\nHowever, it\u0027s really that the test script that sets the `LTTNG_ABORT_ON_ERROR` environment variable. It\u0027s this environment variable that causes the sessiond to handle the kernel module loading failure as an abort rather than a warning.","commit_id":"3d3ce38223aa7b1705214e66f3f43f1266924e6c"},{"author":{"_account_id":1000057,"name":"Chen","email":"xiangyu.chen@windriver.com","username":"chenxy1988","avatars":[{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4e9279ee2a64b47306e48ec9390e41e7be035cd2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  not ok 2 - Create session rotation_destroy_flush in -o /tmp/tmp.test_rot ..."},{"line_number":16,"context_line":"  ..."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This because when the kernel module fails to load, test script would export"},{"line_number":19,"context_line":"the LTTNG_ABORT_ON_ERROR\u003d1 that cause session daemon trap into abort."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Using \"check_skip_kernel_test\" to detect whether the kernel module fails to load"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c0e53273_7412ab96","line":18,"in_reply_to":"157746dc_5ab7bdf9","updated":"2024-03-28 01:34:03.000000000","message":"Thanks for your suggestion, my understand was wrong, it is clear to me now. I have uploaded a v3 patch to change the commit message.","commit_id":"3d3ce38223aa7b1705214e66f3f43f1266924e6c"},{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8571e05d0724bb00ca2c586105bec155fc9e7a89","unresolved":true,"context_lines":[{"line_number":19,"context_line":"the LTTNG_ABORT_ON_ERROR\u003d1 that cause session daemon trap into abort."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Using \"check_skip_kernel_test\" to detect whether the kernel module fails to load"},{"line_number":22,"context_line":"is a expected or not."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Fixes: 3a174400"},{"line_number":25,"context_line":"(\"tests:add check_skip_kernel_test to check root user and lttng kernel modules\")"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"10afaf16_50caecb9","line":22,"updated":"2024-03-27 13:08:31.000000000","message":"`is expected or not` instead of `is a expected or not`","commit_id":"3d3ce38223aa7b1705214e66f3f43f1266924e6c"},{"author":{"_account_id":1000057,"name":"Chen","email":"xiangyu.chen@windriver.com","username":"chenxy1988","avatars":[{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4e9279ee2a64b47306e48ec9390e41e7be035cd2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the LTTNG_ABORT_ON_ERROR\u003d1 that cause session daemon trap into abort."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Using \"check_skip_kernel_test\" to detect whether the kernel module fails to load"},{"line_number":22,"context_line":"is a expected or not."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Fixes: 3a174400"},{"line_number":25,"context_line":"(\"tests:add check_skip_kernel_test to check root user and lttng kernel modules\")"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9c2049ef_8e013767","line":22,"in_reply_to":"10afaf16_50caecb9","updated":"2024-03-28 01:34:03.000000000","message":"changed in v3 patch, thanks.","commit_id":"3d3ce38223aa7b1705214e66f3f43f1266924e6c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"737a3c44de6a81b4d826d436dc4f86e1d2af3ae3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5d80f08_1143d440","updated":"2024-03-26 12:17:12.000000000","message":"Comment removed by: Kienan Stewart; Reason: error\n","commit_id":"bb3411d7ef258bb929690e076a99b5a27e6e0e26"},{"author":{"_account_id":1000057,"name":"Chen","email":"xiangyu.chen@windriver.com","username":"chenxy1988","avatars":[{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5f68df9a4b3a7e29a903ffef7c1471fa194d49bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e90c3756_9ea7423f","updated":"2024-03-25 09:59:57.000000000","message":"There is a small issue to fix after commit 3a174400(tests:add check_skip_kernel_test to check root user and lttng kernel modules)","commit_id":"bb3411d7ef258bb929690e076a99b5a27e6e0e26"},{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7dd08369069fc4e29cee1aad72d37f05e116bb1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61041ec9_308f5ee0","in_reply_to":"c5d80f08_1143d440","updated":"2024-03-26 12:35:29.000000000","message":"Comment removed by: Kienan Stewart; Reason: error","commit_id":"bb3411d7ef258bb929690e076a99b5a27e6e0e26"},{"author":{"_account_id":1000057,"name":"Chen","email":"xiangyu.chen@windriver.com","username":"chenxy1988","avatars":[{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"97ed84229a0d5b3578c2277f837eea129408c2c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b9d4cde_b1dc47de","in_reply_to":"e90c3756_9ea7423f","updated":"2024-03-25 10:01:41.000000000","message":"Done","commit_id":"bb3411d7ef258bb929690e076a99b5a27e6e0e26"},{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8571e05d0724bb00ca2c586105bec155fc9e7a89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82ec936b_c36bc23b","updated":"2024-03-27 13:08:31.000000000","message":"Hi Xiangyu, I have a couple small nits about wording in the commit message. Otherwise I think it looks okay to me.","commit_id":"3d3ce38223aa7b1705214e66f3f43f1266924e6c"}],"tests/regression/ust/rotation-destroy-flush/test_rotation_destroy_flush":[{"author":{"_account_id":1000042,"name":"Kienan Stewart","email":"kstewart@efficios.com","username":"kienanstewart","avatars":[{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/88ef3510ea0f73dcdf8539b2031337c4.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"737a3c44de6a81b4d826d436dc4f86e1d2af3ae3","unresolved":true,"context_lines":[{"line_number":24,"context_line":"NUM_TESTS\u003d$((15*$NR_ITER))"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Ensure the daemons invoke abort on error."},{"line_number":27,"context_line":"export LTTNG_ABORT_ON_ERROR\u003d1"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"source $TESTDIR/utils/utils.sh"},{"line_number":30,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"137b9b78_35ce29db","line":27,"updated":"2024-03-26 12:17:12.000000000","message":"Hi Xiangyu,\n\nwhen the kernel module fails to load (which is normally just a warning), this environment variable causes it to abort instead.\n\nI think it would be fine to remove this setting instead of skipping the test.\n\nIt is perfectly legitimate to run sessiond as root without the kernel module and do just user-space tracing.\n\nthanks,\nkienan","commit_id":"bb3411d7ef258bb929690e076a99b5a27e6e0e26"},{"author":{"_account_id":1000057,"name":"Chen","email":"xiangyu.chen@windriver.com","username":"chenxy1988","avatars":[{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/99d02ccc13942be7e1fa2d381b4ae530.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"40b691b5f503fc2974c27ed07130b36bfd3bd456","unresolved":false,"context_lines":[{"line_number":24,"context_line":"NUM_TESTS\u003d$((15*$NR_ITER))"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Ensure the daemons invoke abort on error."},{"line_number":27,"context_line":"export LTTNG_ABORT_ON_ERROR\u003d1"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"source $TESTDIR/utils/utils.sh"},{"line_number":30,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3c3b9e68_cf81b3e8","line":27,"in_reply_to":"137b9b78_35ce29db","updated":"2024-03-27 04:50:43.000000000","message":"Hi Kienan,\n\nThanks for your info, I didn\u0027t notice the LTTNG_ABORT_ON_ERROR value ever before that can casue session daemon abort :p\n\nSince the modules might exsits but was damage or wrong on a rootfs, I keep the LTTNG_ABORT_ON_ERROR value in patch v2 and using \"check_skip_kernel_test\" to detect whether no kernel module is our expected or not.\n\nAfter this change, I did a simple test on my yocto linux, the result is meet our expect:\n\ncase 1: export LTTNG_TOOLS_DISABLE_KERNEL_TESTS\u003d1, no lttng modules in /lib/modules\nresult is PASS\n\n```\nroot@qemux86-64:/usr/lib64/lttng-tools/ptest#  ./tests/regression/ust/rotation-destroy-flush/test_rotation_destroy_flush \n# LTTNG_TOOLS_DISABLE_KERNEL_TESTS was set. \n1..150\n# UST - Rotation destroy flush\n# Iteration 1/10\nError: Unable to load required module lttng-ring-buffer-client-discard\nWarning: No kernel tracer available\nok 1 - Start session daemon\nok 2 - Create session rotation_destroy_flush in -o /tmp/tmp.test_rotation_destroy_flush.LNz9YU\n......\nok 147 - Start tracing for session rotation_destroy_flush\nok 148 - Application done\nok 149 - Destroy session rotation_destroy_flush\n# Killing (signal SIGTERM) lttng-sessiond and lt-lttng-sessiond pids: 3365 3366 \nok 150 - Wait after kill session daemon\n\n```\n\ncase 2: no LTTNG_TOOLS_DISABLE_KERNEL_TESTS\u003d1, no lttng modules in /lib/modules\nresult is FAIL:\n```\nroot@qemux86-64:/usr/lib64/lttng-tools/ptest#  ./tests/regression/ust/rotation-destroy-flush/test_rotation_destroy_flush \n1..150\n# UST - Rotation destroy flush\n# Iteration 1/10\nError: Unable to load required module lttng-ring-buffer-client-discard\nnot ok 1 - Start session daemon\n#   Failed test \u0027Start session daemon\u0027\n#   in ./tests/regression/ust/rotation-destroy-flush//../../../utils/utils.sh:start_lttng_sessiond_opt() at line 829.\n./tests/regression/ust/rotation-destroy-flush//../../../utils/utils.sh: line 1197:  3458 Aborted                 (core dumped) $TESTDIR/../src/bin/lttng/$LTTNG_BIN create \"$sess_name\" $trace_path $opt \u003e $OUTPUT_DEST 2\u003e $ERROR_OUTPUT_DEST\n.....\n\n```\n\ncase 3: no LTTNG_TOOLS_DISABLE_KERNEL_TESTS\u003d1, lttng modules was present\nresult is PASS:\n```\nroot@qemux86-64:/usr/lib64/lttng-tools/ptest#  ./tests/regression/ust/rotation-destroy-flush/test_rotation_destroy_flush \n1..150\n# UST - Rotation destroy flush\n# Iteration 1/10\n[  775.595019] lttng_kretprobes: loading out-of-tree module taints kernel.\n[  776.372292] LTTng: Loaded modules v2.13.11 (Nordicité)\nok 1 - Start session daemon\nok 2 - Create session rotation_destroy_flush in -o /tmp/tmp.test_rotation_destroy_flush.YhwFzn\nok 3 - Enable channel testchan for session rotation_destroy_flush: 4096 bytes tracefile limit\n......\nok 148 - Application done\nok 149 - Destroy session rotation_destroy_flush\n# Killing (signal SIGTERM) lttng-sessiond and lt-lttng-sessiond pids: 2253 2254 \n[  988.693450] LTTng: Unloaded modules v2.13.11 (Nordicité)\nok 150 - Wait after kill session daemon\n\n```\n\n\nThanks,\nXiangyu","commit_id":"bb3411d7ef258bb929690e076a99b5a27e6e0e26"}]}