)]}'
{"src/lttng-statedump-impl.c":[{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"677aca32967f895506ed01c0abe21c2c65e0691f","unresolved":true,"context_lines":[{"line_number":283,"context_line":"\t\t * wrapper can fail to lookup the original symbol."},{"line_number":284,"context_line":"\t\t */"},{"line_number":285,"context_line":"\t\tif (wrapper_disk_part_iter_init(\u0026piter, disk, DISK_PITER_INCL_PART0) \u003c 0)"},{"line_number":286,"context_line":"\t\t\treturn -ENOSYS;"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"\t\twhile ((part \u003d wrapper_disk_part_iter_next(\u0026piter))) {"},{"line_number":289,"context_line":"\t\t\tchar name_buf[BDEVNAME_SIZE];"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4e6141d2_38b22e37","line":286,"updated":"2021-04-07 15:35:07.000000000","message":"I don\u0027t think we want to return early without doing the class_dev_iter_exit() here. A break or goto end (keeping track of the return value) would be better.","commit_id":"079f99a1fda0ffed9c376439e1f2aacba113db88"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f0a6a7dabeddca4bcee82f8a14feaac45bc1f514","unresolved":false,"context_lines":[{"line_number":283,"context_line":"\t\t * wrapper can fail to lookup the original symbol."},{"line_number":284,"context_line":"\t\t */"},{"line_number":285,"context_line":"\t\tif (wrapper_disk_part_iter_init(\u0026piter, disk, DISK_PITER_INCL_PART0) \u003c 0)"},{"line_number":286,"context_line":"\t\t\treturn -ENOSYS;"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"\t\twhile ((part \u003d wrapper_disk_part_iter_next(\u0026piter))) {"},{"line_number":289,"context_line":"\t\t\tchar name_buf[BDEVNAME_SIZE];"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"9367e51a_25ca935e","line":286,"in_reply_to":"4e6141d2_38b22e37","updated":"2021-04-07 15:49:35.000000000","message":"Done","commit_id":"079f99a1fda0ffed9c376439e1f2aacba113db88"}],"src/wrapper/genhd.c":[{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f57ab2cd5a3c80f0f66a825aca8309146279704c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\t\tdisk_part_iter_init_sym(piter, disk, flags);"},{"line_number":40,"context_line":"\t} else {"},{"line_number":41,"context_line":"\t\tprintk_once(KERN_WARNING \"LTTng: disk_part_iter_init symbol lookup failed.\\n\");"},{"line_number":42,"context_line":"\t\t//FIXME"},{"line_number":43,"context_line":"\t}"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":"EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_init);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5e57e562_9cee1251","line":42,"updated":"2021-04-07 13:23:00.000000000","message":"Let\u0027s change the prototypes of wrapper_disk_part_iter*() functions from returning void to returning \"int\", where 0 is success and a negative value means an error.\n\nThen the callers can test for this.","commit_id":"a35ba30e1bc23b16ee5a3881e7ea0b682a553377"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"073174318173a96409dcf7a6e30825c385ca7193","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\t\tdisk_part_iter_init_sym(piter, disk, flags);"},{"line_number":40,"context_line":"\t} else {"},{"line_number":41,"context_line":"\t\tprintk_once(KERN_WARNING \"LTTng: disk_part_iter_init symbol lookup failed.\\n\");"},{"line_number":42,"context_line":"\t\t//FIXME"},{"line_number":43,"context_line":"\t}"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":"EXPORT_SYMBOL_GPL(wrapper_disk_part_iter_init);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d3007848_65c66e45","line":42,"in_reply_to":"5e57e562_9cee1251","updated":"2021-04-07 15:30:18.000000000","message":"Done","commit_id":"a35ba30e1bc23b16ee5a3881e7ea0b682a553377"}]}