)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f132410d44b14e9c3f3ff72e40fdf0b4eb4f8d48","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Erica Bugden \u003cebugden@efficios.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-25 16:13:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: Make traces with no stream id readable by babeltrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when the barectf configuration property"},{"line_number":10,"context_line":"‘data-stream-type-id-field-type’ (stream IDs) is undefined or false,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dddb9f04_d0f1b541","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":34},"updated":"2023-04-25 20:51:59.000000000","message":"\"stream type ID\"\n\nApply elsewhere.","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Erica Bugden \u003cebugden@efficios.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-25 16:13:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix: Make traces with no stream id readable by babeltrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when the barectf configuration property"},{"line_number":10,"context_line":"‘data-stream-type-id-field-type’ (stream IDs) is undefined or false,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6c804da7_803123a8","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":34},"in_reply_to":"dddb9f04_d0f1b541","updated":"2023-04-27 15:18:10.000000000","message":"Done","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f132410d44b14e9c3f3ff72e40fdf0b4eb4f8d48","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix: Make traces with no stream id readable by babeltrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when the barectf configuration property"},{"line_number":10,"context_line":"‘data-stream-type-id-field-type’ (stream IDs) is undefined or false,"},{"line_number":11,"context_line":"barectf produces traces that babeltrace (and Trace Compass) cannot"},{"line_number":12,"context_line":"parse."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f3a22226_39227969","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":58},"updated":"2023-04-25 20:51:59.000000000","message":"Really?","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix: Make traces with no stream id readable by babeltrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when the barectf configuration property"},{"line_number":10,"context_line":"‘data-stream-type-id-field-type’ (stream IDs) is undefined or false,"},{"line_number":11,"context_line":"barectf produces traces that babeltrace (and Trace Compass) cannot"},{"line_number":12,"context_line":"parse."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f2a76959_9d2e8276","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":58},"in_reply_to":"f3a22226_39227969","updated":"2023-04-27 15:18:10.000000000","message":"Good point. No I don\u0027t think so.\n\nI originally included this because the property was not explicitly defined the barectf 2 configuration I was using, but when it\u0027s converted to a barectf 3 config it is explicitly defined as false.","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f132410d44b14e9c3f3ff72e40fdf0b4eb4f8d48","unresolved":true,"context_lines":[{"line_number":12,"context_line":"parse."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To resolve this, remove all mentions of the stream ID from the metadata"},{"line_number":15,"context_line":"file when there is no stream ID."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Apparent cause:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cfb70bf3_edfd97af","line":15,"range":{"start_line":15,"start_character":19,"end_line":15,"end_character":31},"updated":"2023-04-25 20:51:59.000000000","message":"\"no stream type ID field type feature\"","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":false,"context_lines":[{"line_number":12,"context_line":"parse."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To resolve this, remove all mentions of the stream ID from the metadata"},{"line_number":15,"context_line":"file when there is no stream ID."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Apparent cause:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d36d29f4_a206b66c","line":15,"range":{"start_line":15,"start_character":19,"end_line":15,"end_character":31},"in_reply_to":"cfb70bf3_edfd97af","updated":"2023-04-27 15:18:10.000000000","message":"Done","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f132410d44b14e9c3f3ff72e40fdf0b4eb4f8d48","unresolved":true,"context_lines":[{"line_number":23,"context_line":"actual trace data). This case falls into a grey area in the CTF 1.8"},{"line_number":24,"context_line":"specifcation (see below) and could arguably be a bug in babeltrace since"},{"line_number":25,"context_line":"all the information needed to parse the trace unambiguously is present"},{"line_number":26,"context_line":"in the metadata file. The stream ID information barectf includes is"},{"line_number":27,"context_line":"superfluous, but not contradictory of any data present in the trace."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"However, add this fix because:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ede077b9_3b513a1b","line":26,"updated":"2023-04-25 20:51:59.000000000","message":"You may add: for example, yactfr successfully reads such a data stream.","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":false,"context_lines":[{"line_number":23,"context_line":"actual trace data). This case falls into a grey area in the CTF 1.8"},{"line_number":24,"context_line":"specifcation (see below) and could arguably be a bug in babeltrace since"},{"line_number":25,"context_line":"all the information needed to parse the trace unambiguously is present"},{"line_number":26,"context_line":"in the metadata file. The stream ID information barectf includes is"},{"line_number":27,"context_line":"superfluous, but not contradictory of any data present in the trace."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"However, add this fix because:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a26b4cb8_2728a4dc","line":26,"in_reply_to":"ede077b9_3b513a1b","updated":"2023-04-27 15:18:10.000000000","message":"Done","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8b9d9b382eec3cc7e126922c74435884820c4cde","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"This metadata issue is in a grey area of the CTF specification. The"},{"line_number":38,"context_line":"specification says, “[The data stream type ID] field is optional if"},{"line_number":39,"context_line":"there is only one stream description in the metadata” and, “The stream"},{"line_number":40,"context_line":"ID can be left out if there is only one stream in the trace.” However,"},{"line_number":41,"context_line":"it does not say the data stream type ID _must_ be left out of the"},{"line_number":42,"context_line":"metadata if there is only one data stream type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3292dbb7_c2a10916","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":36},"updated":"2023-04-27 19:33:51.000000000","message":"You _could_ replace this with \"[data stream type]\" to use a single terminology here.\n\nSame thing for the following quote (and \"stream ID\" becomes \"data stream type ID\").","commit_id":"e8a54a7519fd1ec7aa5299b2cca8af270481d4a2"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"330bded2fd0e7b7c484924babeb0ac2ee7c4568c","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"This metadata issue is in a grey area of the CTF specification. The"},{"line_number":38,"context_line":"specification says, “[The data stream type ID] field is optional if"},{"line_number":39,"context_line":"there is only one stream description in the metadata” and, “The stream"},{"line_number":40,"context_line":"ID can be left out if there is only one stream in the trace.” However,"},{"line_number":41,"context_line":"it does not say the data stream type ID _must_ be left out of the"},{"line_number":42,"context_line":"metadata if there is only one data stream type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ca1985c_75a38245","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":36},"in_reply_to":"3292dbb7_c2a10916","updated":"2023-04-28 15:00:38.000000000","message":"Yes! I completely agree.","commit_id":"e8a54a7519fd1ec7aa5299b2cca8af270481d4a2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e05ffd3f4626b87673061d42e42b1c6448bb621a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88c321c8_678e9618","updated":"2023-04-25 20:30:25.000000000","message":"Hello Phil! Here\u0027s the first version of the fix for this [bug](https://github.com/efficios/barectf/issues/28). 🌈","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"}],"tests/tracing/configs/basic/ds/no-dst-id.yaml":[{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# The MIT License (MIT)"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2020 Philippe Proulx \u003cpproulx@efficios.com\u003e"},{"line_number":4,"context_line":"# Copyright (c) 2023 Erica Bugden \u003cebugden@efficios.com\u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1632a9c1_d6913d0e","line":1,"updated":"2023-04-27 15:18:10.000000000","message":"Is the folder `basic/ds` the right place for this test? I was guessing `ds` stands for data stream.","commit_id":"e8a54a7519fd1ec7aa5299b2cca8af270481d4a2"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8b9d9b382eec3cc7e126922c74435884820c4cde","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The MIT License (MIT)"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2020 Philippe Proulx \u003cpproulx@efficios.com\u003e"},{"line_number":4,"context_line":"# Copyright (c) 2023 Erica Bugden \u003cebugden@efficios.com\u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7e427c45_bedec31e","line":1,"in_reply_to":"1632a9c1_d6913d0e","updated":"2023-04-27 19:33:51.000000000","message":"Yes it\u0027s okay.","commit_id":"e8a54a7519fd1ec7aa5299b2cca8af270481d4a2"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# This makes sure that two common CTF trace readers (Babeltrace and"},{"line_number":33,"context_line":"# Trace Compass) will be able to read the traces produced."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"%YAML 1.2"},{"line_number":36,"context_line":"--- !\u003ctag:barectf.org,2020/3/config\u003e"},{"line_number":37,"context_line":"trace:"},{"line_number":38,"context_line":"  type:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"438d988e_e22b73cd","line":35,"updated":"2023-04-27 15:18:10.000000000","message":"I tried to briefly pare down the configuration file (while still triggering the same issue resolved by the same fix).\n\nDo you have suggestions for further simplifications?","commit_id":"e8a54a7519fd1ec7aa5299b2cca8af270481d4a2"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8b9d9b382eec3cc7e126922c74435884820c4cde","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# This makes sure that two common CTF trace readers (Babeltrace and"},{"line_number":33,"context_line":"# Trace Compass) will be able to read the traces produced."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"%YAML 1.2"},{"line_number":36,"context_line":"--- !\u003ctag:barectf.org,2020/3/config\u003e"},{"line_number":37,"context_line":"trace:"},{"line_number":38,"context_line":"  type:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d4a4d21f_54debdfc","line":35,"in_reply_to":"438d988e_e22b73cd","updated":"2023-04-27 19:33:51.000000000","message":"Fine as is, thank you.","commit_id":"e8a54a7519fd1ec7aa5299b2cca8af270481d4a2"}],"tests/tracing/configs/basic/ds/no-stream-id.yaml":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f132410d44b14e9c3f3ff72e40fdf0b4eb4f8d48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8bf59757_7604cdf4","updated":"2023-04-25 20:51:59.000000000","message":"Rename to `no-dst-id.yaml`.\n\nApply to other files.","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be2be164_5be7d6c0","in_reply_to":"8bf59757_7604cdf4","updated":"2023-04-27 15:18:10.000000000","message":"Done","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e05ffd3f4626b87673061d42e42b1c6448bb621a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# This makes sure that two common CTF trace readers (Babeltrace and"},{"line_number":33,"context_line":"# Trace Compass) will be able to read the traces produced."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"version: \u00272.2\u0027"},{"line_number":36,"context_line":"metadata:"},{"line_number":37,"context_line":"  type-aliases:"},{"line_number":38,"context_line":"    uint16:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8a0d27ab_14bfc035","line":35,"updated":"2023-04-25 20:30:25.000000000","message":"This test does the job, but I felt unsure about using a barectf 2 configuration for this test since all the existing tracing tests are barectf 3 configs. I felt it could be confusing, but then again people don\u0027t often look at the test code and the commit message has more information.\n\nShould I:\n* Use a barectf 3 config instead?\n* Make it more clear that this is a barectf 2 config? Maybe either in the file name or by putting the files related to this test in a separate folder.","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f132410d44b14e9c3f3ff72e40fdf0b4eb4f8d48","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# This makes sure that two common CTF trace readers (Babeltrace and"},{"line_number":33,"context_line":"# Trace Compass) will be able to read the traces produced."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"version: \u00272.2\u0027"},{"line_number":36,"context_line":"metadata:"},{"line_number":37,"context_line":"  type-aliases:"},{"line_number":38,"context_line":"    uint16:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e26e91cf_f1948ca7","line":35,"in_reply_to":"8a0d27ab_14bfc035","updated":"2023-04-25 20:51:59.000000000","message":"Yes please use a barectf 3 configuration explicitly disabling the DST ID feature.","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# This makes sure that two common CTF trace readers (Babeltrace and"},{"line_number":33,"context_line":"# Trace Compass) will be able to read the traces produced."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"version: \u00272.2\u0027"},{"line_number":36,"context_line":"metadata:"},{"line_number":37,"context_line":"  type-aliases:"},{"line_number":38,"context_line":"    uint16:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13a1858a_66eff47e","line":35,"in_reply_to":"e26e91cf_f1948ca7","updated":"2023-04-27 15:18:10.000000000","message":"Done","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"}],"tests/tracing/src/basic/ds/no-stream-id.c":[{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e05ffd3f4626b87673061d42e42b1c6448bb621a","unresolved":true,"context_lines":[{"line_number":25,"context_line":" */"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#include \u003cassert.h\u003e"},{"line_number":28,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"test-platform.h\""},{"line_number":31,"context_line":"#include \"barectf.h\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3e994f0f_bcf5739e","line":28,"updated":"2023-04-25 20:30:25.000000000","message":"Is this include required? I don\u0027t understand where it is needed in this file and the test appears to work without it.\n\n(I left it because the test I based this on (two-packets.c) also includes `stdint.h` and doesn\u0027t appear to use it.)","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000033,"name":"Erica Bugden","display_name":"Erica Bugden","email":"ebugden@efficios.com","username":"ebugden","avatars":[{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c42f50f12968dff6041103eb3b1af3bd.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ede210597a980612d52b2324b9b92c129c9d2a55","unresolved":false,"context_lines":[{"line_number":25,"context_line":" */"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#include \u003cassert.h\u003e"},{"line_number":28,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"test-platform.h\""},{"line_number":31,"context_line":"#include \"barectf.h\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0a05ebd1_6ce76cb1","line":28,"in_reply_to":"2f328fc9_36703c03","updated":"2023-04-27 15:18:10.000000000","message":"Done","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f132410d44b14e9c3f3ff72e40fdf0b4eb4f8d48","unresolved":true,"context_lines":[{"line_number":25,"context_line":" */"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#include \u003cassert.h\u003e"},{"line_number":28,"context_line":"#include \u003cstdint.h\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"test-platform.h\""},{"line_number":31,"context_line":"#include \"barectf.h\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2f328fc9_36703c03","line":28,"in_reply_to":"3e994f0f_bcf5739e","updated":"2023-04-25 20:51:59.000000000","message":"Oversight: you may remove it.","commit_id":"ce503c54356dfe560513043cf2ddbeb213ae5875"}]}