)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"barectf: add support for packet sequence number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a new optional packet features object `seq-num-field-type`,"},{"line_number":10,"context_line":"which generates the metadata field type name `packet_seq_num` when"},{"line_number":11,"context_line":"defined (defaults to false)."},{"line_number":12,"context_line":"Currently this is conditionally maintained in `struct barectf_ctx` as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4cb077ec_ac8f89b4","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":62},"updated":"2022-03-04 17:36:44.000000000","message":"Name it `sequence-number-field-type` for consistency (barectf always uses long names in the configuration).\n\nIt\u0027s okay to use `seq_num` for internal variables/parameters.","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"barectf: add support for packet sequence number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a new optional packet features object `seq-num-field-type`,"},{"line_number":10,"context_line":"which generates the metadata field type name `packet_seq_num` when"},{"line_number":11,"context_line":"defined (defaults to false)."},{"line_number":12,"context_line":"Currently this is conditionally maintained in `struct barectf_ctx` as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"64c97760_eda8bbc4","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":62},"in_reply_to":"4cb077ec_ac8f89b4","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9bc49b67_d692bedd","updated":"2022-03-04 17:36:44.000000000","message":"Thank you for this.\n\nPlease also add a packet sequence number accessor function as such:\n\n uint32_t {{ prefix }}sequence_number(const void *vctx);\n \nDeclare in `barectf.h.j2` and implement in `barectf.c.j2`. Use `discarded_event_records_count` as an example.\n\nBecause you told me it\u0027s your first Gerrit experience: make your changes, then amend this commit, then push again (do not submit another patch).\n\nYou can mark invidual comments as resolved by clicking \"DONE\" and then replying (press `a`).","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f3c78f6_d0db72cd","in_reply_to":"9bc49b67_d692bedd","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c9962a869a80da38c35d4915659ed8e9bebb5f62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf9c2a98_335e301c","updated":"2022-03-05 05:22:53.000000000","message":"Almost there!","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5ec5b85c1cb671805af9efd940b0ef71a6554008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fe4e09e_052a24db","updated":"2022-03-07 16:53:49.000000000","message":"Thanks Jon.\n\nI\u0027ll leave this here, add documentation to this patch this week, and then submit.\n\nThis should become barectf 3.1.0 afterwards.","commit_id":"dc2894e3bb0df663b95fc2bb85b3198e3c6f65ff"}],"barectf/config.py":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[{"line_number":443,"context_line":"                 beginning_timestamp_field_type: _OptDefaultableUIntFt \u003d None,"},{"line_number":444,"context_line":"                 end_timestamp_field_type: _OptDefaultableUIntFt \u003d None,"},{"line_number":445,"context_line":"                 discarded_event_records_snapshot_counter_field_type: _OptDefaultableUIntFt \u003d DEFAULT_FIELD_TYPE,"},{"line_number":446,"context_line":"                 seq_num_field_type: _OptDefaultableUIntFt \u003d None):"},{"line_number":447,"context_line":"        def get_ft(user_ft: _OptDefaultableUIntFt) -\u003e _OptUIntFt:"},{"line_number":448,"context_line":"            if user_ft \u003d\u003d DEFAULT_FIELD_TYPE:"},{"line_number":449,"context_line":"                return UnsignedIntegerFieldType(64)"}],"source_content_type":"text/x-python","patch_set":1,"id":"efdc18e7_b585e733","line":446,"range":{"start_line":446,"start_character":17,"end_line":446,"end_character":35},"updated":"2022-03-04 17:36:44.000000000","message":"sequence_number_field_type","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                 beginning_timestamp_field_type: _OptDefaultableUIntFt \u003d None,"},{"line_number":444,"context_line":"                 end_timestamp_field_type: _OptDefaultableUIntFt \u003d None,"},{"line_number":445,"context_line":"                 discarded_event_records_snapshot_counter_field_type: _OptDefaultableUIntFt \u003d DEFAULT_FIELD_TYPE,"},{"line_number":446,"context_line":"                 seq_num_field_type: _OptDefaultableUIntFt \u003d None):"},{"line_number":447,"context_line":"        def get_ft(user_ft: _OptDefaultableUIntFt) -\u003e _OptUIntFt:"},{"line_number":448,"context_line":"            if user_ft \u003d\u003d DEFAULT_FIELD_TYPE:"},{"line_number":449,"context_line":"                return UnsignedIntegerFieldType(64)"}],"source_content_type":"text/x-python","patch_set":1,"id":"308b7ccd_9a35fad6","line":446,"range":{"start_line":446,"start_character":17,"end_line":446,"end_character":35},"in_reply_to":"efdc18e7_b585e733","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        self._seq_num_field_type \u003d get_ft(seq_num_field_type)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    @property"},{"line_number":461,"context_line":"    def seq_num_field_type(self) -\u003e _OptUIntFt:"},{"line_number":462,"context_line":"        return self._seq_num_field_type"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"97656722_dd3e49a6","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":26},"updated":"2022-03-04 17:36:44.000000000","message":"sequence_number_field_type","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        self._seq_num_field_type \u003d get_ft(seq_num_field_type)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    @property"},{"line_number":461,"context_line":"    def seq_num_field_type(self) -\u003e _OptUIntFt:"},{"line_number":462,"context_line":"        return self._seq_num_field_type"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"db4ada71_aa722495","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":26},"in_reply_to":"97656722_dd3e49a6","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"}],"barectf/config_parse_v3.py":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[{"line_number":474,"context_line":"                                                                   \u0027discarded-event-records-counter-snapshot-field-type\u0027,"},{"line_number":475,"context_line":"                                                                   pkt_disc_er_counter_snap_ft)"},{"line_number":476,"context_line":"                    pkt_seq_num_ft \u003d self._feature_ft(pkt_node, \u0027seq-num-field-type\u0027,"},{"line_number":477,"context_line":"                                                         pkt_seq_num_ft)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"                # create event record feature field types"},{"line_number":480,"context_line":"                er_node \u003d features_node.get(\u0027event-record\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ced129c_fe88e890","line":477,"updated":"2022-03-04 17:36:44.000000000","message":"Vertically align with `pkt_node`.","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                                                                   \u0027discarded-event-records-counter-snapshot-field-type\u0027,"},{"line_number":475,"context_line":"                                                                   pkt_disc_er_counter_snap_ft)"},{"line_number":476,"context_line":"                    pkt_seq_num_ft \u003d self._feature_ft(pkt_node, \u0027seq-num-field-type\u0027,"},{"line_number":477,"context_line":"                                                         pkt_seq_num_ft)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"                # create event record feature field types"},{"line_number":480,"context_line":"                er_node \u003d features_node.get(\u0027event-record\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"83fb6d7c_9dbd15b3","line":477,"in_reply_to":"7ced129c_fe88e890","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"}],"barectf/templates/c/barectf.c.j2":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\t/* Mark packet as closed */"},{"line_number":389,"context_line":"\tctx-\u003epacket_is_open \u003d 0;"},{"line_number":390,"context_line":"\t{% set name \u003d \u0027packet_seq_num\u0027 %}"},{"line_number":391,"context_line":"\t{% if name in dst._pkt_ctx_ft.members %}"},{"line_number":392,"context_line":"\t{% filter indent_tab(indent_first\u003dtrue) %}"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"\t\t{% include \u0027c/serialize-inc-seq-num.j2\u0027 %}"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"\t{% endfilter %}"},{"line_number":397,"context_line":"\t{% endif %}"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"\t/* Not tracing anymore */"},{"line_number":400,"context_line":"\tctx-\u003ein_tracing_section \u003d saved_in_tracing_section;"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ad6b2caf_6ae3ede7","line":397,"range":{"start_line":390,"start_character":0,"end_line":397,"end_character":12},"updated":"2022-03-04 17:36:44.000000000","message":"I think all this block can only be:\n\n\tctx-\u003epacket_is_open \u003d 0;\n\t{% if \u0027packet_seq_num\u0027 in dst._pkt_ctx_ft.members %}\n\n\t/* Increment sequence number for next packet */\n\tctx-\u003esequence_number++;\n\t{% endif %}\n\n\t/* Not tracing anymore */\n\t\nand you don\u0027t need `serialize-inc-seq-num.j2`.","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"\t/* Mark packet as closed */"},{"line_number":389,"context_line":"\tctx-\u003epacket_is_open \u003d 0;"},{"line_number":390,"context_line":"\t{% set name \u003d \u0027packet_seq_num\u0027 %}"},{"line_number":391,"context_line":"\t{% if name in dst._pkt_ctx_ft.members %}"},{"line_number":392,"context_line":"\t{% filter indent_tab(indent_first\u003dtrue) %}"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"\t\t{% include \u0027c/serialize-inc-seq-num.j2\u0027 %}"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"\t{% endfilter %}"},{"line_number":397,"context_line":"\t{% endif %}"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"\t/* Not tracing anymore */"},{"line_number":400,"context_line":"\tctx-\u003ein_tracing_section \u003d saved_in_tracing_section;"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"eaaacc09_380c5bc2","line":397,"range":{"start_line":390,"start_character":0,"end_line":397,"end_character":12},"in_reply_to":"ad6b2caf_6ae3ede7","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"}],"barectf/templates/c/serialize-inc-seq-num.j2":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e88b769_b7ab10ff","updated":"2022-03-04 17:36:44.000000000","message":"File not needed (see other comment for `barectf.c.j2`).","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0156f114_c75b1440","in_reply_to":"5e88b769_b7ab10ff","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"}],"barectf/templates/c/serialize-write-seq-num-statements.j2":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{#"},{"line_number":2,"context_line":" # The MIT License (MIT)"},{"line_number":3,"context_line":" #"},{"line_number":4,"context_line":" # Copyright (c) 2020 Philippe Proulx \u003cpproulx@efficios.com\u003e"},{"line_number":5,"context_line":" #"},{"line_number":6,"context_line":" # Permission is hereby granted, free of charge, to any person obtaining"},{"line_number":7,"context_line":" # a copy of this software and associated documentation files (the"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ea982c05_a8f984fc","line":4,"updated":"2022-03-04 17:36:44.000000000","message":"You may put your own.","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{#"},{"line_number":2,"context_line":" # The MIT License (MIT)"},{"line_number":3,"context_line":" #"},{"line_number":4,"context_line":" # Copyright (c) 2020 Philippe Proulx \u003cpproulx@efficios.com\u003e"},{"line_number":5,"context_line":" #"},{"line_number":6,"context_line":" # Permission is hereby granted, free of charge, to any person obtaining"},{"line_number":7,"context_line":" # a copy of this software and associated documentation files (the"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"d2d1be81_5e9002c3","line":4,"in_reply_to":"ea982c05_a8f984fc","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"}],"tests/tracing/configs/counter-clock/dst-packet-features/sizes-uint16.yaml":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0b39085f5fe0e5817dbfec567935dc9160512d7b","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      default:"},{"line_number":33,"context_line":"        $features:"},{"line_number":34,"context_line":"          packet:"},{"line_number":35,"context_line":"            seq-num-field-type: uint16"},{"line_number":36,"context_line":"            total-size-field-type: uint16"},{"line_number":37,"context_line":"            content-size-field-type: uint16"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e9617ba8_cb5680f8","line":35,"updated":"2022-03-04 17:36:44.000000000","message":"This test is dedicated to the `*-size-field-type` features below.\n\nYou need to write a new test dedicated to `sequence-number-field-type` and make sure there are a few packets written to validate the increment.","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7949436ef6fe6a0acfba93c0e4a2d4647ca82eb7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      default:"},{"line_number":33,"context_line":"        $features:"},{"line_number":34,"context_line":"          packet:"},{"line_number":35,"context_line":"            seq-num-field-type: uint16"},{"line_number":36,"context_line":"            total-size-field-type: uint16"},{"line_number":37,"context_line":"            content-size-field-type: uint16"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a0897f97_f3b0d074","line":35,"in_reply_to":"e9617ba8_cb5680f8","updated":"2022-03-04 21:48:23.000000000","message":"Done","commit_id":"c2165fd5961ede758d755ee7170e88b1d427f268"}],"tests/tracing/src/counter-clock/dst-packet-features/seq-num.c":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c9962a869a80da38c35d4915659ed8e9bebb5f62","unresolved":true,"context_lines":[{"line_number":34,"context_line":"{"},{"line_number":35,"context_line":"\tstruct test_platform_ctx * const platform_ctx \u003d test_platform_init(64);"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    assert(platform_ctx);"},{"line_number":38,"context_line":"    assert(barectf_packet_sequence_number(test_platform_barectf_ctx(platform_ctx)) \u003d\u003d 0);"},{"line_number":39,"context_line":"    barectf_trace_ev(test_platform_barectf_ctx(platform_ctx),"},{"line_number":40,"context_line":"        \"I feel special.\");"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"aa7c3bb1_433d0b04","line":37,"updated":"2022-03-05 05:22:53.000000000","message":"Use tabs throughout.","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7ade12d66dbd4521e73e2338c4c8eda8524a3370","unresolved":false,"context_lines":[{"line_number":34,"context_line":"{"},{"line_number":35,"context_line":"\tstruct test_platform_ctx * const platform_ctx \u003d test_platform_init(64);"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    assert(platform_ctx);"},{"line_number":38,"context_line":"    assert(barectf_packet_sequence_number(test_platform_barectf_ctx(platform_ctx)) \u003d\u003d 0);"},{"line_number":39,"context_line":"    barectf_trace_ev(test_platform_barectf_ctx(platform_ctx),"},{"line_number":40,"context_line":"        \"I feel special.\");"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8c110e09_d0e6bd29","line":37,"in_reply_to":"aa7c3bb1_433d0b04","updated":"2022-03-05 14:04:25.000000000","message":"Ack","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c9962a869a80da38c35d4915659ed8e9bebb5f62","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        \"I feel more special.\");"},{"line_number":43,"context_line":"    assert(barectf_packet_sequence_number(test_platform_barectf_ctx(platform_ctx)) \u003d\u003d 1);"},{"line_number":44,"context_line":"\ttest_platform_fini(platform_ctx);"},{"line_number":45,"context_line":"    assert(barectf_packet_sequence_number(test_platform_barectf_ctx(platform_ctx)) \u003d\u003d 2);"},{"line_number":46,"context_line":"\treturn 0;"},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"befa72ac_d8a98970","line":45,"updated":"2022-03-05 05:22:53.000000000","message":"This one I think we don\u0027t care about: there\u0027s no point in reading the sequence number after the platform is finalized.","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7ade12d66dbd4521e73e2338c4c8eda8524a3370","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \"I feel more special.\");"},{"line_number":43,"context_line":"    assert(barectf_packet_sequence_number(test_platform_barectf_ctx(platform_ctx)) \u003d\u003d 1);"},{"line_number":44,"context_line":"\ttest_platform_fini(platform_ctx);"},{"line_number":45,"context_line":"    assert(barectf_packet_sequence_number(test_platform_barectf_ctx(platform_ctx)) \u003d\u003d 2);"},{"line_number":46,"context_line":"\treturn 0;"},{"line_number":47,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"86e846e1_870c6d80","line":45,"in_reply_to":"befa72ac_d8a98970","updated":"2022-03-05 14:04:25.000000000","message":"Heh, yeah, I agree","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"}],"tests/tracing/support/counter-clock/base-no-features.yaml":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c9962a869a80da38c35d4915659ed8e9bebb5f62","unresolved":true,"context_lines":[{"line_number":9,"context_line":"        beginning-timestamp-field-type: false"},{"line_number":10,"context_line":"        end-timestamp-field-type: false"},{"line_number":11,"context_line":"        discarded-event-records-counter-snapshot-field-type: false"},{"line_number":12,"context_line":"        sequence-number-field-type: false"},{"line_number":13,"context_line":"      event-record:"},{"line_number":14,"context_line":"        timestamp-field-type: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d9a69660_e338f918","line":12,"updated":"2022-03-05 05:22:53.000000000","message":"Isn\u0027t this equivalent to not having it?","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"348a415d358314f4daedca7e5eb5f67d2f654a87","unresolved":true,"context_lines":[{"line_number":9,"context_line":"        beginning-timestamp-field-type: false"},{"line_number":10,"context_line":"        end-timestamp-field-type: false"},{"line_number":11,"context_line":"        discarded-event-records-counter-snapshot-field-type: false"},{"line_number":12,"context_line":"        sequence-number-field-type: false"},{"line_number":13,"context_line":"      event-record:"},{"line_number":14,"context_line":"        timestamp-field-type: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"882feab1_c664ebb0","line":12,"in_reply_to":"46067041_96df5953","updated":"2022-03-05 15:38:24.000000000","message":"\u003e I can remove it.\n\nYes you can please, this file is included as the root, so there\u0027s nothing to cancel.\u003d","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"601b036980c9aeed1d94c13413df4bbdede84581","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        beginning-timestamp-field-type: false"},{"line_number":10,"context_line":"        end-timestamp-field-type: false"},{"line_number":11,"context_line":"        discarded-event-records-counter-snapshot-field-type: false"},{"line_number":12,"context_line":"        sequence-number-field-type: false"},{"line_number":13,"context_line":"      event-record:"},{"line_number":14,"context_line":"        timestamp-field-type: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1bffb8c6_2c05441d","line":12,"in_reply_to":"882feab1_c664ebb0","updated":"2022-03-05 15:45:03.000000000","message":"Done","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"},{"author":{"_account_id":1000025,"name":"Jon","email":"jon@auxon.io","username":"jonlamb-gh","avatars":[{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3649ed3e2782ff7e53936adeab0dc5d.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"7ade12d66dbd4521e73e2338c4c8eda8524a3370","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        beginning-timestamp-field-type: false"},{"line_number":10,"context_line":"        end-timestamp-field-type: false"},{"line_number":11,"context_line":"        discarded-event-records-counter-snapshot-field-type: false"},{"line_number":12,"context_line":"        sequence-number-field-type: false"},{"line_number":13,"context_line":"      event-record:"},{"line_number":14,"context_line":"        timestamp-field-type: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"46067041_96df5953","line":12,"in_reply_to":"d9a69660_e338f918","updated":"2022-03-05 14:04:25.000000000","message":"Yep, I wasn\u0027t sure if this yaml file should explicitly have all the features disabled regardless of their default or not for readability.\nI can remove it.","commit_id":"8cdea2b5bad3b1f5fe8fa6af9ed744b2d0046153"}]}