)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a28a6372832358d1689fff6fe61783eb9c14ed6d","unresolved":true,"context_lines":[{"line_number":15,"context_line":"[13:15:49.024354958] (+0.000003868) wilbrod block_rq_complete: { cpu_id \u003d 4 },"},{"line_number":16,"context_line":"    { dev \u003d 8388624, sector \u003d 375490176, nr_sector \u003d 360, error \u003d 0,"},{"line_number":17,"context_line":"      rwbs \u003d ( \"RWBS_FLAG_READ\" | \"RWBS_FLAG_RAHEAD\" : container \u003d 12 ) }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I26a17307243d5612c70c0e5b04e6b9567b0720d3"},{"line_number":20,"context_line":"Signed-off-by: Geneviève Bastien \u003cgbastien@versatic.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d9b98306_02306d94","line":18,"updated":"2020-02-13 21:44:00.000000000","message":"Please add more details (how this state cached, etc.)\n\nLook at other (non-trivial) commit messages of the git log to get a feel for the format/verbosity.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"9732f1f1c47348ef21c705dd94142f29fba12710","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[13:15:49.024354958] (+0.000003868) wilbrod block_rq_complete: { cpu_id \u003d 4 },"},{"line_number":16,"context_line":"    { dev \u003d 8388624, sector \u003d 375490176, nr_sector \u003d 360, error \u003d 0,"},{"line_number":17,"context_line":"      rwbs \u003d ( \"RWBS_FLAG_READ\" | \"RWBS_FLAG_RAHEAD\" : container \u003d 12 ) }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I26a17307243d5612c70c0e5b04e6b9567b0720d3"},{"line_number":20,"context_line":"Signed-off-by: Geneviève Bastien \u003cgbastien@versatic.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fad9a36c_6fa52d64","line":18,"in_reply_to":"d9b98306_02306d94","updated":"2020-08-06 18:24:27.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":28,"context_line":"is, but can be expressed as a binary OR of two existing values."},{"line_number":29,"context_line":"This can happen if an application changes the possible values of an"},{"line_number":30,"context_line":"enumeration but forgets to update the metadata associated with"},{"line_number":31,"context_line":"that recorded field. Such value should be printed as \u003cunknown\u003e."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Print all labels matching value"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"a5f12d7f_15d09a2a","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":38},"updated":"2020-07-20 21:02:21.000000000","message":"must","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"is, but can be expressed as a binary OR of two existing values."},{"line_number":29,"context_line":"This can happen if an application changes the possible values of an"},{"line_number":30,"context_line":"enumeration but forgets to update the metadata associated with"},{"line_number":31,"context_line":"that recorded field. Such value should be printed as \u003cunknown\u003e."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Print all labels matching value"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"61f885db_65a6d5fe","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":38},"in_reply_to":"a5f12d7f_15d09a2a","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":33,"context_line":"Print all labels matching value"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":"With this commit, a `sink.text.pretty` component will print all matching"},{"line_number":36,"context_line":"labels inside curly brackets separated by commas. See"},{"line_number":37,"context_line":"`print_enum_value_label_array()`."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Change-Id: I26a17307243d5612c70c0e5b04e6b9567b0720d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"65853634_6f4b0676","line":36,"updated":"2020-07-20 21:02:21.000000000","message":"Add an output example here.","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Print all labels matching value"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":"With this commit, a `sink.text.pretty` component will print all matching"},{"line_number":36,"context_line":"labels inside curly brackets separated by commas. See"},{"line_number":37,"context_line":"`print_enum_value_label_array()`."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Change-Id: I26a17307243d5612c70c0e5b04e6b9567b0720d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"f829a595_d5dfc14c","line":36,"in_reply_to":"65853634_6f4b0676","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"8f64f6140e5f83c3cef40a36eabc405e53c1371e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"27fd79d5_22e0d245","updated":"2021-03-23 17:35:01.000000000","message":"\u003e Patch Set 12: Code-Review-1\n\u003e \n\u003e \u003e Patch Set 5: Code-Review-1\n\u003e \u003e \n\u003e \u003e (19 comments)\n\u003e \u003e \n\u003e \u003e This is my first pass. I didn\u0027t try it yet.\n\u003e \u003e \n\u003e \u003e General points:\n\u003e \u003e \n\u003e \u003e * Please honour our coding style (see \u003chttps://github.com/efficios/babeltrace/blob/stable-2.0/CodingStyle\u003e).\n\u003e \u003e * Separate declarations from statements, as well as (ideally) control statements from other statements, with a newline.\n\u003e \u003e * Will you (or do you) handle the zero case as Mathieu suggested on #lttng?\n\u003e \u003e * Can you make this behaviour conditional to a boolean initialization parameter (which can be `true` by default)? Call it `print-enum-flags`.\n\u003e \n\u003e I don\u0027t think it can be `true` by default. \n\u003e \n\u003e It seems that \"flag\" enumerations will remain unspecified by CTF 1.x [1]. I understand the position, but that means we don\u0027t have a reliable way of identifying \"flag\" enumerations as such and it breaks legitimate use-cases now that un-mapped enums are explicitly allowed (upcoming CTF 1.8.3).\n\u003e \n\u003e To quote Mathieu on the rationale for allowing unmapped enumeration values:\n\u003e \n\u003e \u003e When I wrote the spec initially, I must admit that I did not think\n\u003e much about the unknown value scenario. When facing real-life traces\n\u003e though, I quickly realized that it is very important to support decoding\n\u003e of enums which have a container integer with an unknown value, because\n\u003e we do not control what applications define as enum labels, along with\n\u003e the fact that the input value coming from the application can evolve\n\u003e over time and releases of the application, and there is no compile-time\n\u003e validation that the list of labels is complete.\n\u003e \n\u003e This means that we must support an application that adds values to its enumerations without adding a matching `ctf_enum_value` or re-building the providers.\n\u003e \n\u003e Take for example an instrumented application with the following initial enum used in a tracepoint:\n\u003e \n\u003e  enum codec_id {\n\u003e      CODEC_ID_MPEG2 \u003d 1,\n\u003e      CODEC_ID_H264 \u003d 2,\n\u003e  };\n\u003e \n\u003e This enum can evolve and become:\n\u003e \n\u003e  enum codec_id {\n\u003e      CODEC_ID_MPEG2 \u003d 1,\n\u003e      CODEC_ID_H264 \u003d 2,\n\u003e      CODEC_ID_AV1 \u003d 3,\n\u003e  };\n\u003e \n\u003e Without a way to tag an enum as _not_ being a \"flag\" enumeration, I guess the original enumeration would be identified as an \"enum-flag\"? In that case, this means that when the application uses the tracepoint with the new `CODEC_ID_AV1` entry, babeltrace will mislead the user by printing.\n\u003e \n\u003e  [...] \"CODEC_ID_MPEG2 | CODEC_ID_H264\" [...]\n\u003e \n\u003e which is nonsensical in this context.\n\u003e \n\u003e The average user could reasonably interpret this as a number of things:\n\u003e  * \"two codecs are enabled\",\n\u003e  * \"the application is passing non-sense\",\n\u003e  * \"LTTng is broken!!\"\n\u003e \n\u003e All of which are more likely than\n\u003e \n\u003e \u003e Goodness me, I guess the providers weren\u0027t rebuilt and that the application is now using a new enum value that happens to be equal to the binary OR of two existing values!\n\u003e \n\u003e I\u0027d be glad to be wrong, but unless there is a reliable solution, this `print-enum-flags` option will have to default to `false`. We will be able to use that formatting code by default when the CTF (2?) specification allows us to identify these types of enums non-ambiguously.\n\u003e \n\u003e Thanks!\n\u003e \n\u003e  [1] https://lists.lttng.org/pipermail/lttng-dev/2020-April/029620.html\n\u003e \n\u003e \u003e * I know `sink.text.pretty` does not have tests formally, but can you add one for this new feature? Simon can help you with that. Test with both `print-enum-flags\u003dyes` and `print-enum-flags\u003dno`.\n\u003e \u003e \n\u003e \u003e Thank you!\n\nI think we should implement a better stop-gap solution while awaiting CTF2. I recommend that we specialize the babeltrace2 CTF input plugin to detect traces produced by the lttng-modules kernel tracer, for specific known (hardcoded) events and fields which have a bitwise enum semantic, and use this hardcoded knowledge to print the correct bitwise enum to the end user rather than \"\u003cunknown\u003e\".\n\nThis should ensure the current producer/consumer tools work well together (show complete information about those bitwise enums) without requiring to add tons of documentation about the specific flags needed for bt2 to handle lttng traces appropriately. And this would not lead to misleading scenarios where we print an unknown value as a bitwise enum by mistake.\n\nThoughts ?\n\nThanks,\n\nMathieu","commit_id":"5288c8aef93013b72a48cec6851a00b0c91f09dc"},{"author":{"_account_id":1000008,"name":"Jonathan Rajotte Julien","email":"jonathan.rajotte-julien@efficios.com","username":"PSRCode","avatars":[{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f4101e071636faa234915893668fa03c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"75450ad4c93141907d5e4a53d1712092c96b45ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ab18b358_1d592a94","updated":"2021-03-23 17:55:02.000000000","message":"Please continue the discussion here: https://bugs.lttng.org/issues/1300","commit_id":"5288c8aef93013b72a48cec6851a00b0c91f09dc"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"364f7878a85d2ba1e139eb941dc08c88ac4224ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"164f4940_87dbad70","in_reply_to":"27fd79d5_22e0d245","updated":"2021-03-23 17:50:00.000000000","message":"How do you suggest that such a hard-coded knowledge travel from `src.ctf.fs` to `sink.text.pretty`, for example?","commit_id":"5288c8aef93013b72a48cec6851a00b0c91f09dc"}],"src/plugins/text/pretty/pretty.c":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":68,"context_line":"\t\t\tperror(\"close output file\");"},{"line_number":69,"context_line":"\t\t}"},{"line_number":70,"context_line":"\t}"},{"line_number":71,"context_line":"\tg_hash_table_destroy(pretty-\u003eenum_bit_field_cache);"},{"line_number":72,"context_line":"\tpretty-\u003eenum_bit_field_cache \u003d NULL;"},{"line_number":73,"context_line":"\tg_free(pretty-\u003eoptions.output_path);"},{"line_number":74,"context_line":"\tg_free(pretty);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"029d64ad_2dbd4266","line":71,"updated":"2020-02-13 22:17:56.000000000","message":"Conditional to `pretty-\u003eenum_bit_field_cache`.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\t\t\tperror(\"close output file\");"},{"line_number":69,"context_line":"\t\t}"},{"line_number":70,"context_line":"\t}"},{"line_number":71,"context_line":"\tg_hash_table_destroy(pretty-\u003eenum_bit_field_cache);"},{"line_number":72,"context_line":"\tpretty-\u003eenum_bit_field_cache \u003d NULL;"},{"line_number":73,"context_line":"\tg_free(pretty-\u003eoptions.output_path);"},{"line_number":74,"context_line":"\tg_free(pretty);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"40cfd35e_c40c8107","line":71,"in_reply_to":"029d64ad_2dbd4266","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":94,"context_line":"\tif (!pretty-\u003etmp_string) {"},{"line_number":95,"context_line":"\t\tgoto error;"},{"line_number":96,"context_line":"\t}"},{"line_number":97,"context_line":"\tpretty-\u003eenum_bit_field_cache \u003d g_hash_table_new(g_direct_hash, g_direct_equal);"},{"line_number":98,"context_line":"end:"},{"line_number":99,"context_line":"\treturn pretty;"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"38470b4a_71e76118","line":97,"updated":"2020-02-13 22:17:56.000000000","message":"Make sure this does not return `NULL`.\n\nI know it cannot but we do it troughout the code to follow a good practice and ease a transition to something else than GLib one day.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":94,"context_line":"\tif (!pretty-\u003etmp_string) {"},{"line_number":95,"context_line":"\t\tgoto error;"},{"line_number":96,"context_line":"\t}"},{"line_number":97,"context_line":"\tpretty-\u003eenum_bit_field_cache \u003d g_hash_table_new(g_direct_hash, g_direct_equal);"},{"line_number":98,"context_line":"end:"},{"line_number":99,"context_line":"\treturn pretty;"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"2bc73440_5386fb93","line":97,"in_reply_to":"209a143a_b6dbd5c9","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a02a94619240380c11447896952151857261731e","unresolved":true,"context_lines":[{"line_number":94,"context_line":"\tif (!pretty-\u003etmp_string) {"},{"line_number":95,"context_line":"\t\tgoto error;"},{"line_number":96,"context_line":"\t}"},{"line_number":97,"context_line":"\tpretty-\u003eenum_bit_field_cache \u003d g_hash_table_new(g_direct_hash, g_direct_equal);"},{"line_number":98,"context_line":"end:"},{"line_number":99,"context_line":"\treturn pretty;"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"209a143a_b6dbd5c9","line":97,"in_reply_to":"38470b4a_71e76118","updated":"2020-02-13 22:23:54.000000000","message":"throughout*","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":53,"context_line":"\t\t}"},{"line_number":54,"context_line":"\t}"},{"line_number":55,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":56,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":57,"context_line":"\t\t\tg_ptr_array_free(pretty-\u003eenum_bit_labels[i], true);"},{"line_number":58,"context_line":"\t\t}"},{"line_number":59,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"5f99e878_d447efd1","line":56,"updated":"2020-06-22 15:12:12.000000000","message":"You can declare `i` in the `if` scope.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"afbdbbb0eb2f74c509360801bb6e41d7c7eed1de","unresolved":false,"context_lines":[{"line_number":53,"context_line":"\t\t}"},{"line_number":54,"context_line":"\t}"},{"line_number":55,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":56,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":57,"context_line":"\t\t\tg_ptr_array_free(pretty-\u003eenum_bit_labels[i], true);"},{"line_number":58,"context_line":"\t\t}"},{"line_number":59,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"c40b7db7_35f9cb56","line":56,"in_reply_to":"5f99e878_d447efd1","updated":"2020-06-22 19:12:23.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":598,"context_line":"\tset_use_colors(pretty);"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":601,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":602,"context_line":"\t\t\tpretty-\u003eenum_bit_labels[i] \u003d g_ptr_array_new();"},{"line_number":603,"context_line":"\t\t}"},{"line_number":604,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"cfea5ae7_e87b954a","line":601,"updated":"2020-06-22 15:12:12.000000000","message":"Declare `i` in this scope.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"afbdbbb0eb2f74c509360801bb6e41d7c7eed1de","unresolved":false,"context_lines":[{"line_number":598,"context_line":"\tset_use_colors(pretty);"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":601,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":602,"context_line":"\t\t\tpretty-\u003eenum_bit_labels[i] \u003d g_ptr_array_new();"},{"line_number":603,"context_line":"\t\t}"},{"line_number":604,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"c40f9e04_3beb9f4a","line":601,"in_reply_to":"cfea5ae7_e87b954a","updated":"2020-06-22 19:12:23.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":50,"context_line":"\t\t\tperror(\"close output file\");"},{"line_number":51,"context_line":"\t\t}"},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":54,"context_line":"\t\tint i;"},{"line_number":55,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":56,"context_line":"\t\t\tg_ptr_array_free(pretty-\u003eenum_bit_labels[i], true);"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"b274a1fc_068585e2","line":53,"updated":"2020-07-20 21:02:21.000000000","message":"I suggest that you free the arrays anyway, whether or not the condition making them exist is satisfied.\n\nFor each array, check\n\n if (pretty-\u003eenum_bit_labels[i]) {\n     // free it\n }","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"\t\t\tperror(\"close output file\");"},{"line_number":51,"context_line":"\t\t}"},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":54,"context_line":"\t\tint i;"},{"line_number":55,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":56,"context_line":"\t\t\tg_ptr_array_free(pretty-\u003eenum_bit_labels[i], true);"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"e42ceb17_f891f849","line":53,"in_reply_to":"b274a1fc_068585e2","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":51,"context_line":"\t\t}"},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":54,"context_line":"\t\tint i;"},{"line_number":55,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":56,"context_line":"\t\t\tg_ptr_array_free(pretty-\u003eenum_bit_labels[i], true);"},{"line_number":57,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"8aecf892_3ffd3add","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":5},"updated":"2020-07-20 21:02:21.000000000","message":"`uint64_t`, like elsewhere.","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\t\t}"},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":54,"context_line":"\t\tint i;"},{"line_number":55,"context_line":"\t\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":56,"context_line":"\t\t\tg_ptr_array_free(pretty-\u003eenum_bit_labels[i], true);"},{"line_number":57,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"2ccc6bad_15867e58","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":5},"in_reply_to":"8aecf892_3ffd3add","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":596,"context_line":"\tset_use_colors(pretty);"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":599,"context_line":"\t\tint i;"},{"line_number":600,"context_line":"\t\t/*"},{"line_number":601,"context_line":"\t\t * Allocate all label arrays during the initialization of the"},{"line_number":602,"context_line":"\t\t * component and reuse the same set of arrays for all"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"ec7c6a95_749165c6","line":599,"range":{"start_line":599,"start_character":2,"end_line":599,"end_character":5},"updated":"2020-07-20 21:02:21.000000000","message":"`uint64_t`, like elsewhere.","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":596,"context_line":"\tset_use_colors(pretty);"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\tif (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":599,"context_line":"\t\tint i;"},{"line_number":600,"context_line":"\t\t/*"},{"line_number":601,"context_line":"\t\t * Allocate all label arrays during the initialization of the"},{"line_number":602,"context_line":"\t\t * component and reuse the same set of arrays for all"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"07b58e38_9e22b3c4","line":599,"range":{"start_line":599,"start_character":2,"end_line":599,"end_character":5},"in_reply_to":"ec7c6a95_749165c6","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"}],"src/plugins/text/pretty/pretty.h":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"\tbool negative_timestamp_warning_done;"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"\tGHashTable * enum_bit_field_cache;"},{"line_number":94,"context_line":"};"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"BT_HIDDEN"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"d5c1cb7b_cfcf0acf","line":93,"updated":"2020-02-13 22:17:56.000000000","message":"Coding style issue.\n\nSee \u003chttps://github.com/efficios/babeltrace/blob/stable-2.0/CodingStyle\u003e.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"\tbool negative_timestamp_warning_done;"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"\tGHashTable * enum_bit_field_cache;"},{"line_number":94,"context_line":"};"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"BT_HIDDEN"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"64c25d07_b56545f3","line":93,"in_reply_to":"d5c1cb7b_cfcf0acf","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tbool negative_timestamp_warning_done;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\tGPtrArray *enum_bit_labels[ENUMERATION_MAX_BITFLAGS_NUMBER];"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"\tbt_logging_level log_level;"},{"line_number":85,"context_line":"\tbt_self_component *self_comp;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"0db821e4_d508327e","line":82,"updated":"2020-06-22 15:12:12.000000000","message":"Can you add a comment explaining what this contains?  For each bit, we have a list (GPtrArray) of what?","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"d894da5d7a6c53a9913c68da8033dbee159c55cc","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tbool negative_timestamp_warning_done;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\tGPtrArray *enum_bit_labels[ENUMERATION_MAX_BITFLAGS_NUMBER];"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"\tbt_logging_level log_level;"},{"line_number":85,"context_line":"\tbt_self_component *self_comp;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"99132e2b_37d0b72b","line":82,"in_reply_to":"0db821e4_d508327e","updated":"2020-06-22 17:08:46.000000000","message":"In that comment, I\u0027d also mention that this doesn\u0027t really _need_ to be a field of `struct pretty_component`, but it is so to avoid allocating/free-ing that memory at event processed event.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e44dbbb14a6cd16588fd04ff2a915c1302906bf7","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"\tbool negative_timestamp_warning_done;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\tGPtrArray *enum_bit_labels[ENUMERATION_MAX_BITFLAGS_NUMBER];"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"\tbt_logging_level log_level;"},{"line_number":85,"context_line":"\tbt_self_component *self_comp;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"1c20d87f_b49b84a7","line":82,"in_reply_to":"99132e2b_37d0b72b","updated":"2020-06-22 19:17:20.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":17,"context_line":" * `bt_field_*_enumeration` are backed by 64 bits integers so the maximun"},{"line_number":18,"context_line":" * number of bitflags in any enumeration is 64."},{"line_number":19,"context_line":" */"},{"line_number":20,"context_line":"#define ENUMERATION_MAX_BITFLAGS_NUMBER 64"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"enum pretty_default {"},{"line_number":23,"context_line":"\tPRETTY_DEFAULT_UNSET,"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"2d561638_a26acde2","line":20,"updated":"2020-07-20 21:02:21.000000000","message":"Minor: should we rely on the library\u0027s type here?\n\nLike:\n\n sizeof(uint64_t) * 8\n\n?\n\nAlso `COUNT` instead of `NUMBER`?","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":17,"context_line":" * `bt_field_*_enumeration` are backed by 64 bits integers so the maximun"},{"line_number":18,"context_line":" * number of bitflags in any enumeration is 64."},{"line_number":19,"context_line":" */"},{"line_number":20,"context_line":"#define ENUMERATION_MAX_BITFLAGS_NUMBER 64"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"enum pretty_default {"},{"line_number":23,"context_line":"\tPRETTY_DEFAULT_UNSET,"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"cc283d14_4d196b80","line":20,"in_reply_to":"2d561638_a26acde2","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"}],"src/plugins/text/pretty/print.c":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"static"},{"line_number":686,"context_line":"int is_enum_flag_unsigned(const bt_field *field,"},{"line_number":687,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":688,"context_line":"{"},{"line_number":689,"context_line":"\tint ret \u003d 1, i;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"ca577cb4_c02bf46f","line":686,"range":{"start_line":686,"start_character":0,"end_line":686,"end_character":3},"updated":"2020-02-13 22:17:56.000000000","message":"Use `bool`.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"static"},{"line_number":686,"context_line":"int is_enum_flag_unsigned(const bt_field *field,"},{"line_number":687,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":688,"context_line":"{"},{"line_number":689,"context_line":"\tint ret \u003d 1, i;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8d431f3c_a6fe5d05","line":686,"range":{"start_line":686,"start_character":0,"end_line":686,"end_character":3},"in_reply_to":"ca577cb4_c02bf46f","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":686,"context_line":"int is_enum_flag_unsigned(const bt_field *field,"},{"line_number":687,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":688,"context_line":"{"},{"line_number":689,"context_line":"\tint ret \u003d 1, i;"},{"line_number":690,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"},{"line_number":691,"context_line":"\t\tuint64_t j;"},{"line_number":692,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"d1068472_a2e29327","line":689,"range":{"start_line":689,"start_character":14,"end_line":689,"end_character":15},"updated":"2020-02-13 22:17:56.000000000","message":"Use `uint64_t`.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":686,"context_line":"int is_enum_flag_unsigned(const bt_field *field,"},{"line_number":687,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":688,"context_line":"{"},{"line_number":689,"context_line":"\tint ret \u003d 1, i;"},{"line_number":690,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"},{"line_number":691,"context_line":"\t\tuint64_t j;"},{"line_number":692,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"0a6aa311_b4eccefa","line":689,"range":{"start_line":689,"start_character":14,"end_line":689,"end_character":15},"in_reply_to":"d1068472_a2e29327","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":688,"context_line":"{"},{"line_number":689,"context_line":"\tint ret \u003d 1, i;"},{"line_number":690,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"},{"line_number":691,"context_line":"\t\tuint64_t j;"},{"line_number":692,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"},{"line_number":693,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_borrow_mapping_by_index_const(fc, i);"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"22b3583f_11c252a2","line":691,"range":{"start_line":691,"start_character":11,"end_line":691,"end_character":12},"updated":"2020-02-13 22:17:56.000000000","message":"Use a more explicit name like `range_i`.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":688,"context_line":"{"},{"line_number":689,"context_line":"\tint ret \u003d 1, i;"},{"line_number":690,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"},{"line_number":691,"context_line":"\t\tuint64_t j;"},{"line_number":692,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"},{"line_number":693,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_borrow_mapping_by_index_const(fc, i);"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"ae944768_44efecea","line":691,"range":{"start_line":691,"start_character":11,"end_line":691,"end_character":12},"in_reply_to":"22b3583f_11c252a2","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"b0a1d947732baeebed1171591f71cf10fb7a14de","unresolved":true,"context_lines":[{"line_number":701,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":702,"context_line":"\t\t\tuint64_t upper \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":703,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"fc99da4d_02800628","line":704,"updated":"2020-02-14 14:48:38.000000000","message":"This handles the 0 case for the range values","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"933e668900de715356e4f071b2fb2c3a1e46f983","unresolved":false,"context_lines":[{"line_number":701,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":702,"context_line":"\t\t\tuint64_t upper \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":703,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"276f6c88_8e0278ea","line":704,"in_reply_to":"8de99cb0_4459f8ca","updated":"2020-08-06 18:24:43.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"9732f1f1c47348ef21c705dd94142f29fba12710","unresolved":true,"context_lines":[{"line_number":701,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":702,"context_line":"\t\t\tuint64_t upper \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":703,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8de99cb0_4459f8ca","line":704,"in_reply_to":"fc99da4d_02800628","updated":"2020-08-06 18:24:27.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":701,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":702,"context_line":"\t\t\tuint64_t upper \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":703,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"64af7245_fc1498eb","line":705,"range":{"start_line":704,"start_character":5,"end_line":705,"end_character":32},"updated":"2020-02-13 22:17:56.000000000","message":"Move to a dedicated `static inline` function, something like is_pow2().","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":701,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":702,"context_line":"\t\t\tuint64_t upper \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":703,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b9e6b820_646869d2","line":705,"range":{"start_line":704,"start_character":5,"end_line":705,"end_character":32},"in_reply_to":"179ba1b2_a99277db","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ada8a8bab7e85c31a1ac6becd2e6191a9b0ac191","unresolved":true,"context_lines":[{"line_number":701,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":702,"context_line":"\t\t\tuint64_t upper \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":703,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"179ba1b2_a99277db","line":705,"range":{"start_line":704,"start_character":5,"end_line":705,"end_character":32},"in_reply_to":"64af7245_fc1498eb","updated":"2020-02-13 22:19:05.000000000","message":"Edit: just `static` will do.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t\t}"},{"line_number":709,"context_line":"\t\t\tif (!ret) {"},{"line_number":710,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"10cb2d5b_5535d0a7","line":707,"updated":"2020-02-13 22:17:56.000000000","message":"You could go to the end directly here instead, and not have the conditional below.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":704,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":705,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":706,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":707,"context_line":"\t\t\t\tbreak;"},{"line_number":708,"context_line":"\t\t\t}"},{"line_number":709,"context_line":"\t\t\tif (!ret) {"},{"line_number":710,"context_line":"\t\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"d75504e7_6ebcb5be","line":707,"in_reply_to":"10cb2d5b_5535d0a7","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":714,"context_line":"\treturn ret;"},{"line_number":715,"context_line":"}"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"static"},{"line_number":718,"context_line":"int is_enum_flag_signed(const bt_field *field,"},{"line_number":719,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":720,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"a27550a8_3d6ab97c","line":717,"updated":"2020-02-13 22:17:56.000000000","message":"Apply all is_enum_flag_unsigned() comments.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":714,"context_line":"\treturn ret;"},{"line_number":715,"context_line":"}"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"static"},{"line_number":718,"context_line":"int is_enum_flag_signed(const bt_field *field,"},{"line_number":719,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":720,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"052dcbba_c0d50ef8","line":717,"in_reply_to":"a27550a8_3d6ab97c","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":733,"context_line":"\t\t\tint64_t lower \u003d bt_integer_range_signed_get_lower(range);"},{"line_number":734,"context_line":"\t\t\tint64_t upper \u003d bt_integer_range_signed_get_upper(range);"},{"line_number":735,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":736,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":737,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":738,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":739,"context_line":"\t\t\t\tbreak;"},{"line_number":740,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1ab7c96e_3d7c71b0","line":737,"range":{"start_line":736,"start_character":5,"end_line":737,"end_character":26},"updated":"2020-02-13 22:17:56.000000000","message":"Will this work for negative values? Just asking/curious.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":733,"context_line":"\t\t\tint64_t lower \u003d bt_integer_range_signed_get_lower(range);"},{"line_number":734,"context_line":"\t\t\tint64_t upper \u003d bt_integer_range_signed_get_upper(range);"},{"line_number":735,"context_line":"\t\t\tif ((lower !\u003d upper) ||"},{"line_number":736,"context_line":"\t\t\t\t!(lower \u003d\u003d 0 ||"},{"line_number":737,"context_line":"\t\t\t\t\t(lower \u0026 (lower - 1)) \u003d\u003d 0)) {"},{"line_number":738,"context_line":"\t\t\t\tret \u003d 0;"},{"line_number":739,"context_line":"\t\t\t\tbreak;"},{"line_number":740,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"57f4db6a_af82a414","line":737,"range":{"start_line":736,"start_character":5,"end_line":737,"end_character":26},"in_reply_to":"1ab7c96e_3d7c71b0","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":747,"context_line":"}"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"static"},{"line_number":750,"context_line":"int is_enum_flag(struct pretty_component *pretty,"},{"line_number":751,"context_line":"\t\tconst bt_field *field, const bt_field_class *fc)"},{"line_number":752,"context_line":"{"},{"line_number":753,"context_line":"\tint ret \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"173e2507_faa40218","line":750,"range":{"start_line":750,"start_character":0,"end_line":750,"end_character":3},"updated":"2020-02-13 22:17:56.000000000","message":"Use `bool`.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":747,"context_line":"}"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"static"},{"line_number":750,"context_line":"int is_enum_flag(struct pretty_component *pretty,"},{"line_number":751,"context_line":"\t\tconst bt_field *field, const bt_field_class *fc)"},{"line_number":752,"context_line":"{"},{"line_number":753,"context_line":"\tint ret \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"34e55c6d_5e9cc6a7","line":750,"range":{"start_line":750,"start_character":0,"end_line":750,"end_character":3},"in_reply_to":"173e2507_faa40218","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a28a6372832358d1689fff6fe61783eb9c14ed6d","unresolved":true,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"\tif (g_hash_table_lookup_extended(pretty-\u003eenum_bit_field_cache,"},{"line_number":758,"context_line":"\t\t(gpointer) fc, \u0026orig_key, \u0026value)) {"},{"line_number":759,"context_line":"\t\t// Return the value"},{"line_number":760,"context_line":"\t\treturn GPOINTER_TO_INT(value);"},{"line_number":761,"context_line":"\t}"},{"line_number":762,"context_line":"\t// Check if all mappings are powers of 2 or 0. If so, this enumeration"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b817b27b_007c5c44","line":759,"updated":"2020-02-13 21:44:00.000000000","message":"Here and elsewhere, use c-style comments:\n/* Single line. */\n\n/*\n * Moulti-line.\n */","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"\tif (g_hash_table_lookup_extended(pretty-\u003eenum_bit_field_cache,"},{"line_number":758,"context_line":"\t\t(gpointer) fc, \u0026orig_key, \u0026value)) {"},{"line_number":759,"context_line":"\t\t// Return the value"},{"line_number":760,"context_line":"\t\treturn GPOINTER_TO_INT(value);"},{"line_number":761,"context_line":"\t}"},{"line_number":762,"context_line":"\t// Check if all mappings are powers of 2 or 0. If so, this enumeration"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"35cd9997_897a0186","line":759,"in_reply_to":"b817b27b_007c5c44","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":757,"context_line":"\tif (g_hash_table_lookup_extended(pretty-\u003eenum_bit_field_cache,"},{"line_number":758,"context_line":"\t\t(gpointer) fc, \u0026orig_key, \u0026value)) {"},{"line_number":759,"context_line":"\t\t// Return the value"},{"line_number":760,"context_line":"\t\treturn GPOINTER_TO_INT(value);"},{"line_number":761,"context_line":"\t}"},{"line_number":762,"context_line":"\t// Check if all mappings are powers of 2 or 0. If so, this enumeration"},{"line_number":763,"context_line":"\t// is a flags enumeration"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"f019edc3_4e321b7a","line":760,"updated":"2020-02-13 22:17:56.000000000","message":"Single return point please.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":757,"context_line":"\tif (g_hash_table_lookup_extended(pretty-\u003eenum_bit_field_cache,"},{"line_number":758,"context_line":"\t\t(gpointer) fc, \u0026orig_key, \u0026value)) {"},{"line_number":759,"context_line":"\t\t// Return the value"},{"line_number":760,"context_line":"\t\treturn GPOINTER_TO_INT(value);"},{"line_number":761,"context_line":"\t}"},{"line_number":762,"context_line":"\t// Check if all mappings are powers of 2 or 0. If so, this enumeration"},{"line_number":763,"context_line":"\t// is a flags enumeration"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"2aecbfff_636a1b70","line":760,"in_reply_to":"f019edc3_4e321b7a","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":772,"context_line":"\t\tret \u003d 0;"},{"line_number":773,"context_line":"\t}"},{"line_number":774,"context_line":"\t// Save the result to a hash table"},{"line_number":775,"context_line":"\tg_hash_table_insert(pretty-\u003eenum_bit_field_cache,"},{"line_number":776,"context_line":"\t\t(gpointer) fc, GINT_TO_POINTER(ret));"},{"line_number":777,"context_line":"\treturn ret;"},{"line_number":778,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"2afc05f8_98914caf","line":775,"range":{"start_line":775,"start_character":1,"end_line":775,"end_character":20},"updated":"2020-02-13 22:17:56.000000000","message":"This is some advanced Babeltrace 2 concept, but here you\u0027re inserting a _borrowed_ field class reference in a private hash table. This field class still belongs to its trace class, ultimately, and once this trace class is destroyed then this pointer becomes invalid.\n\nYou don\u0027t want to keep a strong trace class or field class reference here because you will just accumulate/leak field classes.\n\nWhat you want to do is:\n\n* Keep another hash table mapping a trace class to an array of field class pointers, all borrowed.\n* For each trace class (check this for each event message), add a destruction listener (\u003chttps://babeltrace.org/docs/v2.0/libbabeltrace2/group__api-tir-trace-cls.html#gadf09f87b3c93be906469ba42683f57a5\u003e) to the event\u0027s trace class (if not already done). This destruction listener, for each associated field class in the hash table above, removes said field classes from your current hash table. Also remove the trace class entry in this second hash table. Also remove this destruction listener when it\u0027s called with \u003chttps://babeltrace.org/docs/v2.0/libbabeltrace2/group__api-tir-trace-cls.html#ga028e0a40ce8ffe294324b4dc418b394b\u003e.\n\nMake sure to remove all your trace class destruction listeners in the component\u0027s finalization method (destroy_pretty_data()).","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":772,"context_line":"\t\tret \u003d 0;"},{"line_number":773,"context_line":"\t}"},{"line_number":774,"context_line":"\t// Save the result to a hash table"},{"line_number":775,"context_line":"\tg_hash_table_insert(pretty-\u003eenum_bit_field_cache,"},{"line_number":776,"context_line":"\t\t(gpointer) fc, GINT_TO_POINTER(ret));"},{"line_number":777,"context_line":"\treturn ret;"},{"line_number":778,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"e00f1fc4_c41ba57b","line":775,"range":{"start_line":775,"start_character":1,"end_line":775,"end_character":20},"in_reply_to":"2afc05f8_98914caf","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":811,"context_line":"\tint ret \u003d 0;"},{"line_number":812,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" : container \u003d \");"},{"line_number":813,"context_line":"\tret \u003d print_integer(pretty, field);"},{"line_number":814,"context_line":"\tif (ret !\u003d 0) {"},{"line_number":815,"context_line":"\t\tgoto end;"},{"line_number":816,"context_line":"\t}"},{"line_number":817,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" )\");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"4fa63cd1_f0b17e34","line":814,"range":{"start_line":814,"start_character":5,"end_line":814,"end_character":13},"updated":"2020-02-13 22:17:56.000000000","message":"Just `ret` here; apply to other locations.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":811,"context_line":"\tint ret \u003d 0;"},{"line_number":812,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" : container \u003d \");"},{"line_number":813,"context_line":"\tret \u003d print_integer(pretty, field);"},{"line_number":814,"context_line":"\tif (ret !\u003d 0) {"},{"line_number":815,"context_line":"\t\tgoto end;"},{"line_number":816,"context_line":"\t}"},{"line_number":817,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" )\");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1242f5e7_49581a6d","line":814,"range":{"start_line":814,"start_character":5,"end_line":814,"end_character":13},"in_reply_to":"4fa63cd1_f0b17e34","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":826,"context_line":"\tint ret \u003d 0;"},{"line_number":827,"context_line":"\tuint64_t value \u003d bt_field_integer_unsigned_get_value(field);"},{"line_number":828,"context_line":"\tuint64_t i;"},{"line_number":829,"context_line":"\tuint8_t found \u003d 0;"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":832,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"22de4014_f93b37ed","line":829,"range":{"start_line":829,"start_character":9,"end_line":829,"end_character":14},"updated":"2020-02-13 22:17:56.000000000","message":"Rename to `at_least_one_flag`.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a28a6372832358d1689fff6fe61783eb9c14ed6d","unresolved":true,"context_lines":[{"line_number":826,"context_line":"\tint ret \u003d 0;"},{"line_number":827,"context_line":"\tuint64_t value \u003d bt_field_integer_unsigned_get_value(field);"},{"line_number":828,"context_line":"\tuint64_t i;"},{"line_number":829,"context_line":"\tuint8_t found \u003d 0;"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":832,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"2f2cfe8d_44a77308","line":829,"updated":"2020-02-13 21:44:00.000000000","message":"Use a \u0027bool\u0027 here (and other similar cases).","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":826,"context_line":"\tint ret \u003d 0;"},{"line_number":827,"context_line":"\tuint64_t value \u003d bt_field_integer_unsigned_get_value(field);"},{"line_number":828,"context_line":"\tuint64_t i;"},{"line_number":829,"context_line":"\tuint8_t found \u003d 0;"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":832,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"7830de46_3e8f9c94","line":829,"range":{"start_line":829,"start_character":9,"end_line":829,"end_character":14},"in_reply_to":"22de4014_f93b37ed","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":826,"context_line":"\tint ret \u003d 0;"},{"line_number":827,"context_line":"\tuint64_t value \u003d bt_field_integer_unsigned_get_value(field);"},{"line_number":828,"context_line":"\tuint64_t i;"},{"line_number":829,"context_line":"\tuint8_t found \u003d 0;"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":832,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"05e98f33_0c783728","line":829,"in_reply_to":"2f2cfe8d_44a77308","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":830,"context_line":""},{"line_number":831,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":832,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"},{"line_number":833,"context_line":"\t\tuint64_t j;"},{"line_number":834,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"},{"line_number":835,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_borrow_mapping_by_index_const(fc, i);"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"5c25faa5_af3cf4ef","line":833,"range":{"start_line":833,"start_character":11,"end_line":833,"end_character":12},"updated":"2020-02-13 22:17:56.000000000","message":"Use `range_i`.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":830,"context_line":""},{"line_number":831,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":832,"context_line":"\tfor (i \u003d 0; i \u003c bt_field_class_enumeration_get_mapping_count(fc); i++) {"},{"line_number":833,"context_line":"\t\tuint64_t j;"},{"line_number":834,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"},{"line_number":835,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_borrow_mapping_by_index_const(fc, i);"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"f4b6720d_393f981c","line":833,"range":{"start_line":833,"start_character":11,"end_line":833,"end_character":12},"in_reply_to":"5c25faa5_af3cf4ef","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a28a6372832358d1689fff6fe61783eb9c14ed6d","unresolved":true,"context_lines":[{"line_number":833,"context_line":"\t\tuint64_t j;"},{"line_number":834,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"},{"line_number":835,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_borrow_mapping_by_index_const(fc, i);"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"\t\tconst bt_integer_range_set_unsigned *ranges \u003d"},{"line_number":838,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_mapping_borrow_ranges_const(mapping);"},{"line_number":839,"context_line":"\t\tfor (j \u003d 0; j \u003c bt_integer_range_set_get_range_count("}],"source_content_type":"text/x-csrc","patch_set":5,"id":"df21ccdf_1257eaed","line":836,"updated":"2020-02-13 21:44:00.000000000","message":"Remove empty line.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":833,"context_line":"\t\tuint64_t j;"},{"line_number":834,"context_line":"\t\tconst struct bt_field_class_enumeration_unsigned_mapping *mapping \u003d"},{"line_number":835,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_borrow_mapping_by_index_const(fc, i);"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"\t\tconst bt_integer_range_set_unsigned *ranges \u003d"},{"line_number":838,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_mapping_borrow_ranges_const(mapping);"},{"line_number":839,"context_line":"\t\tfor (j \u003d 0; j \u003c bt_integer_range_set_get_range_count("}],"source_content_type":"text/x-csrc","patch_set":5,"id":"17bafb4b_4745b9ff","line":836,"in_reply_to":"df21ccdf_1257eaed","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a28a6372832358d1689fff6fe61783eb9c14ed6d","unresolved":true,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"\t\tconst bt_integer_range_set_unsigned *ranges \u003d"},{"line_number":838,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_mapping_borrow_ranges_const(mapping);"},{"line_number":839,"context_line":"\t\tfor (j \u003d 0; j \u003c bt_integer_range_set_get_range_count("},{"line_number":840,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_as_range_set_const(ranges)); j++) {"},{"line_number":841,"context_line":"\t\t\tconst bt_integer_range_unsigned *range \u003d"},{"line_number":842,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_borrow_range_by_index_const(ranges, j);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8dbe5901_b1ed19a8","line":839,"updated":"2020-02-13 21:44:00.000000000","message":"Precede by an empty white line.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"\t\tconst bt_integer_range_set_unsigned *ranges \u003d"},{"line_number":838,"context_line":"\t\t\tbt_field_class_enumeration_unsigned_mapping_borrow_ranges_const(mapping);"},{"line_number":839,"context_line":"\t\tfor (j \u003d 0; j \u003c bt_integer_range_set_get_range_count("},{"line_number":840,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_as_range_set_const(ranges)); j++) {"},{"line_number":841,"context_line":"\t\t\tconst bt_integer_range_unsigned *range \u003d"},{"line_number":842,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_borrow_range_by_index_const(ranges, j);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"ff8cfcdd_164c19dc","line":839,"in_reply_to":"8dbe5901_b1ed19a8","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":841,"context_line":"\t\t\tconst bt_integer_range_unsigned *range \u003d"},{"line_number":842,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_borrow_range_by_index_const(ranges, j);"},{"line_number":843,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":844,"context_line":"\t\t\tif ((value \u003d\u003d 0 \u0026\u0026 lower \u003d\u003d 0) || (value \u0026 lower) !\u003d 0) {"},{"line_number":845,"context_line":"\t\t\t\t// Flag is active"},{"line_number":846,"context_line":"\t\t\t\tif (found) {"},{"line_number":847,"context_line":"\t\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"c2fb6791_3af3290d","line":844,"range":{"start_line":844,"start_character":7,"end_line":844,"end_character":52},"updated":"2020-02-13 22:17:56.000000000","message":"What is this? Comment.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":841,"context_line":"\t\t\tconst bt_integer_range_unsigned *range \u003d"},{"line_number":842,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_borrow_range_by_index_const(ranges, j);"},{"line_number":843,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":844,"context_line":"\t\t\tif ((value \u003d\u003d 0 \u0026\u0026 lower \u003d\u003d 0) || (value \u0026 lower) !\u003d 0) {"},{"line_number":845,"context_line":"\t\t\t\t// Flag is active"},{"line_number":846,"context_line":"\t\t\t\tif (found) {"},{"line_number":847,"context_line":"\t\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"f9cadf6f_93fad99c","line":844,"range":{"start_line":844,"start_character":7,"end_line":844,"end_character":52},"in_reply_to":"4216f51a_702e696a","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"b0a1d947732baeebed1171591f71cf10fb7a14de","unresolved":true,"context_lines":[{"line_number":841,"context_line":"\t\t\tconst bt_integer_range_unsigned *range \u003d"},{"line_number":842,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_borrow_range_by_index_const(ranges, j);"},{"line_number":843,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":844,"context_line":"\t\t\tif ((value \u003d\u003d 0 \u0026\u0026 lower \u003d\u003d 0) || (value \u0026 lower) !\u003d 0) {"},{"line_number":845,"context_line":"\t\t\t\t// Flag is active"},{"line_number":846,"context_line":"\t\t\t\tif (found) {"},{"line_number":847,"context_line":"\t\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"4216f51a_702e696a","line":844,"range":{"start_line":844,"start_character":7,"end_line":844,"end_character":52},"in_reply_to":"c2fb6791_3af3290d","updated":"2020-02-14 14:48:38.000000000","message":"And this handles the 0 case for the value (first part before the ||)","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":862,"context_line":"\treturn ret;"},{"line_number":863,"context_line":"}"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"static"},{"line_number":866,"context_line":"int print_enum_flags_signed(struct pretty_component *pretty,"},{"line_number":867,"context_line":"\t\tconst bt_field *field, const bt_field_class *fc)"},{"line_number":868,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"cc7c5a6d_bed1175f","line":865,"updated":"2020-02-13 22:17:56.000000000","message":"Apply print_enum_flags_unsigned() comments.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":862,"context_line":"\treturn ret;"},{"line_number":863,"context_line":"}"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"static"},{"line_number":866,"context_line":"int print_enum_flags_signed(struct pretty_component *pretty,"},{"line_number":867,"context_line":"\t\tconst bt_field *field, const bt_field_class *fc)"},{"line_number":868,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8bd73626_64ad5acb","line":865,"in_reply_to":"cc7c5a6d_bed1175f","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"5078c54701878a7c9e26d45d13d999d621a2169d","unresolved":true,"context_lines":[{"line_number":911,"context_line":"{"},{"line_number":912,"context_line":"\tint ret \u003d 0;"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"\tprintf(\"Printing enum flags\");"},{"line_number":915,"context_line":"\tswitch (bt_field_get_class_type(field)) {"},{"line_number":916,"context_line":"\tcase BT_FIELD_CLASS_TYPE_UNSIGNED_ENUMERATION:"},{"line_number":917,"context_line":"\t\tret \u003d print_enum_flags_unsigned(pretty, field, fc);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"5bffa371_0024a26c","line":914,"updated":"2020-02-13 22:17:56.000000000","message":"Remove.","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e3be952b355550f75539cc214395ff00c23d07dc","unresolved":false,"context_lines":[{"line_number":911,"context_line":"{"},{"line_number":912,"context_line":"\tint ret \u003d 0;"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"\tprintf(\"Printing enum flags\");"},{"line_number":915,"context_line":"\tswitch (bt_field_get_class_type(field)) {"},{"line_number":916,"context_line":"\tcase BT_FIELD_CLASS_TYPE_UNSIGNED_ENUMERATION:"},{"line_number":917,"context_line":"\t\tret \u003d print_enum_flags_unsigned(pretty, field, fc);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"60a8fee6_189cf278","line":914,"in_reply_to":"5bffa371_0024a26c","updated":"2020-02-14 20:57:41.000000000","message":"Done","commit_id":"d011ae2b864de0b41e66ea925d56a83bf7459c96"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"58e66937385b5f8c26a935fc87dc90ca37c0e190","unresolved":true,"context_lines":[{"line_number":732,"context_line":"\tuint64_t *count)"},{"line_number":733,"context_line":"{"},{"line_number":734,"context_line":"\tuint64_t mapping_count \u003d bt_field_class_enumeration_get_mapping_count(fc);"},{"line_number":735,"context_line":"\tGPtrArray *labels \u003d g_ptr_array_new ();"},{"line_number":736,"context_line":"\tuint64_t i;"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"\t*count \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"211a86e4_2d03265e","line":735,"updated":"2020-02-27 17:03:29.000000000","message":"This leaks those ptr arrays. Would it be ok to assume that if this returns a count \u003e 0, then it has a GPtrArray (label_array would become GPtrArray*) and it\u0027s the caller responsibility to delete them?","commit_id":"c0829e85dbaa42fda385191441f2a9bf9fd2ab74"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"3152d5123f6f92e37350a29eda8696f88205774d","unresolved":true,"context_lines":[{"line_number":732,"context_line":"\tuint64_t *count)"},{"line_number":733,"context_line":"{"},{"line_number":734,"context_line":"\tuint64_t mapping_count \u003d bt_field_class_enumeration_get_mapping_count(fc);"},{"line_number":735,"context_line":"\tGPtrArray *labels \u003d g_ptr_array_new ();"},{"line_number":736,"context_line":"\tuint64_t i;"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"\t*count \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"e250e3a6_24e243c4","line":735,"in_reply_to":"211a86e4_2d03265e","updated":"2020-02-27 17:38:00.000000000","message":"I just skimmed the code quickly, but it looks to me like you are returning strings through this parameter.  So why does it have type `bt_field_class_enumeration_mapping_label_array *`?\n\nThen, one option is to accept a `GPtrArray **`, and return a newly allocated GPtrArray to the caller, which they\u0027ll have to free with g_ptr_array_free.\n\nThe other option (which I slightly prefer) is to accept a `const char ***label_array` (I hope I have the right number of *).  You can build the GPtrArray in this function, then do:\n\n *label_array \u003d g_ptr_array_free (labels, FALSE);\n\nThen, the caller needs to free that with g_free.  I slightly prefer this option, because the type of the parameter is more self-documenting than if it\u0027s `GPtrArray`.\n\nNote that I haven\u0027t checked the rest of the code in depth, so what I say might not make sense at all.","commit_id":"c0829e85dbaa42fda385191441f2a9bf9fd2ab74"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"9732f1f1c47348ef21c705dd94142f29fba12710","unresolved":false,"context_lines":[{"line_number":732,"context_line":"\tuint64_t *count)"},{"line_number":733,"context_line":"{"},{"line_number":734,"context_line":"\tuint64_t mapping_count \u003d bt_field_class_enumeration_get_mapping_count(fc);"},{"line_number":735,"context_line":"\tGPtrArray *labels \u003d g_ptr_array_new ();"},{"line_number":736,"context_line":"\tuint64_t i;"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"\t*count \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"118ab409_214c9b9b","line":735,"in_reply_to":"4a7b796d_6fb5e938","updated":"2020-08-06 18:24:27.000000000","message":"Done","commit_id":"c0829e85dbaa42fda385191441f2a9bf9fd2ab74"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ffee9ca18d5670eab671808f8e12c7c441a65906","unresolved":true,"context_lines":[{"line_number":732,"context_line":"\tuint64_t *count)"},{"line_number":733,"context_line":"{"},{"line_number":734,"context_line":"\tuint64_t mapping_count \u003d bt_field_class_enumeration_get_mapping_count(fc);"},{"line_number":735,"context_line":"\tGPtrArray *labels \u003d g_ptr_array_new ();"},{"line_number":736,"context_line":"\tuint64_t i;"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"\t*count \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"4a7b796d_6fb5e938","line":735,"in_reply_to":"6e92d1cf_92a926ed","updated":"2020-03-02 21:22:01.000000000","message":"Note that GPtrArray has an advantage that char********* doesn\u0027t (which I realized could be useful after reading the full patch), it can have a \"free\" function, which you set using g_ptr_array_new_with_free_func.  That \"free\" function knows can take care of freeing the char** arrays at each position.\n\nSo if you return a GPtrArray with an appropriate free function to the caller, the caller just needs to call g_ptr_array_free and that\u0027s it.  It also makes the error case easier, where you want to free the array.  That could be applicate to print_enum_unsigned_try_bit_flags/print_enum_signed_try_bit_flags.\n\nAnd about bt_field_class_enumeration_mapping_label_array, I think I had not realized initially that it was a just a char** behind the typedef.  So as long as the type makes sense, I\u0027m fine with it.","commit_id":"c0829e85dbaa42fda385191441f2a9bf9fd2ab74"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":true,"context_lines":[{"line_number":732,"context_line":"\tuint64_t *count)"},{"line_number":733,"context_line":"{"},{"line_number":734,"context_line":"\tuint64_t mapping_count \u003d bt_field_class_enumeration_get_mapping_count(fc);"},{"line_number":735,"context_line":"\tGPtrArray *labels \u003d g_ptr_array_new ();"},{"line_number":736,"context_line":"\tuint64_t i;"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"\t*count \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"6e92d1cf_92a926ed","line":735,"in_reply_to":"e250e3a6_24e243c4","updated":"2020-03-02 21:12:34.000000000","message":"indeed, i didn\u0027t read the doc for g_ptr_array_free but I think that\u0027s pretty much what i need. Thanks for pointing it out. I used bt_field_class_enumeration_mapping_label_array because it was originally copy-pasted from somewhere else, but char****** shoud be fine I think. The function that prints takes the bt_field_class_enumeration_mapping_label_array but I can work around that somehow.","commit_id":"c0829e85dbaa42fda385191441f2a9bf9fd2ab74"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"static"},{"line_number":686,"context_line":"int print_enum_value_label_unknown(struct pretty_component *pretty)"},{"line_number":687,"context_line":"{"},{"line_number":688,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":689,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_unknown);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"b54eba57_39768c77","line":686,"range":{"start_line":686,"start_character":0,"end_line":686,"end_character":3},"updated":"2020-03-02 19:01:58.000000000","message":"Return void if this can\u0027t fail.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"static"},{"line_number":686,"context_line":"int print_enum_value_label_unknown(struct pretty_component *pretty)"},{"line_number":687,"context_line":"{"},{"line_number":688,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":689,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_unknown);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"5b3cdeed_a1785557","line":686,"range":{"start_line":686,"start_character":0,"end_line":686,"end_character":3},"in_reply_to":"b54eba57_39768c77","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":687,"context_line":"{"},{"line_number":688,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":689,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_unknown);"},{"line_number":690,"context_line":"\t}"},{"line_number":691,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"\u003cunknown\u003e\");"},{"line_number":692,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":693,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_rst);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"67830236_326f01ae","line":690,"updated":"2020-03-02 19:01:58.000000000","message":"Empty line after the closing bracket.  Throughout the patch, please add empty lines after closing control structure (if/for/while) scopes.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":687,"context_line":"{"},{"line_number":688,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":689,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_unknown);"},{"line_number":690,"context_line":"\t}"},{"line_number":691,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"\u003cunknown\u003e\");"},{"line_number":692,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":693,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_rst);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"c881c0d8_bb66361d","line":690,"in_reply_to":"67830236_326f01ae","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":688,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":689,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_unknown);"},{"line_number":690,"context_line":"\t}"},{"line_number":691,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"\u003cunknown\u003e\");"},{"line_number":692,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":693,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_rst);"},{"line_number":694,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"285bdc76_5b7c131a","line":691,"updated":"2020-03-02 19:01:58.000000000","message":"I\u0027d also put an empty line after this line since it\u0027s not directly related to what comes after.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":688,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":689,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_unknown);"},{"line_number":690,"context_line":"\t}"},{"line_number":691,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"\u003cunknown\u003e\");"},{"line_number":692,"context_line":"\tif (pretty-\u003euse_colors) {"},{"line_number":693,"context_line":"\t\tbt_common_g_string_append(pretty-\u003estring, color_rst);"},{"line_number":694,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"1d975545_ad643c67","line":691,"in_reply_to":"285bdc76_5b7c131a","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":698,"context_line":"static"},{"line_number":699,"context_line":"int print_enum_value_label_array(struct pretty_component *pretty,"},{"line_number":700,"context_line":"\tuint64_t label_count,"},{"line_number":701,"context_line":"\tbt_field_class_enumeration_mapping_label_array label_array)"},{"line_number":702,"context_line":"{"},{"line_number":703,"context_line":"\tuint64_t i;"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"7b68528e_f59945af","line":701,"range":{"start_line":701,"start_character":1,"end_line":701,"end_character":47},"updated":"2020-03-02 19:01:58.000000000","message":"I\u0027d just use `const char **` here.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a69e0a036202a09431ffce45c539af95ddac2b90","unresolved":true,"context_lines":[{"line_number":698,"context_line":"static"},{"line_number":699,"context_line":"int print_enum_value_label_array(struct pretty_component *pretty,"},{"line_number":700,"context_line":"\tuint64_t label_count,"},{"line_number":701,"context_line":"\tbt_field_class_enumeration_mapping_label_array label_array)"},{"line_number":702,"context_line":"{"},{"line_number":703,"context_line":"\tuint64_t i;"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"8519b3bf_fe462f3d","line":701,"range":{"start_line":701,"start_character":1,"end_line":701,"end_character":47},"in_reply_to":"4137508c_7a7b30fb","updated":"2020-03-02 20:37:05.000000000","message":"Just personal preference: in my opinion, it just makes it less clear what the type is, and I have to go see the definition of the typedef to understand the code.  Not a big deal though.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":698,"context_line":"static"},{"line_number":699,"context_line":"int print_enum_value_label_array(struct pretty_component *pretty,"},{"line_number":700,"context_line":"\tuint64_t label_count,"},{"line_number":701,"context_line":"\tbt_field_class_enumeration_mapping_label_array label_array)"},{"line_number":702,"context_line":"{"},{"line_number":703,"context_line":"\tuint64_t i;"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"dfc4df56_8b3fda9c","line":701,"range":{"start_line":701,"start_character":1,"end_line":701,"end_character":47},"in_reply_to":"7b68528e_f59945af","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a45c2f5787d49b1d77a08ca4e3f00bdcae0179c4","unresolved":true,"context_lines":[{"line_number":698,"context_line":"static"},{"line_number":699,"context_line":"int print_enum_value_label_array(struct pretty_component *pretty,"},{"line_number":700,"context_line":"\tuint64_t label_count,"},{"line_number":701,"context_line":"\tbt_field_class_enumeration_mapping_label_array label_array)"},{"line_number":702,"context_line":"{"},{"line_number":703,"context_line":"\tuint64_t i;"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"4137508c_7a7b30fb","line":701,"range":{"start_line":701,"start_character":1,"end_line":701,"end_character":47},"in_reply_to":"7b68528e_f59945af","updated":"2020-03-02 20:29:22.000000000","message":"Why?","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":726,"context_line":"}"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"static"},{"line_number":729,"context_line":"int print_enum_unsigned_get_mapping_labels_for_value(const bt_field_class *fc,"},{"line_number":730,"context_line":"\tuint64_t value,"},{"line_number":731,"context_line":"\tconst char * const **label_array,"},{"line_number":732,"context_line":"\tuint64_t *count)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ba6352cb_d73ee588","line":729,"range":{"start_line":729,"start_character":0,"end_line":729,"end_character":3},"updated":"2020-03-02 19:01:58.000000000","message":"If this can\u0027t fail, it should return void.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a45c2f5787d49b1d77a08ca4e3f00bdcae0179c4","unresolved":true,"context_lines":[{"line_number":726,"context_line":"}"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"static"},{"line_number":729,"context_line":"int print_enum_unsigned_get_mapping_labels_for_value(const bt_field_class *fc,"},{"line_number":730,"context_line":"\tuint64_t value,"},{"line_number":731,"context_line":"\tconst char * const **label_array,"},{"line_number":732,"context_line":"\tuint64_t *count)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"f7a5a7cb_212b6c07","line":729,"range":{"start_line":729,"start_character":4,"end_line":729,"end_character":52},"updated":"2020-03-02 20:29:22.000000000","message":"This does not seem to print anything: remove the `print_` prefix.\n\nApply to other names of functions which do not print.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":726,"context_line":"}"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"static"},{"line_number":729,"context_line":"int print_enum_unsigned_get_mapping_labels_for_value(const bt_field_class *fc,"},{"line_number":730,"context_line":"\tuint64_t value,"},{"line_number":731,"context_line":"\tconst char * const **label_array,"},{"line_number":732,"context_line":"\tuint64_t *count)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"1300ae9a_c9c8beb6","line":729,"range":{"start_line":729,"start_character":0,"end_line":729,"end_character":3},"in_reply_to":"ba6352cb_d73ee588","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"9732f1f1c47348ef21c705dd94142f29fba12710","unresolved":false,"context_lines":[{"line_number":726,"context_line":"}"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"static"},{"line_number":729,"context_line":"int print_enum_unsigned_get_mapping_labels_for_value(const bt_field_class *fc,"},{"line_number":730,"context_line":"\tuint64_t value,"},{"line_number":731,"context_line":"\tconst char * const **label_array,"},{"line_number":732,"context_line":"\tuint64_t *count)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"aa300317_c56dcf2b","line":729,"range":{"start_line":729,"start_character":4,"end_line":729,"end_character":52},"in_reply_to":"f7a5a7cb_212b6c07","updated":"2020-08-06 18:24:27.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":762,"context_line":"\t\t\t\tbreak;"},{"line_number":763,"context_line":"\t\t\t}"},{"line_number":764,"context_line":"\t\t}"},{"line_number":765,"context_line":"\t}"},{"line_number":766,"context_line":"\tif (*count \u003d\u003d 0) {"},{"line_number":767,"context_line":"\t\tg_ptr_array_free(labels, true);"},{"line_number":768,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"b696bcb9_129a0994","line":765,"updated":"2020-03-02 19:01:58.000000000","message":"Empty line after this.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":762,"context_line":"\t\t\t\tbreak;"},{"line_number":763,"context_line":"\t\t\t}"},{"line_number":764,"context_line":"\t\t}"},{"line_number":765,"context_line":"\t}"},{"line_number":766,"context_line":"\tif (*count \u003d\u003d 0) {"},{"line_number":767,"context_line":"\t\tg_ptr_array_free(labels, true);"},{"line_number":768,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"e39b34c2_60ebac5f","line":765,"in_reply_to":"b696bcb9_129a0994","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":822,"context_line":"}"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"static"},{"line_number":825,"context_line":"int print_enum_signed_get_mapping_labels_for_value(const bt_field_class *fc,"},{"line_number":826,"context_line":"\tuint64_t value,"},{"line_number":827,"context_line":"\tconst char * const **label_array,"},{"line_number":828,"context_line":"\tuint64_t *count)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"94e16999_ee53e8aa","line":825,"range":{"start_line":825,"start_character":0,"end_line":825,"end_character":3},"updated":"2020-03-02 19:01:58.000000000","message":"If this can\u0027t fail, it should return void.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":822,"context_line":"}"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"static"},{"line_number":825,"context_line":"int print_enum_signed_get_mapping_labels_for_value(const bt_field_class *fc,"},{"line_number":826,"context_line":"\tuint64_t value,"},{"line_number":827,"context_line":"\tconst char * const **label_array,"},{"line_number":828,"context_line":"\tuint64_t *count)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"acb394c6_85dafc1f","line":825,"range":{"start_line":825,"start_character":0,"end_line":825,"end_character":3},"in_reply_to":"94e16999_ee53e8aa","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":839,"context_line":"\t\tconst bt_integer_range_set_signed *ranges \u003d"},{"line_number":840,"context_line":"\t\t\tbt_field_class_enumeration_signed_mapping_borrow_ranges_const(mapping);"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"\t\tfor (range_i \u003d 0; range_i \u003c bt_integer_range_set_get_range_count("},{"line_number":843,"context_line":"\t\t\t\tbt_integer_range_set_signed_as_range_set_const(ranges)); range_i++) {"},{"line_number":844,"context_line":"\t\t\tconst bt_integer_range_signed *range \u003d"},{"line_number":845,"context_line":"\t\t\t\tbt_integer_range_set_signed_borrow_range_by_index_const(ranges, range_i);"},{"line_number":846,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_signed_get_lower(range);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"eef602c7_d21a516c","line":843,"range":{"start_line":842,"start_character":30,"end_line":843,"end_character":59},"updated":"2020-03-02 19:01:58.000000000","message":"Put this in a local variable, it will make this line more readable and avoid calling the function multiple times unnecessarily.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":839,"context_line":"\t\tconst bt_integer_range_set_signed *ranges \u003d"},{"line_number":840,"context_line":"\t\t\tbt_field_class_enumeration_signed_mapping_borrow_ranges_const(mapping);"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"\t\tfor (range_i \u003d 0; range_i \u003c bt_integer_range_set_get_range_count("},{"line_number":843,"context_line":"\t\t\t\tbt_integer_range_set_signed_as_range_set_const(ranges)); range_i++) {"},{"line_number":844,"context_line":"\t\t\tconst bt_integer_range_signed *range \u003d"},{"line_number":845,"context_line":"\t\t\t\tbt_integer_range_set_signed_borrow_range_by_index_const(ranges, range_i);"},{"line_number":846,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_signed_get_lower(range);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2ab77a11_0016a960","line":843,"range":{"start_line":842,"start_character":30,"end_line":843,"end_character":59},"in_reply_to":"eef602c7_d21a516c","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":878,"context_line":"{"},{"line_number":879,"context_line":"\tint ret \u003d 0;"},{"line_number":880,"context_line":"\tuint64_t i;"},{"line_number":881,"context_line":"\tuint64_t value \u003d bt_field_integer_signed_get_value(field);"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"\t/*"},{"line_number":884,"context_line":"\t * Negative value, not a bit flag enum"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"d419e4a9_49b9e0d4","line":881,"range":{"start_line":881,"start_character":1,"end_line":881,"end_character":9},"updated":"2020-03-02 19:01:58.000000000","message":"int64_t","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":878,"context_line":"{"},{"line_number":879,"context_line":"\tint ret \u003d 0;"},{"line_number":880,"context_line":"\tuint64_t i;"},{"line_number":881,"context_line":"\tuint64_t value \u003d bt_field_integer_signed_get_value(field);"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"\t/*"},{"line_number":884,"context_line":"\t * Negative value, not a bit flag enum"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"587e603c_2f8d2e47","line":881,"range":{"start_line":881,"start_character":1,"end_line":881,"end_character":9},"in_reply_to":"d419e4a9_49b9e0d4","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":908,"context_line":"\t\t\t\t * field is not a bit flag field, print"},{"line_number":909,"context_line":"\t\t\t\t * unknown and return"},{"line_number":910,"context_line":"\t\t\t\t */"},{"line_number":911,"context_line":"\t\t\t\tprint_enum_value_label_unknown(pretty);"},{"line_number":912,"context_line":"\t\t\t\tret \u003d -1;"},{"line_number":913,"context_line":"\t\t\t\tgoto end;"},{"line_number":914,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"41f40ac2_f6d7558c","line":911,"updated":"2020-03-02 19:01:58.000000000","message":"I think the functions called \"try bit flags\" should print the value if the value can indeed be printed as bit flags, and print nothing otherwise (just return failure).\n\nThe function print_enum should then fall back on print_enum_value_label_unknown if print_enum_try_bit_flags says that the enum is not a bit flags enum.\n\nDon\u0027t hesitate to introduce an enum type for the return value, that the various functions could use, to make things clear.:\n\n enum PRINT_TRY_BIT_FLAGS_STATUS {\n \tPRINT_TRY_BIT_FLAGS_STATUS_OK \u003d 0,\n \tPRINT_TRY_BIT_FLAGS_STATUS_NOT_BIT_FLAGS \u003d 1,\n \tPRINT_TRY_BIT_FLAGS_STATUS_ERROR \u003d -1,\n };","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":908,"context_line":"\t\t\t\t * field is not a bit flag field, print"},{"line_number":909,"context_line":"\t\t\t\t * unknown and return"},{"line_number":910,"context_line":"\t\t\t\t */"},{"line_number":911,"context_line":"\t\t\t\tprint_enum_value_label_unknown(pretty);"},{"line_number":912,"context_line":"\t\t\t\tret \u003d -1;"},{"line_number":913,"context_line":"\t\t\t\tgoto end;"},{"line_number":914,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"80cdad71_69a65965","line":911,"in_reply_to":"41f40ac2_f6d7558c","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":921,"context_line":"}"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"static"},{"line_number":924,"context_line":"int print_enum_try_bit_flags(struct pretty_component *pretty,"},{"line_number":925,"context_line":"\t\tconst bt_field *field,"},{"line_number":926,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":927,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"4716d9fe_f0c37579","line":924,"updated":"2020-03-02 19:01:58.000000000","message":"For each new function, can you add a small comment above them to describe what they do, what they return, when they fail, etc?  No need to be as verbose as the API doc, just a quick comment for the future developers reading this code.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":921,"context_line":"}"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"static"},{"line_number":924,"context_line":"int print_enum_try_bit_flags(struct pretty_component *pretty,"},{"line_number":925,"context_line":"\t\tconst bt_field *field,"},{"line_number":926,"context_line":"\t\tconst bt_field_class *fc)"},{"line_number":927,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"f6f4f0c9_41d34668","line":924,"in_reply_to":"4716d9fe_f0c37579","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":928,"context_line":"\tint ret \u003d 0;"},{"line_number":929,"context_line":"\tuint64_t i;"},{"line_number":930,"context_line":"\tuint64_t int_range \u003d bt_field_class_integer_get_field_value_range(fc);"},{"line_number":931,"context_line":"\tuint64_t label_counts[int_range];"},{"line_number":932,"context_line":"\tconst char * const *label_arrays[int_range];"},{"line_number":933,"context_line":"\tbool first_label \u003d true;"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"2b3002f8_da294d28","line":931,"updated":"2020-03-02 19:01:58.000000000","message":"hmm, I would prefer if we didn\u0027t use VLAs.  I\u0027d suggest using:\n\n uint64_t label_counts[64];\n const char * const *label_arrays[64];\n\nAnd:\n\n BT_ASSERT(int_range \u003c\u003d 64);","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":928,"context_line":"\tint ret \u003d 0;"},{"line_number":929,"context_line":"\tuint64_t i;"},{"line_number":930,"context_line":"\tuint64_t int_range \u003d bt_field_class_integer_get_field_value_range(fc);"},{"line_number":931,"context_line":"\tuint64_t label_counts[int_range];"},{"line_number":932,"context_line":"\tconst char * const *label_arrays[int_range];"},{"line_number":933,"context_line":"\tbool first_label \u003d true;"},{"line_number":934,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"76212913_dc76b967","line":931,"in_reply_to":"2b3002f8_da294d28","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":952,"context_line":"\t}"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"\tif (ret) {"},{"line_number":955,"context_line":"\t\tret \u003d -1;"},{"line_number":956,"context_line":"\t\tgoto free_segments;"},{"line_number":957,"context_line":"\t}"},{"line_number":958,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"1e60daca_d6040090","line":955,"updated":"2020-03-02 19:01:58.000000000","message":"To stay consistent with the rest of BT, and therefore avoid confusion: if print_enum_unsigned_try_bit_flags/print_enum_signed_try_bit_flags fail, they should clean up after themselves, and not return allocated memory for the caller to free.\n\nAnd it should be documented that if they return 0, it is the responsibility of the caller to free what\u0027s returned through `label_arrays`.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":952,"context_line":"\t}"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"\tif (ret) {"},{"line_number":955,"context_line":"\t\tret \u003d -1;"},{"line_number":956,"context_line":"\t\tgoto free_segments;"},{"line_number":957,"context_line":"\t}"},{"line_number":958,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"d157b749_00011e7f","line":955,"in_reply_to":"1e60daca_d6040090","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":970,"context_line":"\t}"},{"line_number":971,"context_line":"\tgoto end;"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"free_segments:"},{"line_number":974,"context_line":"\tfor (i \u003d 0; i \u003c int_range; i++) {"},{"line_number":975,"context_line":"\t\tif (label_counts[i] \u003e 0) {"},{"line_number":976,"context_line":"\t\t\tg_free((gpointer) label_arrays[i]);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"62c8f603_8e832f65","line":973,"updated":"2020-03-02 19:01:58.000000000","message":"If the comment above is addressed, this part would be unnecessary (well, it would be moved as a cleanup in print_enum_{un,}signed_try_bit_flags in case of error).","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":970,"context_line":"\t}"},{"line_number":971,"context_line":"\tgoto end;"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"free_segments:"},{"line_number":974,"context_line":"\tfor (i \u003d 0; i \u003c int_range; i++) {"},{"line_number":975,"context_line":"\t\tif (label_counts[i] \u003e 0) {"},{"line_number":976,"context_line":"\t\t\tg_free((gpointer) label_arrays[i]);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"a060ce6a_e1f15a1b","line":973,"in_reply_to":"62c8f603_8e832f65","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":1017,"context_line":"\tif (label_count !\u003d 0) {"},{"line_number":1018,"context_line":"\t\tprint_enum_value_label_array(pretty, label_count, label_array);"},{"line_number":1019,"context_line":"\t\tgoto print_container;"},{"line_number":1020,"context_line":"\t}"},{"line_number":1021,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"29285683_d9f92dd8","line":1018,"updated":"2020-03-02 19:01:58.000000000","message":"Can you add a comment here about what this case covers and what we do in this case?  I presume something like:\n\n /* The numerical value matches some labels, print those. */","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":1017,"context_line":"\tif (label_count !\u003d 0) {"},{"line_number":1018,"context_line":"\t\tprint_enum_value_label_array(pretty, label_count, label_array);"},{"line_number":1019,"context_line":"\t\tgoto print_container;"},{"line_number":1020,"context_line":"\t}"},{"line_number":1021,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"0ab18fb3_52d6c99e","line":1018,"in_reply_to":"29285683_d9f92dd8","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":1016,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":1017,"context_line":"\tif (label_count !\u003d 0) {"},{"line_number":1018,"context_line":"\t\tprint_enum_value_label_array(pretty, label_count, label_array);"},{"line_number":1019,"context_line":"\t\tgoto print_container;"},{"line_number":1020,"context_line":"\t}"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"\tret \u003d print_enum_try_bit_flags(pretty, field, enumeration_field_class);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"a646e371_cc281f12","line":1019,"updated":"2020-03-02 19:01:58.000000000","message":"Can this be an if/else, instead of a goto?","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \"( \");"},{"line_number":1017,"context_line":"\tif (label_count !\u003d 0) {"},{"line_number":1018,"context_line":"\t\tprint_enum_value_label_array(pretty, label_count, label_array);"},{"line_number":1019,"context_line":"\t\tgoto print_container;"},{"line_number":1020,"context_line":"\t}"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"\tret \u003d print_enum_try_bit_flags(pretty, field, enumeration_field_class);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"995a832d_de481e58","line":1019,"in_reply_to":"a646e371_cc281f12","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"aec878b0aa807fdaa964e204598ed3f04fdceda2","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"\t\tgoto print_container;"},{"line_number":1020,"context_line":"\t}"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"\tret \u003d print_enum_try_bit_flags(pretty, field, enumeration_field_class);"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"print_container:"},{"line_number":1025,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" : container \u003d \");"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"6cf7d3ab_64ac01f3","line":1022,"updated":"2020-03-02 19:01:58.000000000","message":"And a comment in the else, like:\n\n /* The numerical value does not match any label, try to decompose and print it as bit flags. */\n\nThat `ret` is never checked.  If `print_enum_try_bit_flags` can indeed fail, there should be a\n\n if (ret !\u003d 0) {\n   goto end;\n }\n\nOtherwise, it should not return anything (return void).\n\nIt\u0027s not necessary to pass enumeration_field_class here, as the callee can get it using bt_field_borrow_class_const.  This means that the enumeration_field_class variable can be removed from this function.  Unlike how it\u0027s done currently in this function, it\u0027s not necessary to check for the return value of bt_field_borrow_class_const, as it can\u0027t fail.","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000011,"name":"Geneviève Bastien","email":"gbastien@versatic.net","username":"tahini","avatars":[{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/45c6ad95db0513ad2c5863991c23c25c.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"19f72996c6bbaeebf16a824723a411b0f5c9ad39","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"\t\tgoto print_container;"},{"line_number":1020,"context_line":"\t}"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"\tret \u003d print_enum_try_bit_flags(pretty, field, enumeration_field_class);"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"print_container:"},{"line_number":1025,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" : container \u003d \");"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"f11d4385_e8437560","line":1022,"in_reply_to":"6cf7d3ab_64ac01f3","updated":"2020-03-02 21:12:34.000000000","message":"Done","commit_id":"b0d1034f22de9513b9f9eca73cf1a5b66ce204d6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"603ec0c0f24f18dd432b8e6f3757218ba2634031","unresolved":true,"context_lines":[{"line_number":682,"context_line":"\tbt_common_g_string_append_c(pretty-\u003estring, \u0027\"\u0027);"},{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"/**"},{"line_number":686,"context_line":" * Print the unknown label"},{"line_number":687,"context_line":" */"},{"line_number":688,"context_line":"static"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"906e542a_ddce4fa3","line":685,"updated":"2020-03-02 21:26:34.000000000","message":"Just `/*` (same for other comments).","commit_id":"d5c91b2c98e0fb3f44e4fcea69a11c876531ce31"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"9732f1f1c47348ef21c705dd94142f29fba12710","unresolved":false,"context_lines":[{"line_number":682,"context_line":"\tbt_common_g_string_append_c(pretty-\u003estring, \u0027\"\u0027);"},{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"/**"},{"line_number":686,"context_line":" * Print the unknown label"},{"line_number":687,"context_line":" */"},{"line_number":688,"context_line":"static"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"7c5f25a1_a23246d9","line":685,"in_reply_to":"906e542a_ddce4fa3","updated":"2020-08-06 18:24:27.000000000","message":"Done","commit_id":"d5c91b2c98e0fb3f44e4fcea69a11c876531ce31"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"603ec0c0f24f18dd432b8e6f3757218ba2634031","unresolved":true,"context_lines":[{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"/**"},{"line_number":686,"context_line":" * Print the unknown label"},{"line_number":687,"context_line":" */"},{"line_number":688,"context_line":"static"},{"line_number":689,"context_line":"void print_enum_value_label_unknown(struct pretty_component *pretty)"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"9c1c90f4_d47a1e39","line":686,"range":{"start_line":686,"start_character":21,"end_line":686,"end_character":26},"updated":"2020-03-02 21:26:34.000000000","message":"Finish with a period (same for other comments).","commit_id":"d5c91b2c98e0fb3f44e4fcea69a11c876531ce31"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"9732f1f1c47348ef21c705dd94142f29fba12710","unresolved":false,"context_lines":[{"line_number":683,"context_line":"}"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"/**"},{"line_number":686,"context_line":" * Print the unknown label"},{"line_number":687,"context_line":" */"},{"line_number":688,"context_line":"static"},{"line_number":689,"context_line":"void print_enum_value_label_unknown(struct pretty_component *pretty)"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"46005866_0094bbd1","line":686,"range":{"start_line":686,"start_character":21,"end_line":686,"end_character":26},"in_reply_to":"9c1c90f4_d47a1e39","updated":"2020-08-06 18:24:27.000000000","message":"Done","commit_id":"d5c91b2c98e0fb3f44e4fcea69a11c876531ce31"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":664,"context_line":"\tbt_common_g_string_append_c(pretty-\u003estring, \u0027\"\u0027);"},{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"/**"},{"line_number":668,"context_line":" * Print the unknown label"},{"line_number":669,"context_line":" */"},{"line_number":670,"context_line":"static"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"786790f0_34047ebc","line":667,"range":{"start_line":667,"start_character":0,"end_line":667,"end_character":3},"updated":"2020-06-22 15:12:12.000000000","message":"I don\u0027t think we use `/**` for non-API comments, do we?","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"afbdbbb0eb2f74c509360801bb6e41d7c7eed1de","unresolved":false,"context_lines":[{"line_number":664,"context_line":"\tbt_common_g_string_append_c(pretty-\u003estring, \u0027\"\u0027);"},{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"/**"},{"line_number":668,"context_line":" * Print the unknown label"},{"line_number":669,"context_line":" */"},{"line_number":670,"context_line":"static"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"884a9a8c_74f4f11a","line":667,"range":{"start_line":667,"start_character":0,"end_line":667,"end_character":3},"in_reply_to":"786790f0_34047ebc","updated":"2020-06-22 19:12:23.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ae6924a13b2ffb6381b510c634abda479f8acee9","unresolved":true,"context_lines":[{"line_number":664,"context_line":"\tbt_common_g_string_append_c(pretty-\u003estring, \u0027\"\u0027);"},{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"/**"},{"line_number":668,"context_line":" * Print the unknown label"},{"line_number":669,"context_line":" */"},{"line_number":670,"context_line":"static"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"9623c081_b42501ef","line":667,"range":{"start_line":667,"start_character":0,"end_line":667,"end_character":3},"in_reply_to":"786790f0_34047ebc","updated":"2020-06-22 16:53:41.000000000","message":"We don\u0027t.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"/**"},{"line_number":668,"context_line":" * Print the unknown label"},{"line_number":669,"context_line":" */"},{"line_number":670,"context_line":"static"},{"line_number":671,"context_line":"void print_enum_value_label_unknown(struct pretty_component *pretty)"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"9ea1d295_e79fd68d","line":668,"updated":"2020-06-22 15:12:12.000000000","message":"Period at end of sentences?  It would apply to all other comments below.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"afbdbbb0eb2f74c509360801bb6e41d7c7eed1de","unresolved":false,"context_lines":[{"line_number":665,"context_line":"}"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"/**"},{"line_number":668,"context_line":" * Print the unknown label"},{"line_number":669,"context_line":" */"},{"line_number":670,"context_line":"static"},{"line_number":671,"context_line":"void print_enum_value_label_unknown(struct pretty_component *pretty)"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"1dd1096b_14b73290","line":668,"in_reply_to":"9ea1d295_e79fd68d","updated":"2020-06-22 19:12:23.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":721,"context_line":" */"},{"line_number":722,"context_line":"static"},{"line_number":723,"context_line":"void print_enum_value_bit_flag_label_arrays(struct pretty_component *pretty,"},{"line_number":724,"context_line":"\tuint64_t label_counts[])"},{"line_number":725,"context_line":"{"},{"line_number":726,"context_line":"\tuint64_t i;"},{"line_number":727,"context_line":"\tbool first_label \u003d true;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"be635374_b06870de","line":724,"range":{"start_line":724,"start_character":1,"end_line":724,"end_character":24},"updated":"2020-06-22 15:12:12.000000000","message":"Since the labels are kept in GPtrArrays, which keep track of their size, I wonder if we need this.  We\u0027d need to clear the GPtrArrays between each even, which isn\u0027t done right now I think.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"afbdbbb0eb2f74c509360801bb6e41d7c7eed1de","unresolved":false,"context_lines":[{"line_number":721,"context_line":" */"},{"line_number":722,"context_line":"static"},{"line_number":723,"context_line":"void print_enum_value_bit_flag_label_arrays(struct pretty_component *pretty,"},{"line_number":724,"context_line":"\tuint64_t label_counts[])"},{"line_number":725,"context_line":"{"},{"line_number":726,"context_line":"\tuint64_t i;"},{"line_number":727,"context_line":"\tbool first_label \u003d true;"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"3c580a04_f498c80b","line":724,"range":{"start_line":724,"start_character":1,"end_line":724,"end_character":24},"in_reply_to":"be635374_b06870de","updated":"2020-06-22 19:12:23.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":733,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":734,"context_line":"\t\t\t}"},{"line_number":735,"context_line":"\t\t\tprint_enum_value_label_array(pretty,"},{"line_number":736,"context_line":"\t\t\t\tlabel_counts[i], (void *) pretty-\u003eenum_bit_labels[i]-\u003epdata);"},{"line_number":737,"context_line":"\t\t\tfirst_label \u003d false;"},{"line_number":738,"context_line":"\t\t}"},{"line_number":739,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"3a7c52e0_9be49dc8","line":736,"range":{"start_line":736,"start_character":4,"end_line":736,"end_character":64},"updated":"2020-06-22 15:12:12.000000000","message":"You could pass the GPtrArray here, and not have to pass the size along with it.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"afbdbbb0eb2f74c509360801bb6e41d7c7eed1de","unresolved":false,"context_lines":[{"line_number":733,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":734,"context_line":"\t\t\t}"},{"line_number":735,"context_line":"\t\t\tprint_enum_value_label_array(pretty,"},{"line_number":736,"context_line":"\t\t\t\tlabel_counts[i], (void *) pretty-\u003eenum_bit_labels[i]-\u003epdata);"},{"line_number":737,"context_line":"\t\t\tfirst_label \u003d false;"},{"line_number":738,"context_line":"\t\t}"},{"line_number":739,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"dfc054d2_52698f31","line":736,"range":{"start_line":736,"start_character":4,"end_line":736,"end_character":64},"in_reply_to":"3a7c52e0_9be49dc8","updated":"2020-06-22 19:12:23.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"fab8bc330e9d42333d588a8fc4caa7711e051ddc","unresolved":false,"context_lines":[{"line_number":733,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":734,"context_line":"\t\t\t}"},{"line_number":735,"context_line":"\t\t\tprint_enum_value_label_array(pretty,"},{"line_number":736,"context_line":"\t\t\t\tlabel_counts[i], (void *) pretty-\u003eenum_bit_labels[i]-\u003epdata);"},{"line_number":737,"context_line":"\t\t\tfirst_label \u003d false;"},{"line_number":738,"context_line":"\t\t}"},{"line_number":739,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"0c01720e_24367345","line":736,"range":{"start_line":736,"start_character":4,"end_line":736,"end_character":64},"in_reply_to":"615a549a_509a888b","updated":"2020-06-22 19:54:52.000000000","message":"Ack","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e44dbbb14a6cd16588fd04ff2a915c1302906bf7","unresolved":true,"context_lines":[{"line_number":733,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":734,"context_line":"\t\t\t}"},{"line_number":735,"context_line":"\t\t\tprint_enum_value_label_array(pretty,"},{"line_number":736,"context_line":"\t\t\t\tlabel_counts[i], (void *) pretty-\u003eenum_bit_labels[i]-\u003epdata);"},{"line_number":737,"context_line":"\t\t\tfirst_label \u003d false;"},{"line_number":738,"context_line":"\t\t}"},{"line_number":739,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":24,"id":"615a549a_509a888b","line":736,"range":{"start_line":736,"start_character":4,"end_line":736,"end_character":64},"in_reply_to":"dfc054d2_52698f31","updated":"2020-06-22 19:17:20.000000000","message":"No, not \"Done\". We can\u0027t pass the GPtrArray directly because the `print_enum_value_label_array()` function is used in one other place (print.c:983) where the input is not a GPtrArray since it\u0027s the output of `bt_field_enumeration_signed_get_mapping_labels()`\"","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4c3e01e422c57e9e1e07dd22725c81f8b3558757","unresolved":true,"context_lines":[{"line_number":834,"context_line":"\t\t\t\tgoto end;"},{"line_number":835,"context_line":"\t\t\t}"},{"line_number":836,"context_line":"\t\t} else {"},{"line_number":837,"context_line":"\t\t\tlabel_counts[i] \u003d 0;"},{"line_number":838,"context_line":"\t\t}"},{"line_number":839,"context_line":"\t}"},{"line_number":840,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"0482a265_3cfe3c5a","line":837,"range":{"start_line":837,"start_character":3,"end_line":837,"end_character":23},"updated":"2020-06-22 15:12:12.000000000","message":"This is redundant with the initialization.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"afbdbbb0eb2f74c509360801bb6e41d7c7eed1de","unresolved":true,"context_lines":[{"line_number":834,"context_line":"\t\t\t\tgoto end;"},{"line_number":835,"context_line":"\t\t\t}"},{"line_number":836,"context_line":"\t\t} else {"},{"line_number":837,"context_line":"\t\t\tlabel_counts[i] \u003d 0;"},{"line_number":838,"context_line":"\t\t}"},{"line_number":839,"context_line":"\t}"},{"line_number":840,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"e62a5f91_05feeef6","line":837,"range":{"start_line":837,"start_character":3,"end_line":837,"end_character":23},"in_reply_to":"0482a265_3cfe3c5a","updated":"2020-06-22 19:12:23.000000000","message":"You\u0027re right. I ended up removing the `label_counts` array altogether because we already have the count in `GPtrArray::len`.","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"add5571714ce6566dfba8ab64be92fbef3b6a746","unresolved":false,"context_lines":[{"line_number":834,"context_line":"\t\t\t\tgoto end;"},{"line_number":835,"context_line":"\t\t\t}"},{"line_number":836,"context_line":"\t\t} else {"},{"line_number":837,"context_line":"\t\t\tlabel_counts[i] \u003d 0;"},{"line_number":838,"context_line":"\t\t}"},{"line_number":839,"context_line":"\t}"},{"line_number":840,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":24,"id":"d8a805c7_63bf563f","line":837,"range":{"start_line":837,"start_character":3,"end_line":837,"end_character":23},"in_reply_to":"e62a5f91_05feeef6","updated":"2020-06-22 19:18:22.000000000","message":"Done","commit_id":"001b27903d096bcf295c8085b40cbbad4f9341f7"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":687,"context_line":" */"},{"line_number":688,"context_line":"static"},{"line_number":689,"context_line":"void print_enum_value_label_array(struct pretty_component *pretty,"},{"line_number":690,"context_line":"\t\tuint64_t label_count, const char * const *label_array)"},{"line_number":691,"context_line":"{"},{"line_number":692,"context_line":"\tuint64_t i;"},{"line_number":693,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":26,"id":"cbe36ad0_aaa3f6a2","line":690,"range":{"start_line":690,"start_character":24,"end_line":690,"end_character":55},"updated":"2020-07-20 21:02:21.000000000","message":"As I wrote a few months ago, this is just `bt_field_class_enumeration_mapping_label_array`.","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":687,"context_line":" */"},{"line_number":688,"context_line":"static"},{"line_number":689,"context_line":"void print_enum_value_label_array(struct pretty_component *pretty,"},{"line_number":690,"context_line":"\t\tuint64_t label_count, const char * const *label_array)"},{"line_number":691,"context_line":"{"},{"line_number":692,"context_line":"\tuint64_t i;"},{"line_number":693,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":26,"id":"c62f830a_04c0f318","line":690,"range":{"start_line":690,"start_character":24,"end_line":690,"end_character":55},"in_reply_to":"cbe36ad0_aaa3f6a2","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":727,"context_line":"\t/* For each bit with a label count \u003e 0, print the labels. */"},{"line_number":728,"context_line":"\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":729,"context_line":"\t\tuint64_t label_count \u003d pretty-\u003eenum_bit_labels[i]-\u003elen;"},{"line_number":730,"context_line":"\t\tif (label_count \u003e 0) {"},{"line_number":731,"context_line":"\t\t\tif (!first_label) {"},{"line_number":732,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":733,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"9d7296fb_8c504068","line":730,"updated":"2020-07-20 21:02:21.000000000","message":"Newline above.","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":727,"context_line":"\t/* For each bit with a label count \u003e 0, print the labels. */"},{"line_number":728,"context_line":"\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":729,"context_line":"\t\tuint64_t label_count \u003d pretty-\u003eenum_bit_labels[i]-\u003elen;"},{"line_number":730,"context_line":"\t\tif (label_count \u003e 0) {"},{"line_number":731,"context_line":"\t\t\tif (!first_label) {"},{"line_number":732,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":733,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"550f061e_af19ccf9","line":730,"in_reply_to":"9d7296fb_8c504068","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":766,"context_line":"\t\t\tconst bt_integer_range_unsigned *range \u003d"},{"line_number":767,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_borrow_range_by_index_const(ranges, range_i);"},{"line_number":768,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":769,"context_line":"\t\t\tuint64_t higher \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"\t\t\t/*"},{"line_number":772,"context_line":"\t\t\t * Flag is active if this range represents a single value"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"eb91edfe_3ad48590","line":769,"range":{"start_line":769,"start_character":12,"end_line":769,"end_character":18},"updated":"2020-07-20 21:02:21.000000000","message":"`upper` (follow API\u0027s terminology).","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":766,"context_line":"\t\t\tconst bt_integer_range_unsigned *range \u003d"},{"line_number":767,"context_line":"\t\t\t\tbt_integer_range_set_unsigned_borrow_range_by_index_const(ranges, range_i);"},{"line_number":768,"context_line":"\t\t\tuint64_t lower \u003d bt_integer_range_unsigned_get_lower(range);"},{"line_number":769,"context_line":"\t\t\tuint64_t higher \u003d bt_integer_range_unsigned_get_upper(range);"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"\t\t\t/*"},{"line_number":772,"context_line":"\t\t\t * Flag is active if this range represents a single value"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"e209c33e_30ad3b06","line":769,"range":{"start_line":769,"start_character":12,"end_line":769,"end_character":18},"in_reply_to":"eb91edfe_3ad48590","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":774,"context_line":"\t\t\t * value to test against"},{"line_number":775,"context_line":"\t\t\t */"},{"line_number":776,"context_line":"\t\t\tif ((lower \u003d\u003d higher) \u0026\u0026 (lower \u003d\u003d value)) {"},{"line_number":777,"context_line":"\t\t\t\tg_ptr_array_add(labels, (void*) bt_field_class_enumeration_mapping_get_label("},{"line_number":778,"context_line":"\t\t\t\t\tbt_field_class_enumeration_unsigned_mapping_as_mapping_const(mapping)));"},{"line_number":779,"context_line":"\t\t\t\tbreak;"},{"line_number":780,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"36004938_25a640ee","line":777,"range":{"start_line":777,"start_character":29,"end_line":777,"end_character":34},"updated":"2020-07-20 21:02:21.000000000","message":"void *","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":774,"context_line":"\t\t\t * value to test against"},{"line_number":775,"context_line":"\t\t\t */"},{"line_number":776,"context_line":"\t\t\tif ((lower \u003d\u003d higher) \u0026\u0026 (lower \u003d\u003d value)) {"},{"line_number":777,"context_line":"\t\t\t\tg_ptr_array_add(labels, (void*) bt_field_class_enumeration_mapping_get_label("},{"line_number":778,"context_line":"\t\t\t\t\tbt_field_class_enumeration_unsigned_mapping_as_mapping_const(mapping)));"},{"line_number":779,"context_line":"\t\t\t\tbreak;"},{"line_number":780,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"6d80198a_9bbb94e8","line":777,"range":{"start_line":777,"start_character":29,"end_line":777,"end_character":34},"in_reply_to":"36004938_25a640ee","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":804,"context_line":"\t}"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":807,"context_line":"\t\tuint64_t bit_value \u003d 1ULL \u003c\u003c i;"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"\t\tif ((value \u0026 bit_value) !\u003d 0) {"},{"line_number":810,"context_line":"\t\t\tprint_enum_unsigned_get_mapping_labels_for_value("}],"source_content_type":"text/x-csrc","patch_set":26,"id":"8ea7efc0_832dd095","line":807,"range":{"start_line":807,"start_character":23,"end_line":807,"end_character":27},"updated":"2020-07-20 21:02:21.000000000","message":"UINT64_C(1)","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":804,"context_line":"\t}"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"\tfor (i \u003d 0; i \u003c ENUMERATION_MAX_BITFLAGS_NUMBER; i++) {"},{"line_number":807,"context_line":"\t\tuint64_t bit_value \u003d 1ULL \u003c\u003c i;"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"\t\tif ((value \u0026 bit_value) !\u003d 0) {"},{"line_number":810,"context_line":"\t\t\tprint_enum_unsigned_get_mapping_labels_for_value("}],"source_content_type":"text/x-csrc","patch_set":26,"id":"2aecae94_1f4c7337","line":807,"range":{"start_line":807,"start_character":23,"end_line":807,"end_character":27},"in_reply_to":"8ea7efc0_832dd095","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":990,"context_line":"\t} else if (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":991,"context_line":"\t\t/*"},{"line_number":992,"context_line":"\t\t * The numerical value does not match any label and the"},{"line_number":993,"context_line":"\t\t * component are initialized with, try to decompose it into bit"},{"line_number":994,"context_line":"\t\t * and print it as a bit flag enum if all bits have a"},{"line_number":995,"context_line":"\t\t * corresponding label."},{"line_number":996,"context_line":"\t\t */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"5190a784_20fa2cc5","line":993,"updated":"2020-07-20 21:02:21.000000000","message":"I don\u0027t get this sentence until the comma.\n\nAlso, \"into bits\".","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f7c4926cf00eb39aa0ad0cd2b4eda6fdd57e08df","unresolved":true,"context_lines":[{"line_number":990,"context_line":"\t} else if (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":991,"context_line":"\t\t/*"},{"line_number":992,"context_line":"\t\t * The numerical value does not match any label and the"},{"line_number":993,"context_line":"\t\t * component are initialized with, try to decompose it into bit"},{"line_number":994,"context_line":"\t\t * and print it as a bit flag enum if all bits have a"},{"line_number":995,"context_line":"\t\t * corresponding label."},{"line_number":996,"context_line":"\t\t */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"f8e42093_5a76a89a","line":993,"in_reply_to":"137912db_7547cef9","updated":"2020-07-21 17:10:37.000000000","message":"\u003e The numerical value does not match any label and the component are initialized with [...]\n\nWhat? 😄","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":990,"context_line":"\t} else if (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":991,"context_line":"\t\t/*"},{"line_number":992,"context_line":"\t\t * The numerical value does not match any label and the"},{"line_number":993,"context_line":"\t\t * component are initialized with, try to decompose it into bit"},{"line_number":994,"context_line":"\t\t * and print it as a bit flag enum if all bits have a"},{"line_number":995,"context_line":"\t\t * corresponding label."},{"line_number":996,"context_line":"\t\t */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"137912db_7547cef9","line":993,"in_reply_to":"5190a784_20fa2cc5","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"c6d5dc1c4021ef5628bc7c46993001b48d31725a","unresolved":false,"context_lines":[{"line_number":990,"context_line":"\t} else if (pretty-\u003eoptions.print_enum_flags) {"},{"line_number":991,"context_line":"\t\t/*"},{"line_number":992,"context_line":"\t\t * The numerical value does not match any label and the"},{"line_number":993,"context_line":"\t\t * component are initialized with, try to decompose it into bit"},{"line_number":994,"context_line":"\t\t * and print it as a bit flag enum if all bits have a"},{"line_number":995,"context_line":"\t\t * corresponding label."},{"line_number":996,"context_line":"\t\t */"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"cd663a75_6de0f143","line":993,"in_reply_to":"f8e42093_5a76a89a","updated":"2020-07-21 18:35:21.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c79e992f86cb2f3df930be6293983fee7121de10","unresolved":true,"context_lines":[{"line_number":991,"context_line":"\t\t/*"},{"line_number":992,"context_line":"\t\t * The numerical value does not match any label and the"},{"line_number":993,"context_line":"\t\t * component are initialized with, try to decompose it into bit"},{"line_number":994,"context_line":"\t\t * and print it as a bit flag enum if all bits have a"},{"line_number":995,"context_line":"\t\t * corresponding label."},{"line_number":996,"context_line":"\t\t */"},{"line_number":997,"context_line":"\t\tprint_enum_try_bit_flags(pretty, field);"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"8cfdd864_5e40d339","line":994,"updated":"2020-07-20 21:02:21.000000000","message":"\"have at least one\" perhaps?","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"0f2b01057fff3275a0e64f752982934e74283ab1","unresolved":false,"context_lines":[{"line_number":991,"context_line":"\t\t/*"},{"line_number":992,"context_line":"\t\t * The numerical value does not match any label and the"},{"line_number":993,"context_line":"\t\t * component are initialized with, try to decompose it into bit"},{"line_number":994,"context_line":"\t\t * and print it as a bit flag enum if all bits have a"},{"line_number":995,"context_line":"\t\t * corresponding label."},{"line_number":996,"context_line":"\t\t */"},{"line_number":997,"context_line":"\t\tprint_enum_try_bit_flags(pretty, field);"}],"source_content_type":"text/x-csrc","patch_set":26,"id":"8dfdede4_ee6fec11","line":994,"in_reply_to":"8cfdd864_5e40d339","updated":"2020-07-21 15:56:59.000000000","message":"Done","commit_id":"3c660090e131bc5537fa24f538953164e4c03175"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":"\t\tif (label_count \u003e 0) {"},{"line_number":733,"context_line":"\t\t\tif (!first_label) {"},{"line_number":734,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":735,"context_line":"\t\t\t}"},{"line_number":736,"context_line":"\t\t\tprint_enum_value_label_array(pretty, label_count,"},{"line_number":737,"context_line":"\t\t\t\t(void *) pretty-\u003eenum_bit_labels[i]-\u003epdata);"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"1af526cc_8b59e8c2","line":734,"updated":"2020-08-04 16:59:03.000000000","message":"It seems strange to me to \u0027OR\u0027 identical values when multiple matches are associated to a bit value. Normally, the component separates multiple matches using a \u0027,\u0027.\n\nFor instance, given the following enum values\n\n  enum {\n    RIVARD \u003d 1,\n    BELANGER \u003d 2,\n    BOUCHER \u003d 2,\n    BEDARD \u003d 2,\n    BIGRAS \u003d 2,\n    DUBOIS \u003d 4,\n  };\n\n\nCould the following output be preferable?\n  { enum_field \u003d ( \"RIVARD\" | (\"BELANGER\", \"BOUCHER\", \"BEDARD\", \"BIGRAS\") | \"DUBOIS\" : container \u003d ... ) }","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":true,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":"\t\tif (label_count \u003e 0) {"},{"line_number":733,"context_line":"\t\t\tif (!first_label) {"},{"line_number":734,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":735,"context_line":"\t\t\t}"},{"line_number":736,"context_line":"\t\t\tprint_enum_value_label_array(pretty, label_count,"},{"line_number":737,"context_line":"\t\t\t\t(void *) pretty-\u003eenum_bit_labels[i]-\u003epdata);"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"adfda472_55fee226","line":734,"in_reply_to":"1af526cc_8b59e8c2","updated":"2020-08-04 21:14:22.000000000","message":"This is really similar to what this PS implements. Given the following enum and the value 3:\nenum {\n   bit0 \u003d 1,\n   bit0bis \u003d 1,\n   bit0 \u003d 2,\n}\n\npretty will print this:\n   with_enum: { enum_field \u003d ( { \"bit0\", \"bit0bis\" } | \"bit1\" : container \u003d 3 ) }\n\nI just added a test case testing this specifically.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f306e25a65a5402ba01ec1b31534068362a698c9","unresolved":false,"context_lines":[{"line_number":731,"context_line":""},{"line_number":732,"context_line":"\t\tif (label_count \u003e 0) {"},{"line_number":733,"context_line":"\t\t\tif (!first_label) {"},{"line_number":734,"context_line":"\t\t\t\tbt_common_g_string_append(pretty-\u003estring, \" | \");"},{"line_number":735,"context_line":"\t\t\t}"},{"line_number":736,"context_line":"\t\t\tprint_enum_value_label_array(pretty, label_count,"},{"line_number":737,"context_line":"\t\t\t\t(void *) pretty-\u003eenum_bit_labels[i]-\u003epdata);"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"1f70102b_92646c94","line":734,"in_reply_to":"adfda472_55fee226","updated":"2020-08-04 23:03:06.000000000","message":"Ah great, I missed that in print_enum_value_label_array(). Thanks 😊","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":773,"context_line":"\t\t\t/*"},{"line_number":774,"context_line":"\t\t\t * Flag is active if this range represents a single value"},{"line_number":775,"context_line":"\t\t\t * (lower \u003d\u003d higher) and the lower is the same as the bit"},{"line_number":776,"context_line":"\t\t\t * value to test against"},{"line_number":777,"context_line":"\t\t\t */"},{"line_number":778,"context_line":"\t\t\tif ((lower \u003d\u003d upper) \u0026\u0026 (lower \u003d\u003d value)) {"},{"line_number":779,"context_line":"\t\t\t\tg_ptr_array_add(labels, (void *) bt_field_class_enumeration_mapping_get_label("}],"source_content_type":"text/x-csrc","patch_set":29,"id":"7b4b6d5f_196bad42","line":776,"updated":"2020-08-04 16:59:03.000000000","message":"\u0027.\u0027 at the end.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":false,"context_lines":[{"line_number":773,"context_line":"\t\t\t/*"},{"line_number":774,"context_line":"\t\t\t * Flag is active if this range represents a single value"},{"line_number":775,"context_line":"\t\t\t * (lower \u003d\u003d higher) and the lower is the same as the bit"},{"line_number":776,"context_line":"\t\t\t * value to test against"},{"line_number":777,"context_line":"\t\t\t */"},{"line_number":778,"context_line":"\t\t\tif ((lower \u003d\u003d upper) \u0026\u0026 (lower \u003d\u003d value)) {"},{"line_number":779,"context_line":"\t\t\t\tg_ptr_array_add(labels, (void *) bt_field_class_enumeration_mapping_get_label("}],"source_content_type":"text/x-csrc","patch_set":29,"id":"f4ee2760_c726035e","line":776,"in_reply_to":"7b4b6d5f_196bad42","updated":"2020-08-04 21:14:22.000000000","message":"Done","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":863,"context_line":"\t\t\t/*"},{"line_number":864,"context_line":"\t\t\t * Flag is active if this range represents a single value"},{"line_number":865,"context_line":"\t\t\t * (lower \u003d\u003d higher) and the lower is the same as the bit"},{"line_number":866,"context_line":"\t\t\t * value to test against"},{"line_number":867,"context_line":"\t\t\t */"},{"line_number":868,"context_line":"\t\t\tif ((lower \u003d\u003d higher) \u0026\u0026 (lower \u003d\u003d value)) {"},{"line_number":869,"context_line":"\t\t\t\tg_ptr_array_add(labels, (void*) bt_field_class_enumeration_mapping_get_label("}],"source_content_type":"text/x-csrc","patch_set":29,"id":"16875321_1dfd5f8c","line":866,"updated":"2020-08-04 16:59:03.000000000","message":"\u0027.\u0027 at the end.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":false,"context_lines":[{"line_number":863,"context_line":"\t\t\t/*"},{"line_number":864,"context_line":"\t\t\t * Flag is active if this range represents a single value"},{"line_number":865,"context_line":"\t\t\t * (lower \u003d\u003d higher) and the lower is the same as the bit"},{"line_number":866,"context_line":"\t\t\t * value to test against"},{"line_number":867,"context_line":"\t\t\t */"},{"line_number":868,"context_line":"\t\t\tif ((lower \u003d\u003d higher) \u0026\u0026 (lower \u003d\u003d value)) {"},{"line_number":869,"context_line":"\t\t\t\tg_ptr_array_add(labels, (void*) bt_field_class_enumeration_mapping_get_label("}],"source_content_type":"text/x-csrc","patch_set":29,"id":"54d159e7_cdc9e15f","line":866,"in_reply_to":"16875321_1dfd5f8c","updated":"2020-08-04 21:14:22.000000000","message":"Done","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":879,"context_line":" * try to find a corresponding label."},{"line_number":880,"context_line":" *"},{"line_number":881,"context_line":" * If any bit set does not have a corresponding label, then it prints"},{"line_number":882,"context_line":" * an unknown value, otherwise, it prints the labels, separated by \u0027|\u0027"},{"line_number":883,"context_line":" */"},{"line_number":884,"context_line":"static"},{"line_number":885,"context_line":"void print_enum_signed_try_bit_flags(struct pretty_component *pretty,"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"4ea168d0_f4580c9e","line":882,"updated":"2020-08-04 16:59:03.000000000","message":"\u0027.\u0027 at the end.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":false,"context_lines":[{"line_number":879,"context_line":" * try to find a corresponding label."},{"line_number":880,"context_line":" *"},{"line_number":881,"context_line":" * If any bit set does not have a corresponding label, then it prints"},{"line_number":882,"context_line":" * an unknown value, otherwise, it prints the labels, separated by \u0027|\u0027"},{"line_number":883,"context_line":" */"},{"line_number":884,"context_line":"static"},{"line_number":885,"context_line":"void print_enum_signed_try_bit_flags(struct pretty_component *pretty,"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"5bb1acee_db609415","line":882,"in_reply_to":"4ea168d0_f4580c9e","updated":"2020-08-04 21:14:22.000000000","message":"Done","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":909,"context_line":"\t\t\t\t/*"},{"line_number":910,"context_line":"\t\t\t\t * This bit has no matching label, so this"},{"line_number":911,"context_line":"\t\t\t\t * field is not a bit flag field, print"},{"line_number":912,"context_line":"\t\t\t\t * unknown and return"},{"line_number":913,"context_line":"\t\t\t\t */"},{"line_number":914,"context_line":"\t\t\t\tprint_enum_value_label_unknown(pretty);"},{"line_number":915,"context_line":"\t\t\t\tgoto end;"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"7d21e45c_ffab01fd","line":912,"updated":"2020-08-04 16:59:03.000000000","message":"\u0027.\u0027 at the end.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":false,"context_lines":[{"line_number":909,"context_line":"\t\t\t\t/*"},{"line_number":910,"context_line":"\t\t\t\t * This bit has no matching label, so this"},{"line_number":911,"context_line":"\t\t\t\t * field is not a bit flag field, print"},{"line_number":912,"context_line":"\t\t\t\t * unknown and return"},{"line_number":913,"context_line":"\t\t\t\t */"},{"line_number":914,"context_line":"\t\t\t\tprint_enum_value_label_unknown(pretty);"},{"line_number":915,"context_line":"\t\t\t\tgoto end;"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"c488fd7c_201d2d05","line":912,"in_reply_to":"7d21e45c_ffab01fd","updated":"2020-08-04 21:14:22.000000000","message":"Done","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":911,"context_line":"\t\t\t\t * field is not a bit flag field, print"},{"line_number":912,"context_line":"\t\t\t\t * unknown and return"},{"line_number":913,"context_line":"\t\t\t\t */"},{"line_number":914,"context_line":"\t\t\t\tprint_enum_value_label_unknown(pretty);"},{"line_number":915,"context_line":"\t\t\t\tgoto end;"},{"line_number":916,"context_line":"\t\t\t}"},{"line_number":917,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"2df6c944_60dca511","line":914,"updated":"2020-08-04 16:59:03.000000000","message":"Say two bits yield unknown values, this seems like it would result in the following string:\n  \u003cunknown\u003e\u003cunknown\u003e\n\nis this intended?\n\nShould the \u003cunknown\u003e be added to the label array to result in\n  FOO | BAR | \u003cunknown\u003e | \u003cunknown\u003e | LOLZ\n\n?","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":true,"context_lines":[{"line_number":911,"context_line":"\t\t\t\t * field is not a bit flag field, print"},{"line_number":912,"context_line":"\t\t\t\t * unknown and return"},{"line_number":913,"context_line":"\t\t\t\t */"},{"line_number":914,"context_line":"\t\t\t\tprint_enum_value_label_unknown(pretty);"},{"line_number":915,"context_line":"\t\t\t\tgoto end;"},{"line_number":916,"context_line":"\t\t\t}"},{"line_number":917,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"4458381e_01ba335a","line":914,"in_reply_to":"2df6c944_60dca511","updated":"2020-08-04 21:14:22.000000000","message":"If any of the bits has no mapping, then the value is printed as unknown. So this should not happen.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"f306e25a65a5402ba01ec1b31534068362a698c9","unresolved":false,"context_lines":[{"line_number":911,"context_line":"\t\t\t\t * field is not a bit flag field, print"},{"line_number":912,"context_line":"\t\t\t\t * unknown and return"},{"line_number":913,"context_line":"\t\t\t\t */"},{"line_number":914,"context_line":"\t\t\t\tprint_enum_value_label_unknown(pretty);"},{"line_number":915,"context_line":"\t\t\t\tgoto end;"},{"line_number":916,"context_line":"\t\t\t}"},{"line_number":917,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"62fb1e26_b456f221","line":914,"in_reply_to":"4458381e_01ba335a","updated":"2020-08-04 23:03:06.000000000","message":"You are right, I missed the `goto end` right after. My bad!","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":946,"context_line":"\t\tg_ptr_array_set_size(pretty-\u003eenum_bit_labels[i], 0);"},{"line_number":947,"context_line":"\t}"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"\t/* Get the mapping labels for the bit value */"},{"line_number":950,"context_line":"\tswitch (bt_field_class_get_type(fc)) {"},{"line_number":951,"context_line":"\tcase BT_FIELD_CLASS_TYPE_UNSIGNED_ENUMERATION:"},{"line_number":952,"context_line":"\t\tprint_enum_unsigned_try_bit_flags(pretty, field);"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"5a82fd29_a5cdbc5a","line":949,"updated":"2020-08-04 16:59:03.000000000","message":"\u0027.\u0027 at the end.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":false,"context_lines":[{"line_number":946,"context_line":"\t\tg_ptr_array_set_size(pretty-\u003eenum_bit_labels[i], 0);"},{"line_number":947,"context_line":"\t}"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"\t/* Get the mapping labels for the bit value */"},{"line_number":950,"context_line":"\tswitch (bt_field_class_get_type(fc)) {"},{"line_number":951,"context_line":"\tcase BT_FIELD_CLASS_TYPE_UNSIGNED_ENUMERATION:"},{"line_number":952,"context_line":"\t\tprint_enum_unsigned_try_bit_flags(pretty, field);"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"17245df0_e3ea0c8a","line":949,"in_reply_to":"5a82fd29_a5cdbc5a","updated":"2020-08-04 21:14:22.000000000","message":"Done","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"a1ad9d7be886b25cc925dae0a9b31cbcb45265e2","unresolved":true,"context_lines":[{"line_number":1007,"context_line":"\t\t}"},{"line_number":1008,"context_line":"\t}"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"\t/* Print the actual value of the enum */"},{"line_number":1011,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" : container \u003d \");"},{"line_number":1012,"context_line":"\tret \u003d print_integer(pretty, field);"},{"line_number":1013,"context_line":"\tif (ret !\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"35daf091_70987580","line":1010,"updated":"2020-08-04 16:59:03.000000000","message":"\u0027.\u0027 at the end.","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"},{"author":{"_account_id":1000004,"name":"Francis Deslauriers","email":"francis.deslauriers@efficios.com","username":"frdeso","avatars":[{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2117a78c2e91edc19dd421827dc2362e.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"a93bbaf2fa345f73d1d56ac708e445c718b75c12","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"\t\t}"},{"line_number":1008,"context_line":"\t}"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"\t/* Print the actual value of the enum */"},{"line_number":1011,"context_line":"\tbt_common_g_string_append(pretty-\u003estring, \" : container \u003d \");"},{"line_number":1012,"context_line":"\tret \u003d print_integer(pretty, field);"},{"line_number":1013,"context_line":"\tif (ret !\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":29,"id":"4f67160d_36d46b83","line":1010,"in_reply_to":"35daf091_70987580","updated":"2020-08-04 21:14:22.000000000","message":"Done","commit_id":"c6b87a6825b1ee3d003cf8080f2e38ec54ac7446"}]}