)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"3b63cb5a4ee0e5a6f0f1351d0e91706f3f35cdb4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"item-seq-iter: fix _mBeginDefClkVal to be set only in packet context scope"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes https://bugs.lttng.org/issues/1389."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"What the traces from the bug report have in common is that the clock-mapped"},{"line_number":12,"context_line":"timestamp exists in the event header but NOT in the packet context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b262358a_8d4fdcf4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":41},"updated":"2026-04-08 13:33:28.000000000","message":"Use a trailer (before `Change-Id:`) as such instead:\n\n    Resolves: P-1389","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"},{"author":{"_account_id":1000103,"name":"Adam Greloch","email":"adam.greloch@phoenix-rtos.com","username":"adamgreloch","avatars":[{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0dc57be71b92a7c73035e6f9ee2a7e8ac18341e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"item-seq-iter: fix _mBeginDefClkVal to be set only in packet context scope"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes https://bugs.lttng.org/issues/1389."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"What the traces from the bug report have in common is that the clock-mapped"},{"line_number":12,"context_line":"timestamp exists in the event header but NOT in the packet context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3859700d_ca31b0fd","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":41},"in_reply_to":"b262358a_8d4fdcf4","updated":"2026-04-08 14:14:45.000000000","message":"Done","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"d5b45c763a263f6dffcd4e5c2feddcec9c4aa573","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20438060_3c12df34","updated":"2026-04-07 16:35:26.000000000","message":"This approach seems to work, but it means one additional check per event record (typical cases with event record headers containing a timestamp).\n\nI prefer keeping the current approach, but instead of checking `_mItems.dataStreamInfo._mCls-\u003edefClkCls()`, check a new flag `_mItems.dataStreamInfo._mCls-\u003epktCtxFcHasDefClkTsRole()`.\n\nSet that flag in `DataStreamCls::DataStreamCls()`, with something like `fcContainsUIntFcWithRole()` which would need to become available (move to its own header to reuse).\n\nDoes that sound reasonable?","commit_id":"41298539028cde78182cc127a2e1a4a6fbf63043"},{"author":{"_account_id":1000103,"name":"Adam Greloch","email":"adam.greloch@phoenix-rtos.com","username":"adamgreloch","avatars":[{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"c7578242324b7ea29f74fb2ef4ff545f215f69ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee99e4f0_6cafe2c1","in_reply_to":"00b205d2_71b5ee6a","updated":"2026-04-08 14:15:36.000000000","message":"Done","commit_id":"41298539028cde78182cc127a2e1a4a6fbf63043"},{"author":{"_account_id":1000103,"name":"Adam Greloch","email":"adam.greloch@phoenix-rtos.com","username":"adamgreloch","avatars":[{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"fdc5fb8015e246fe9d74fd3b050ccba494844c8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00b205d2_71b5ee6a","in_reply_to":"20438060_3c12df34","updated":"2026-04-08 08:50:50.000000000","message":"Thanks for the suggestion. Applied","commit_id":"41298539028cde78182cc127a2e1a4a6fbf63043"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"3b63cb5a4ee0e5a6f0f1351d0e91706f3f35cdb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c97caa5c_75019599","updated":"2026-04-08 13:33:28.000000000","message":"You didn\u0027t change the commit message; I guess it\u0027s still correct as is?","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"3181bb2f47f34fc0145f06f8531236685ba1c3f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c83b6c3_79123702","in_reply_to":"6f282f3c_1f30ac83","updated":"2026-04-08 14:17:18.000000000","message":"Acknowledged","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"},{"author":{"_account_id":1000103,"name":"Adam Greloch","email":"adam.greloch@phoenix-rtos.com","username":"adamgreloch","avatars":[{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0dc57be71b92a7c73035e6f9ee2a7e8ac18341e7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f282f3c_1f30ac83","in_reply_to":"c97caa5c_75019599","updated":"2026-04-08 14:14:45.000000000","message":"Yes, should stay correct","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4641ae477fbbf3a50f84fb3a4584516d826d100e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fde39b9a_d8d83247","updated":"2026-04-08 18:42:26.000000000","message":"Thanks for the fix Adam!","commit_id":"502ef2f722a27617df4b22746fdf65b06c06cbe8"}],"src/plugins/ctf/common/metadata/ctf-ir.hpp":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"3b63cb5a4ee0e5a6f0f1351d0e91706f3f35cdb4","unresolved":true,"context_lines":[{"line_number":4278,"context_line":"        return _mDefClkCls.get();"},{"line_number":4279,"context_line":"    }"},{"line_number":4280,"context_line":""},{"line_number":4281,"context_line":"    /*"},{"line_number":4282,"context_line":"     * Flag denoting whether the packet context field class contains"},{"line_number":4283,"context_line":"     * a DefClkTsRole role field."},{"line_number":4284,"context_line":"     */"},{"line_number":4285,"context_line":"    bool pktCtxFcHasDefClkTsRole() const noexcept"},{"line_number":4286,"context_line":"    {"},{"line_number":4287,"context_line":"        return _mPktCtxFcHasDefClkTsRole;"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"c1fc8d94_bc06c09b","line":4284,"range":{"start_line":4281,"start_character":0,"end_line":4284,"end_character":7},"updated":"2026-04-08 13:33:28.000000000","message":"```suggestion\n    /*\n     * Whether or not the packet context field class has\n     * a `UIntFieldRole::DefClkTs` role.\n     */\n```","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"},{"author":{"_account_id":1000103,"name":"Adam Greloch","email":"adam.greloch@phoenix-rtos.com","username":"adamgreloch","avatars":[{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0dc57be71b92a7c73035e6f9ee2a7e8ac18341e7","unresolved":false,"context_lines":[{"line_number":4278,"context_line":"        return _mDefClkCls.get();"},{"line_number":4279,"context_line":"    }"},{"line_number":4280,"context_line":""},{"line_number":4281,"context_line":"    /*"},{"line_number":4282,"context_line":"     * Flag denoting whether the packet context field class contains"},{"line_number":4283,"context_line":"     * a DefClkTsRole role field."},{"line_number":4284,"context_line":"     */"},{"line_number":4285,"context_line":"    bool pktCtxFcHasDefClkTsRole() const noexcept"},{"line_number":4286,"context_line":"    {"},{"line_number":4287,"context_line":"        return _mPktCtxFcHasDefClkTsRole;"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"0fc3609d_9c1c418e","line":4284,"range":{"start_line":4281,"start_character":0,"end_line":4284,"end_character":7},"in_reply_to":"c1fc8d94_bc06c09b","updated":"2026-04-08 14:14:45.000000000","message":"Done","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"3b63cb5a4ee0e5a6f0f1351d0e91706f3f35cdb4","unresolved":true,"context_lines":[{"line_number":4400,"context_line":"     */"},{"line_number":4401,"context_line":"    typename ClkCls\u003cUserMixinsT\u003e::SP _mDefClkCls;"},{"line_number":4402,"context_line":""},{"line_number":4403,"context_line":"    /*"},{"line_number":4404,"context_line":"     * Flag denoting whether the packet context field class contains"},{"line_number":4405,"context_line":"     * a DefClkTsRole role field."},{"line_number":4406,"context_line":"     */"},{"line_number":4407,"context_line":"    bool _mPktCtxFcHasDefClkTsRole;"},{"line_number":4408,"context_line":"};"},{"line_number":4409,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"57e0ed7e_f70b66d2","line":4406,"range":{"start_line":4403,"start_character":0,"end_line":4406,"end_character":7},"updated":"2026-04-08 13:33:28.000000000","message":"Same.","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"},{"author":{"_account_id":1000103,"name":"Adam Greloch","email":"adam.greloch@phoenix-rtos.com","username":"adamgreloch","avatars":[{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a6aa7872e78262ab1465c9d7943beaa7.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"0dc57be71b92a7c73035e6f9ee2a7e8ac18341e7","unresolved":false,"context_lines":[{"line_number":4400,"context_line":"     */"},{"line_number":4401,"context_line":"    typename ClkCls\u003cUserMixinsT\u003e::SP _mDefClkCls;"},{"line_number":4402,"context_line":""},{"line_number":4403,"context_line":"    /*"},{"line_number":4404,"context_line":"     * Flag denoting whether the packet context field class contains"},{"line_number":4405,"context_line":"     * a DefClkTsRole role field."},{"line_number":4406,"context_line":"     */"},{"line_number":4407,"context_line":"    bool _mPktCtxFcHasDefClkTsRole;"},{"line_number":4408,"context_line":"};"},{"line_number":4409,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ce792126_2fa9c23b","line":4406,"range":{"start_line":4403,"start_character":0,"end_line":4406,"end_character":7},"in_reply_to":"57e0ed7e_f70b66d2","updated":"2026-04-08 14:14:45.000000000","message":"Done","commit_id":"67600c66b74cc663a200219dd1475285aa4b1fac"}]}