)]}'
{"tests/lib/test_bitfield.c":[{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"b8783278977355e37aafa0353527bd7884b2658d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"unsigned int srcrand_ui;"},{"line_number":55,"context_line":"unsigned long long srcrand_ull;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/*"},{"line_number":58,"context_line":" * fls: returns the position of the most significant bit."},{"line_number":59,"context_line":" * Returns 0 if no bit is set, else returns the position of the most"},{"line_number":60,"context_line":" * significant bit (from 1 to 32 on 32-bit, from 1 to 64 on 64-bit)."}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b6089edc_572d647d","line":57,"updated":"2019-05-16 19:47:13.000000000","message":"Since this is a test, I don\u0027t see a need for the inline asm versions. I\u0027d leave only the plain-C implementation.","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ac5215d70f42461c205f9fbe1c14776f3dda2d7f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"unsigned int srcrand_ui;"},{"line_number":55,"context_line":"unsigned long long srcrand_ull;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"/*"},{"line_number":58,"context_line":" * fls: returns the position of the most significant bit."},{"line_number":59,"context_line":" * Returns 0 if no bit is set, else returns the position of the most"},{"line_number":60,"context_line":" * significant bit (from 1 to 32 on 32-bit, from 1 to 64 on 64-bit)."}],"source_content_type":"text/x-csrc","patch_set":3,"id":"10449f05_6f461831","line":57,"in_reply_to":"b6089edc_572d647d","updated":"2019-05-16 20:43:24.000000000","message":"Done","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"b8783278977355e37aafa0353527bd7884b2658d","unresolved":true,"context_lines":[{"line_number":225,"context_line":"\t\t\tbt_bitfield_write(target.c, unsigned char, s, l, src_ui);"},{"line_number":226,"context_line":"\t\t\tbt_bitfield_read(target.c, unsigned char, s, l, \u0026readval);"},{"line_number":227,"context_line":"\t\t\tif (check_result(src_ui, readval, target.c, unsigned char,"},{"line_number":228,"context_line":"\t\t\t\t\t  s, l, UNSIGNED_INT_WRITE_TEST_DESC_FMT_STR)) {"},{"line_number":229,"context_line":"\t\t\t\treturn;"},{"line_number":230,"context_line":"\t\t\t}"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"3946d46f_161499d5","line":228,"updated":"2019-05-16 19:47:13.000000000","message":"Only use tabs to indent (there are 2 spaces after the last tab). The same applies to most invocations of check_result().","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ac5215d70f42461c205f9fbe1c14776f3dda2d7f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"\t\t\tbt_bitfield_write(target.c, unsigned char, s, l, src_ui);"},{"line_number":226,"context_line":"\t\t\tbt_bitfield_read(target.c, unsigned char, s, l, \u0026readval);"},{"line_number":227,"context_line":"\t\t\tif (check_result(src_ui, readval, target.c, unsigned char,"},{"line_number":228,"context_line":"\t\t\t\t\t  s, l, UNSIGNED_INT_WRITE_TEST_DESC_FMT_STR)) {"},{"line_number":229,"context_line":"\t\t\t\treturn;"},{"line_number":230,"context_line":"\t\t\t}"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c614c1db_151accd6","line":228,"in_reply_to":"3946d46f_161499d5","updated":"2019-05-16 20:43:24.000000000","message":"Done","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"b8783278977355e37aafa0353527bd7884b2658d","unresolved":true,"context_lines":[{"line_number":577,"context_line":"\t\t\tbt_bitfield_read(target.c, signed char, s, l, \u0026readval_i);"},{"line_number":578,"context_line":"\t\t\tif (check_result(src_i, readval_i, target.c, signed char,"},{"line_number":579,"context_line":"\t\t\t\t\t  s, l, SIGNED_INT_READ_TEST_DESC_FMT_STR)) {"},{"line_number":580,"context_line":"\t\t\t\treturn;"},{"line_number":581,"context_line":"\t\t\t}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"\t\t\tinit_byte_array(target.c, TEST_LEN, 0xFF);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2014fbea_025c39d2","line":580,"updated":"2019-05-16 19:47:13.000000000","message":"In case of failure, returning without invoking `fail()` will cause tap consumers to report that less tests were run than expected. Moreover, this will skip the second part of the tests of this function that is not directly related.\n\nI would split this in two functions, each with an \u0027error\u0027/\u0027fail\u0027 label that calls \"fail()\u0027 with the description string.","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ac5215d70f42461c205f9fbe1c14776f3dda2d7f","unresolved":true,"context_lines":[{"line_number":577,"context_line":"\t\t\tbt_bitfield_read(target.c, signed char, s, l, \u0026readval_i);"},{"line_number":578,"context_line":"\t\t\tif (check_result(src_i, readval_i, target.c, signed char,"},{"line_number":579,"context_line":"\t\t\t\t\t  s, l, SIGNED_INT_READ_TEST_DESC_FMT_STR)) {"},{"line_number":580,"context_line":"\t\t\t\treturn;"},{"line_number":581,"context_line":"\t\t\t}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"\t\t\tinit_byte_array(target.c, TEST_LEN, 0xFF);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f9bad8fa_b663360f","line":580,"in_reply_to":"2014fbea_025c39d2","updated":"2019-05-16 20:43:24.000000000","message":"the fail is within check_result(), and there is only one \"pass\" per inner loop to reduce output verbosity, so the number balance fine.","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"dc3ff4d5ae588defd81db776e50bee85282d05ca","unresolved":false,"context_lines":[{"line_number":577,"context_line":"\t\t\tbt_bitfield_read(target.c, signed char, s, l, \u0026readval_i);"},{"line_number":578,"context_line":"\t\t\tif (check_result(src_i, readval_i, target.c, signed char,"},{"line_number":579,"context_line":"\t\t\t\t\t  s, l, SIGNED_INT_READ_TEST_DESC_FMT_STR)) {"},{"line_number":580,"context_line":"\t\t\t\treturn;"},{"line_number":581,"context_line":"\t\t\t}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"\t\t\tinit_byte_array(target.c, TEST_LEN, 0xFF);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"246f5aca_3af6ac96","line":580,"in_reply_to":"f9bad8fa_b663360f","updated":"2019-05-17 18:55:59.000000000","message":"Done","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000006,"name":"Jérémie Galarneau","email":"jeremie.galarneau@efficios.com","username":"jgalar","avatars":[{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8689763327e5bbda7dec9f18846b60ae.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"b8783278977355e37aafa0353527bd7884b2658d","unresolved":true,"context_lines":[{"line_number":621,"context_line":"\telse"},{"line_number":622,"context_line":"\t\tnrbits_ll \u003d fls_u64(src_ll) + 1;\t/* Keep sign at 0 */"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"\t/* Read to unsigned long long readval output. */"},{"line_number":625,"context_line":"\tfor (s \u003d 0; s \u003c CHAR_BIT * TEST_LEN; s++) {"},{"line_number":626,"context_line":"\t\tfor (l \u003d nrbits_ll; l \u003c (CHAR_BIT * TEST_LEN) - s; l++) {"},{"line_number":627,"context_line":"\t\t\tinit_byte_array(target.c, TEST_LEN, 0xFF);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e107b473_bf129c64","line":624,"updated":"2019-05-16 19:47:13.000000000","message":"signed","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"},{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ac5215d70f42461c205f9fbe1c14776f3dda2d7f","unresolved":false,"context_lines":[{"line_number":621,"context_line":"\telse"},{"line_number":622,"context_line":"\t\tnrbits_ll \u003d fls_u64(src_ll) + 1;\t/* Keep sign at 0 */"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"\t/* Read to unsigned long long readval output. */"},{"line_number":625,"context_line":"\tfor (s \u003d 0; s \u003c CHAR_BIT * TEST_LEN; s++) {"},{"line_number":626,"context_line":"\t\tfor (l \u003d nrbits_ll; l \u003c (CHAR_BIT * TEST_LEN) - s; l++) {"},{"line_number":627,"context_line":"\t\t\tinit_byte_array(target.c, TEST_LEN, 0xFF);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"cf4076d5_8203da75","line":624,"in_reply_to":"e107b473_bf129c64","updated":"2019-05-16 20:43:24.000000000","message":"Done","commit_id":"653afca79f27e89ef45286a31be6a4ad1bed1374"}]}