)]}'
{"id":"babeltrace~10902","triplet_id":"babeltrace~master~I2e377f5808ea7d0a346265141b755108f98bed30","project":"babeltrace","branch":"master","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"last_update":"2023-10-24 20:10:10.000000000","reason":"Change was abandoned"},"1000001":{"account":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"last_update":"2023-09-18 21:02:35.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]}}},"hashtags":[],"change_id":"I2e377f5808ea7d0a346265141b755108f98bed30","subject":"ctf: handle CTF_MSG_ITER_STATUS_EOF in ctf_msg_iter_get_next_message","status":"ABANDONED","created":"2023-09-18 20:03:22.000000000","updated":"2023-10-24 20:10:10.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"5d9c50685f56cc48634f94807b830a1fabe8b7fd","_number":10902,"virtual_id_number":10902,"owner":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Code-Review":{"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"optional":true},"Verified":{"values":{"-2":"Failure","-1":"Not built"," 0":"No score","+1":"Unstable","+2":"Success"},"description":"CI Build results","default_value":0,"optional":true},"CI-Build":{"values":{" 0":"No score","+1":"Trigger a CI build"},"description":"Trigger CI builds","default_value":0,"optional":true},"Smoke-Build-Lvl1":{"values":{" 0":"No score","+1":"Trigger a level 1 smoke build"},"description":"Trigger Level 1 Smoke builds","default_value":0,"optional":true},"Smoke-Build-Lvl2":{"values":{" 0":"No score","+1":"Trigger a level 2 smoke build"},"description":"Trigger Level 2 Smoke builds","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-18 20:43:42.000000000","updated_by":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"state":"CC"}],"messages":[{"id":"343dd92d3df3ad04b133c67c77f640cba05d176b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2023-09-18 20:03:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0ae6aa833b793eca987fd6ae24a03d8082e5b5b8","author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2023-09-18 20:43:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ad101aae9f9bb8ab9408ac4e1d98ef1b4974e2fd","author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2023-09-18 21:02:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5d9c50685f56cc48634f94807b830a1fabe8b7fd","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"date":"2023-10-24 20:10:10.000000000","message":"Abandoned\n\nOwner says her\u0027s not sure if it\u0027s right.\n\nPlease reactivate when it\u0027s ready to verify and submit.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7d09fec5f42f3327e370966b0180d01bf37f11a3","revisions":{"7d09fec5f42f3327e370966b0180d01bf37f11a3":{"kind":"REWORK","_number":1,"created":"2023-09-18 20:03:22.000000000","uploader":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"ref":"refs/changes/02/10902/1","fetch":{"anonymous http":{"url":"https://review.lttng.org/babeltrace","ref":"refs/changes/02/10902/1","commands":{"Branch":"git fetch https://review.lttng.org/babeltrace refs/changes/02/10902/1 \u0026\u0026 git checkout -b change-10902 FETCH_HEAD","Checkout":"git fetch https://review.lttng.org/babeltrace refs/changes/02/10902/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.lttng.org/babeltrace refs/changes/02/10902/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.lttng.org/babeltrace refs/changes/02/10902/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.lttng.org/babeltrace refs/changes/02/10902/1","Reset To":"git fetch https://review.lttng.org/babeltrace refs/changes/02/10902/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"525ce19592d8bec8312d614191cba47a1e16fca8","subject":"tests: make lttng_live_server.py write temp port filename in same directory","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dbabeltrace.git;a\u003dcommit;h\u003d525ce19592d8bec8312d614191cba47a1e16fca8"}]}],"author":{"name":"Simon Marchi","email":"simon.marchi@efficios.com","date":"2023-09-18 19:47:35.000000000","tz":-240},"committer":{"name":"Simon Marchi","email":"simon.marchi@efficios.com","date":"2023-09-18 20:03:14.000000000","tz":-240},"subject":"ctf: handle CTF_MSG_ITER_STATUS_EOF in ctf_msg_iter_get_next_message","message":"ctf: handle CTF_MSG_ITER_STATUS_EOF in ctf_msg_iter_get_next_message\n\nI wrote a trace with a wrong data stream header (it says the content and\npacket sizes are 32 bytes, even though the data stream file is less than\nthat).  When reading it, babeltrace crashes with:\n\n    $ ./src/cli/babeltrace2 ~/src/babeltrace/tests/data/ctf-traces/live/stored_values/\n    09-18 15:49:19.455 301028 301028 W PLUGIN/SRC.CTF.FS/DS build_index_from_idx_file@data-stream-file.cpp:683 [auto-disc-source-ctf-fs] Invalid LTTng trace index file; indexed size !\u003d stream file size: file-size\u003d4, total-packets-size\u003d8192\n    09-18 15:49:19.455 301028 301028 E PLUGIN/CTF/MSG-ITER ctf_msg_iter_get_next_message@msg-iter.cpp:2715 [auto-disc-source-ctf-fs] Cannot handle state: msg-it-addr\u003d0x613000000580, state\u003dDSCOPE_EVENT_PAYLOAD_CONTINUE\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:63 Babeltrace 2 library postcondition not satisfied.\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:65 ------------------------------------------------------------------------\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:66 Condition ID: `post:message-iterator-class-next-method:no-error-if-no-error-status`.\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:68 Function: bt_message_iterator_class_next_method().\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:69 ------------------------------------------------------------------------\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:70 Error is:\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:72 Current thread has an error, but user function returned a non-error status: status\u003dOK\n    09-18 15:49:19.455 301028 301028 F LIB/ASSERT-COND bt_lib_assert_cond_failed@assert-cond.c:75 Aborting...\n\nThe problem is that ctf_msg_iter_get_next_message does not handle\nCTF_MSG_ITER_STATUS_EOF.  Execution goes in the \"else\" that is meant for\nerror handling.  We return a non-error status with an error set on\nthe current thread, which is a post-condition breach.\n\nChange-Id: I2e377f5808ea7d0a346265141b755108f98bed30\n","web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dbabeltrace.git;a\u003dcommit;h\u003d7d09fec5f42f3327e370966b0180d01bf37f11a3"}],"resolve_conflicts_web_links":[{"name":"gitweb","tooltip":"Open in GitWeb","url":"/gitweb?p\u003dbabeltrace.git;a\u003dcommit;h\u003d7d09fec5f42f3327e370966b0180d01bf37f11a3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}