)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"dada6bb3596c0d7e5ec08a45561495193ec585c2","unresolved":true,"context_lines":[{"line_number":23,"context_line":"genenerates the version string, so that the same hash representation is"},{"line_number":24,"context_line":"generated during both \"make\" and \"sudo make install\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I979d6a9d627f133909dc026e0d2820b52f409d98"},{"line_number":27,"context_line":"Signed-off-by: Simon Marchi \u003csimon.marchi@efficios.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a82d5cbb_bfae5e86","line":26,"updated":"2023-05-25 20:27:26.000000000","message":"Add:\n\n    Fixes: https://bugs.lttng.org/issues/1376\n    \n?","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e121322001b91b5631274733ea1bbdd0139dc20f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"genenerates the version string, so that the same hash representation is"},{"line_number":24,"context_line":"generated during both \"make\" and \"sudo make install\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I979d6a9d627f133909dc026e0d2820b52f409d98"},{"line_number":27,"context_line":"Signed-off-by: Simon Marchi \u003csimon.marchi@efficios.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"85ed0fd1_db10eac8","line":26,"in_reply_to":"a82d5cbb_bfae5e86","updated":"2023-05-26 02:55:12.000000000","message":"Done","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000009,"name":"Mathieu Desnoyers","email":"mathieu.desnoyers@efficios.com","username":"compudj","avatars":[{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/7326b3e1d32b971a5e69d9730228c428.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"d577f92f11729a31ae8e2686aa93e8d246c0c628","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91fd5dc9_05f0e752","updated":"2023-05-25 20:37:52.000000000","message":"Trying to do make install as root gives me:\n\nmake[2]: Entering directory \u0027/home/compudj/git/babeltrace/src/common\u0027\n  GEN      version.i\nfatal: detected dubious ownership in repository at \u0027/home/compudj/git/babeltrace\u0027\nTo add an exception for this directory, call:\n\n\tgit config --global --add safe.directory /home/compudj/git/babeltrace","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"727adb1be47ace393bb2fd89147e82655ebf4123","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90e79237_956ecb18","in_reply_to":"1d53c346_a009650d","updated":"2023-05-26 12:32:37.000000000","message":"So, I\u0027ll add a `|| true` to that `git describe` command.  The purpose of this patch is not to change the behavior.  I\u0027ll look into doing another patch that changes the behavior on top.","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"209613ed6e5fd76567fde35e9f9068cb2d7b2d8f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d53c346_a009650d","in_reply_to":"711cf449_92ee89d9","updated":"2023-05-26 04:15:25.000000000","message":"Ah thanks, that was my intuition as well.  I thought I tried switching to root using `su`, but apparently not, I must have used `sudo -i`.  Now I see the same error as Mathieu.\n\nSo, it\u0027s this command that fails:\n\n    git describe --tags --dirty --abbrev\u003d12\n \nMathieu, your use case is already kind of broken prior to this patch.  The version.i generated when you do \"make\" contains:\n\n    #define BT_VERSION_GIT \"v1.2.0-3712-gb2121a6933fc\"\n \nAnd the version.i generated when you do \"make install\" contains:\n\n    #define BT_VERSION_GIT \"\"\n \n... because the git describe command failed.  It\u0027s just that the failure was ignored.\n\nNow, I can change the script such that a failure of that git describe command is ignored, just as before.  That will keep the existing behavior.  But it\u0027s probably not the best behavior either.","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"650305c30b3c0d671bcab11101295bc54f4c05c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45065aa4_bb9c1ec5","in_reply_to":"90e79237_956ecb18","updated":"2023-05-26 16:27:37.000000000","message":"Done","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000005,"name":"Philippe Proulx","email":"eeppeliteloop@gmail.com","username":"eepp","avatars":[{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/782ed01c10b1b6850242d6e4eeb73aa9.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4246fdb4dce81ff5f8b46a00d41b251890f19b98","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"711cf449_92ee89d9","in_reply_to":"91b12d69_3a3fde4e","updated":"2023-05-26 03:32:10.000000000","message":"Probably because you\u0027re using sudo (my assumption) and Mathieu is using `su` (as he unveils in his [issue](https://bugs.lttng.org/issues/1376)).\n\nThe `sudo` command sets a few environment variables to indicate who\u0027s the sudoer to the world:\n\n```\n$ sudo env | ag sudo\nSUDO_COMMAND\u003d/usr/bin/env\nSUDO_USER\u003deepp\nSUDO_UID\u003d1000\nSUDO_GID\u003d1000\n```\n\nNow Git considers those variables, as explained in `git-config(1)`:\n\n\u003e As explained, Git only allows you to access repositories owned by yourself, i.e. the user who is running Git, by default. When Git is running as `root` in a non Windows platform that provides sudo, however, git checks the `SUDO_UID` environment variable that sudo creates and will allow access to the uid recorded as its value in addition to the id from `root`. This is to make it easy to perform a common sequence during installation \"make \u0026\u0026 sudo make install\". A git process running under sudo runs as `root` but the `sudo` command exports the environment variable to record which id the original user has.","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"680684dca6ad48f1e787dd80c90af482e5a4bf3a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91b12d69_3a3fde4e","in_reply_to":"91fd5dc9_05f0e752","updated":"2023-05-26 03:05:11.000000000","message":"I kind of understand why you would get that, since we run git commands as root in a git repo owned by your user (with the previous code, it probably happened but didn\u0027t cause the script to abort).  But I don\u0027t understand why I don\u0027t see it.","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"}],"src/common/gen-version-i.sh":[{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"4cdea821a302ef7a583d301d7395018b06e7d377","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# If \"bootstrap\" and \".git\" exists in the top source directory and the git"},{"line_number":33,"context_line":"# executable is available, get the current git version string in the form:"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  \"latest_tag\"(-\"number_of_commits_on_top\")(-g\"latest_commit_hash\")(-dirty)"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# And store it in \"version.i.tmp\", if the current commit is tagged, the tag"},{"line_number":38,"context_line":"# starts with \"v\" and the tree is clean, consider this a release version and"}],"source_content_type":"text/x-sh","patch_set":1,"id":"06bed02c_a5406e74","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":66},"updated":"2023-05-25 20:15:14.000000000","message":"Maybe document the abbrev value here.","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"e121322001b91b5631274733ea1bbdd0139dc20f","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# If \"bootstrap\" and \".git\" exists in the top source directory and the git"},{"line_number":33,"context_line":"# executable is available, get the current git version string in the form:"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  \"latest_tag\"(-\"number_of_commits_on_top\")(-g\"latest_commit_hash\")(-dirty)"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# And store it in \"version.i.tmp\", if the current commit is tagged, the tag"},{"line_number":38,"context_line":"# starts with \"v\" and the tree is clean, consider this a release version and"}],"source_content_type":"text/x-sh","patch_set":1,"id":"bf66a69f_8d595623","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":66},"in_reply_to":"06bed02c_a5406e74","updated":"2023-05-26 02:55:12.000000000","message":"Do you have something in mind?  I don\u0027t see what to document here.","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000001,"name":"Simon Marchi","email":"simon.marchi@efficios.com","username":"simark","avatars":[{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5f66b515fa1c72f5ab184df919253b2f.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"650305c30b3c0d671bcab11101295bc54f4c05c4","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# If \"bootstrap\" and \".git\" exists in the top source directory and the git"},{"line_number":33,"context_line":"# executable is available, get the current git version string in the form:"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  \"latest_tag\"(-\"number_of_commits_on_top\")(-g\"latest_commit_hash\")(-dirty)"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# And store it in \"version.i.tmp\", if the current commit is tagged, the tag"},{"line_number":38,"context_line":"# starts with \"v\" and the tree is clean, consider this a release version and"}],"source_content_type":"text/x-sh","patch_set":1,"id":"f99df65b_dac6161c","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":66},"in_reply_to":"985a44ca_a55ba8f2","updated":"2023-05-26 16:27:37.000000000","message":"I eventually understood that your `[:12]` was like the Python slice syntax.  I don\u0027t think it\u0027s very clear.  I will add a sentence to say why we use a fixed abbrev value.","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"ad7baf167c05fa03e2b2e88daeb83a2779648040","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# If \"bootstrap\" and \".git\" exists in the top source directory and the git"},{"line_number":33,"context_line":"# executable is available, get the current git version string in the form:"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  \"latest_tag\"(-\"number_of_commits_on_top\")(-g\"latest_commit_hash\")(-dirty)"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# And store it in \"version.i.tmp\", if the current commit is tagged, the tag"},{"line_number":38,"context_line":"# starts with \"v\" and the tree is clean, consider this a release version and"}],"source_content_type":"text/x-sh","patch_set":1,"id":"985a44ca_a55ba8f2","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":66},"in_reply_to":"bf66a69f_8d595623","updated":"2023-05-26 14:50:18.000000000","message":"Something like?\n\nlatest_commit_hash[:12]\n\nBut it might not be that useful 🤷","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"},{"author":{"_account_id":1000000,"name":"Michael Jeanson","email":"mjeanson@efficios.com","username":"mjeanson","avatars":[{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c4da886b09863c0cdc46c81556b9fa25.jpg?d\u003dretro\u0026r\u003dr\u0026s\u003d120","height":120}]},"change_message_id":"354f5982380ecaca1b15ec95e54bdc31b2ef7430","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# If \"bootstrap\" and \".git\" exists in the top source directory and the git"},{"line_number":33,"context_line":"# executable is available, get the current git version string in the form:"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"#  \"latest_tag\"(-\"number_of_commits_on_top\")(-g\"latest_commit_hash\")(-dirty)"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# And store it in \"version.i.tmp\", if the current commit is tagged, the tag"},{"line_number":38,"context_line":"# starts with \"v\" and the tree is clean, consider this a release version and"}],"source_content_type":"text/x-sh","patch_set":1,"id":"8bc0f69b_0e7275f1","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":66},"in_reply_to":"f99df65b_dac6161c","updated":"2023-05-26 18:15:27.000000000","message":"Ack","commit_id":"2257ff085fc0f4bbe5faf9e377db923725ba9ff6"}]}